Skip primitive type input ports from node-autocomplete #11201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
reviewed
Oct 23, 2020
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
QilongTang
reviewed
Oct 23, 2020
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
QilongTang
reviewed
Oct 26, 2020
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
QilongTang
approved these changes
Oct 26, 2020
Contributor
QilongTang
left a comment
There was a problem hiding this comment.
LGTM with one comment
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
QilongTang
reviewed
Oct 27, 2020
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
Outdated
Show resolved
Hide resolved
Contributor
|
@zeusongit Nice job, once the comment updated, I think we can get this in |
aparajit-pratap
approved these changes
Oct 27, 2020
Contributor
|
@zeusongit Do you mind cherry pick this one to 2.9.0 branch? |
zeusongit
added a commit
that referenced
this pull request
Oct 27, 2020
* Add list of nodes to be skipped * Add test and comments
zeusongit
added a commit
that referenced
this pull request
Oct 27, 2020
* Add list of nodes to be skipped * Add test and comments
zeusongit
pushed a commit
that referenced
this pull request
Oct 27, 2020
This reverts commit 3ae917f.
zeusongit
added a commit
to zeusongit/Dynamo
that referenced
this pull request
Oct 27, 2020
* Add list of nodes to be skipped * Add test and comments
QilongTang
pushed a commit
that referenced
this pull request
Oct 27, 2020
QilongTang
pushed a commit
that referenced
this pull request
Oct 29, 2020
…1219) * Skip primitive type input ports from node-autocomplete (#11201) * Add list of nodes to be skipped * Add test and comments * Add Analytics Coverage for Node AutoComplete (#11209) * add analytics coverage for node autocomplete Open auto complete window Select suggestion * Update NodeAutoCompleteSearchControl.xaml.cs * add tracking to in-canvas search node selection * add track points for in canvas search open/select Co-authored-by: Ashish Aggarwal <ashish.zeus17@gmail.com> Co-authored-by: Ashish Aggarwal <ashish.zeus17@gmail.com>
QilongTang
pushed a commit
that referenced
this pull request
Nov 5, 2020
…Nodeautocomplete and Incanvas search (#11232) (#11235) * Skip primitive type input ports from node-autocomplete (#11201) * Add list of nodes to be skipped * Add test and comments * Add Analytics Coverage for Node AutoComplete (#11209) * add analytics coverage for node autocomplete Open auto complete window Select suggestion * Update NodeAutoCompleteSearchControl.xaml.cs * add tracking to in-canvas search node selection * add track points for in canvas search open/select Co-authored-by: Ashish Aggarwal <ashish.zeus17@gmail.com> * cherrypicking adp code change for node auto Co-authored-by: Ashish Aggarwal <ashish.zeus17@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
DYN-3184
Skip primitive input ports when displaying node autocomplete suggestions.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo
FYIs
@QilongTang