Various module and NSF driver fixes#342
Merged
Gumball2415 merged 12 commits intomainfrom Jun 15, 2025
Merged
Conversation
...on N163-only .nsfs Fixes #337. - Don't write .asm data if it doesn't exist - Fix `ft_channel_enable` in .asm export
c62e100 to
2588546
Compare
98c3fc0 to
40778ad
Compare
This fixes #340. - Add debug args, fix stderr printing in build_engine.py
8e9f99a to
78c964c
Compare
- build_engine.py: Print stdout/stderr before exiting
78c964c to
a65f0c6
Compare
...in NSF driver This fixes #344. - Refactor N163 wave .asm printing
7 tasks
Merged
Gumball2415
added a commit
that referenced
this pull request
Jan 7, 2026
This pull request aims to fix various tracker interface and playback issues. This pull request improves upon and supercedes #342. --- Changes in this PR: - Revert "Fix C-0 not previewing DPCM sample" (@damifortune @Gumball2415 #383 #394) - This reverts commit ac26484. - There doesn't seem to be any bug at the time of its writing upon further scrutiny. - This fixes #383. - Separate tempo state updating from channel state updating (@JG540 @Gumball2415 #382 #384 #394) - This fixes #382. - This fixes #384. - Set `m_iSpeed` to default when groove is enabled (@TakuikaNinja @Gumball2415 #379 #394) - This fixes #379.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to fix various bugs in the NSF driver and the tracker interface.
This pull request improves upon and supercedes #262.
Changes in this PR:
ft_channel_enablein .asm export to list used channelsUSE_ALLwhen using all expansion audio flags