TODO: fix linear pitch pitch sequences

fixed in 4ce047d

TODO: fix asm export DPCM start address issue with beep.dnm

fixed in fa05bd9

• is ChunkRenderText used for assembly export? i have not tested it, do you know it works for generating nsfs or games?
• // str.Format("; Bank %i\n", pChunk->GetBank()); generally when making a PR i usually delete code or clarify why it's not needed, instead of commenting out (which can confuse the next reader what the code is there for)
• i do not know enough of the code to provide meaningful feedback
• what is pChunk->StoreByte(m_iWaveCount);? does this allow the runtime driver to bounds-check an instrument? seems the driver was modified to take into account, at comment check if within actual wave count.
• PatternCompiler.cpp is giving me flashbacks to (invalid) notes popping up in 0cc 0.3.15.x when it corrupted its own memory
  • did you both turn Print into a template that calls _sntprintf_s internally (the more characters you put around printf the more powerful it is 😉), and only call it with CString::Format() single strings? in theory this would be dangerous if a % sign pops up in the string and the sprintf-like call thinks it's a format specifier and corrupts memory instead, but in practice it seems you only call the function with error messages populated with just integers.
• have not looked through the pattern editor code, seems you replaced (invalid) with question marks?

responses in the same list order:

• CChunkRenderText handles writing the module data into a CA65 assembly representation (much like how CChunkRenderBinary handles writing module data into compiled PRG bytes for .bin)
• noted, will amend this.
• not much comment, other than this is also a good reason why documentation should be improved
• this stores the amount of waves an N163 instrument contains to help with bounds checking when indexing wave data. this was commented out in the source code of both the tracker and NSF driver as early as vanilla 0.4.0.
• i forgot why i changed it like that, maybe just a hack for formatted string printing?
  • edit: this implementation is directly copied from ExportDialog.cpp. all it does is replace LF line endings with CRLF for MFC.
  • this will be part of an eventual goal to substitute CString with std::string whenever possible (Replace CString with std::string #258)
• i changed it from printing (invalid) to ? to fit the text within each note, instrument, volume, and effect command.
  • more work needs to be done to create a more comprehensive and centralized pattern validator ([Feature] Pattern data validator #312)