Update NSF Driver and NSF-related things by Gumball2415 · Pull Request #156 · Dn-Programming-Core-Management/Dn-FamiTracker

Gumball2415 · 2022-08-05T11:15:16Z

This PR improves upon, and supercedes PR #80.

Implement Kxx
Implement =xx
Finalize volume system (mentioned in Remove "Cut sub-volume" option, make volume levels match between tracker and NSF export #107)
Finalize hold note behavior (mentioned in Hold instrument behavior inconsistent between tracker and NSF export #94 and Hold Effect (&&) Bug #63)
Fix NSFe export
Implement NSF2 export
Export period and vibrato tables, and other supplemental NSF data on .asm and .bin export
Implement VRC7 NSFe chunk, allowing for user-defined OPLL hardware patches

Changes in this PR:

Refactor FDS auto-FM overflow fix (from NSF driver fixes #80, resolves FDS FM values exported incorrectly to NSF nyanpasu64/j0CC-FamiTracker#133, resolves [bug] FDS modulator overflow in NSF export #65)
Refactor Pxx overflow fix (from NSF driver fixes #80)
Refactor Gxx overflow fix (from NSF driver fixes #80, resolves NSF DPCM desync on very long Gxx nyanpasu64/j0CC-FamiTracker#129)
Implement effect Kxx
Implement =xx in NSF driver and in available channels (resolves MMC5 pulse phase reset Support. nyanpasu64/j0CC-FamiTracker#122)
Reset FDS modulator phase on new note
Fix N163 instrument pointer data overflow
Fix NSFe export from using incorrect DATA chunk size (fixes Large modules break NSFe file export #110, fixes Corrupted NSFe exports for large files nyanpasu64/j0CC-FamiTracker#5)
Add mixe chunk support and per-module device mixing (addresses Per-module audio profiles? #68)
Refactor period table calculation
Fix 5B Wxx being overwritten by blank duty macros (fixes [Issue Reporting/Feature Request] Sunsoft 5B Wxx command #160, fixes Fix bug where 5B NSF driver skips last entry in noise sequence nyanpasu64/j0CC-FamiTracker#105)
Add supplemental NSF data on .bin/.asm export (NSF header, NSF config, period and vibrato tables)
Implement external OPLL patchset editing (resolves Per-module audio profiles? #68)
Implement VRC7 NSFe chunk
Fix N163 multiplex state desync (fixes N163 multiplexing not keeping state properly #163)
Add hardware-based expansion audio mixing
Dn-FamiTracker 0.5.0.0 modules are no longer backwards compatible with Vanilla and 0CC
FamiTracker Beta 0.5.0 modules no longer conflict with Dn-FamiTracker 0.5.0.0 modules
Update text import/export feature parity (fixes Add Missing Commands to Text import and export #161, fixes Implement Linear Period/Pitch Property in Text Format #162)

Delay commands are now cut when a new row is processed, matching in-tracker behavior.

Thanks zeta0134 for pointing it out! This fixes #110 This also fixes nyanpasu64/j0CC-FamiTracker#5

The improved formulas are derived from the NESDev wiki.

- Properly load title string using application's instance handle - Clarify ASAN build documentation

- Add check for VRC7 in OPLL settings

This resolves issue #162.

Partially resolves #161.

- Update PARAMS block to write playback rate and type

- Fix external OPLL modules not being saved properly - Prevent modules being set modified on text export

Partially addresses #168.

Fixes #170.

Fixes #224. Iterates upon #156.

Fixes #224. Fixes #260. Iterates upon #156.

Gumball2415 added 21 commits August 4, 2022 11:02

Revert FDS auto-FM overflow fix

db1145a

Clamp FDS auto-FM mod frequency in NSF driver

b4d6b6e

Implement Kxx in NSF driver

b20121c

Optimize Kxx calculation

129621b

Implement K00 behavior

6fe5768

Fix pitch underflow/overflow

0967485

Implement =xx for available channels

ae6ba4b

Reset FDS modulator phase on new note

ec296ce

Fix FDS mod table write

482c803

Attempt to fix FDS mod phase reset delay

0154b92

Add FDS loop cycle delays

c981acc

Properly disable frame IRQs

a4c985c

Refactor driver name

c37db04

Implement =xx in NSF driver

4305b3d

Avoid N163 instrument pointer overflow

638894f

Refactor delay command overflow

4ff0be3

Delay commands are now cut when a new row is processed, matching in-tracker behavior.

Optimize phase reset processing

f2dad6c

Reorder NSFe chunks; add text chunk

767c9b0

Get actual size of DATA chunk directly

86706dc

Thanks zeta0134 for pointing it out! This fixes #110 This also fixes nyanpasu64/j0CC-FamiTracker#5

Only write text chunk if available

744b199

Add RATE chunk

9045c71

Gumball2415 force-pushed the fix-nsf-driver branch from 3ac47b8 to 9045c71 Compare September 21, 2022 14:40

Gumball2415 added 8 commits September 22, 2022 00:52

Rename to TotalDataSize for clarity

57b4bd5

Reorder NSFe exporter entry

0a95008

Reorder NSFe export entry in commandline

43bf13d

Correct note table tuning

c367af6

The improved formulas are derived from the NESDev wiki.

Round to nearest int

d61f793

Update note table in driver

a6aefcf

Use std::lround() for better decimal rounding

27de9a5

Remove whitespace

3efd0ba

Gumball2415 added 23 commits December 10, 2022 03:57

ASAN build sanity check

53e786b

- Properly load title string using application's instance handle - Clarify ASAN build documentation

Avoid conflict with FamiTracker Beta 0.5.0 modules

d94d302

- Add check for VRC7 in OPLL settings

Derive mixe default values from settings

37cd94c

Avoid more effect type conversion

8b4fd2b

Avoid document read corruption in FDS modules

7c63f6a

Refactor survey mix override

f6ec183

Run CSoundGen thread in commandline export

2672f0f

Initialize survey level object instead

4acaedc

Clarify text export format

95235f2

Add bookmarks to text export

8161a54

Add linear pitch to text export

9cb3c9a

This resolves issue #162.

Begin to implement playback rate and type

0b6d710

Partially resolves #161.

Implement TUNING file block

4523984

- Update PARAMS block to write playback rate and type

Add module version to text export

e632855

Improve text export layout

5cbded6

Add JSON block to text export

b98879d

Add PARAMS_EMU block to text export

a72da68

- Fix external OPLL modules not being saved properly - Prevent modules being set modified on text export

Refactor OPLL patch reset

37db988

Cleanup

f6220d7

Refactor commandline output

4095f91

Partially addresses #168.

Non-VRC7 modules do not require external OPLL

d868d24

Update VisualizerWnd.cpp

e51326e

Fixes #170.

Customize static bitmap font

f1dbf3a

Gumball2415 merged commit 3d9cbf3 into master Dec 19, 2022

Gumball2415 mentioned this pull request Feb 3, 2023

NSF driver fixes #189

Merged

Gumball2415 mentioned this pull request Mar 10, 2023

Module interaction fixes #195

Merged

Gumball2415 added a commit that referenced this pull request Feb 17, 2024

Fix N163 instrument load clobbering Kxx state

d252309

Fixes #224. Iterates upon #156.

Gumball2415 mentioned this pull request Feb 17, 2024

NSF Driver and Export Fixes #262

Merged

Gumball2415 mentioned this pull request Feb 27, 2024

NSF export effects state corruption? #207

Closed

Gumball2415 added a commit that referenced this pull request Mar 22, 2024

Fix N163 instrument load clobbering Kxx state

861f682

Fixes #224. Fixes #260. Iterates upon #156.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update NSF Driver and NSF-related things#156

Update NSF Driver and NSF-related things#156
Gumball2415 merged 105 commits intomasterfrom
fix-nsf-driver

Gumball2415 commented Aug 5, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Gumball2415 commented Aug 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes in this PR:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Gumball2415 commented Aug 5, 2022 •

edited

Loading