Skip to content

Conversation

@paulpv
Copy link
Member

@paulpv paulpv commented Jul 27, 2024

paulpv added 21 commits July 23, 2024 08:19
6.0: 1 of [hopefully] 2: Rebrand to "DistroAV".  

There may be other PRs required to to support any required detecting and migrating of OBS-NDI.

2 of 2 will be the NDI6 changes, but I *may* hold off on creating and merging that much smaller and self contained PR until this big stuff is out of the way.

The reason(s) why I want to hold off the NDI6 change until the end is because:
1. It is pretty small.
2. If I put this in first then an argument could be made to release it on its own before all of the other non-NDI6 changes are done. I do not want this to happen.
3. Holding off on this will better force the other PRs to be finished before NDI6 is added as the final cherry on top.
@paulpv paulpv marked this pull request as draft July 28, 2024 08:31
@paulpv paulpv force-pushed the 6.0.0_actual branch 2 times, most recently from ae4b17c to d4d5d19 Compare July 30, 2024 01:42
@paulpv paulpv mentioned this pull request Jul 30, 2024
paulpv and others added 23 commits August 7, 2024 22:40
build: Change plugin binary file from `DistroAV` to lowercase `distroav`
source: clean up code/formatting and tweak logging
I am changing from direct `blog(...)` calls to the template "recommended" `obs_log(...)`.
This cleans up the code a little bit to get rid of the redundant "[DistroAV] " prefixes.
This also lets the code gate the log levels a little better.
I have waffled on doing this several times but I am finally biting the bullet on this.

blog already uses va_list, so this is not much worse.
The only "worse" part is the dynamically allocated and freed buffer used by snprintf.
Hopefully this does not thrash memory too much.
6.0.0 logging & command-line argument tweaks
Also using `PLUGIN_DISPLAY_NAME` instead of `PLUGIN_NAME`
More to come.
I will move the ones in the root to a more appropriate folder in the future.
#1076)

* main output initialized at startup, start/stop doesn't create or destroy it
* output: refactor main/preview output to support "remote" start/stop
---------
Co-authored-by: Ignacio J. Venezia <ignaciovenezia@pircasolutions.com.ar>
Co-authored-by: Paul Peavyhouse <pv@swooby.com>
* source/outputs: logging fixes, tweaks, and cleanup
fix log initialize by removing LOG_NONE logic
* config: add `static void Initialize()`
* source: avoid config comparisons in receiver loop == improve performance
The receiver loop no longer does heavy config change comparisons.
Any config change is now determined in the main UI thread
that then sets a `bool reset_ndi_receiver` for the receiver loop
to quickly reset itself.

Also resetting if hw_accel_enabled is changed.

PTZ and Tally are still calculated in the receiver loop, but only if they are enabled.
@RayneYoruka
Copy link
Member

Will test again in a few days and see if I see any issues.. anything specific I should be looking for?

@paulpv
Copy link
Member Author

paulpv commented Aug 16, 2024

anything specific I should be looking for?

Uh... Everything? :)

I think it is finally ready enough for the planned "pre-release".

I can push that out and you can use its release notes summary as some things to focus on.

@paulpv
Copy link
Member Author

paulpv commented Aug 16, 2024

This PR is huge, but everything major change in it has gone through multiple smaller PRs that were reviewed.

I am going to merge this and create a pre-release of 6.0.

We may still make some last minute changes to Behavior before final release.

@paulpv paulpv merged commit 000c526 into master Aug 16, 2024
@paulpv paulpv deleted the 6.0.0_actual branch August 16, 2024 06:26
@RayneYoruka
Copy link
Member

I can push that out and you can use its release notes summary as some things to focus on.

Sounds good, this way I'll be able to test everything one by one

@RayneYoruka
Copy link
Member

It seems the 6.0.0 release does not detect the NDI runtime while installing on a portable install of obs. This seems to happen to an user on the discord server. Should look in to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

alpha-rc-release Issues targeting a non-stable release Seeking Testers PRs with this label will package the plugin so that others can test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants