-
-
Notifications
You must be signed in to change notification settings - Fork 419
source: NDI5+ hardware acceleration #1073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1ee4236 to
64ac9ea
Compare
64ac9ea to
602e774
Compare
602e774 to
306ee04
Compare
|
@Trouffman As mentioned in Discord, this "feature" is a little silly and never worked in NDI5 and somehow we survived. Options:
I think an option is best. |
|
Option 2. |
38780e7 to
762aa9b
Compare
|
I considered turning this on by default, but I do not think that we should because there is no way to directly turn this off for someone who does not want this enabled. The only way I can think of to turn this off is to maybe reset the receiver, which is not intuitive how to do. One other way is to require the user to close and reopen OBS! 😦 |
|
"Forcing" a receiver reset on a settings change could be the way, this is already the case for some of them. |
I have a solution for that in another PR, so I will go ahead and merge this relatively tiny PR. |
NDI5 changed the hardware acceleration request from
<ndi_hwaccel enabled="true"/>to<ndi_video_codec type="hardware"/>.We've never updated our code,
I'm updating our code. :)
Adding a long extensive comment in the code.
See also: