6.0.0 logging & command-line argument tweaks #1077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef6b506 to
9ba9a31
Compare
I am changing from direct `blog(...)` calls to the template "recommended" `obs_log(...)`. This cleans up the code a little bit to get rid of the redundant "[DistroAV] " prefixes. This also lets the code gate the log levels a little better. I have waffled on doing this several times but I am finally biting the bullet on this. blog already uses va_list, so this is not much worse. The only "worse" part is the dynamically allocated and freed buffer used by snprintf. Hopefully this does not thrash memory too much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am changing from direct
blog(...)calls to the template "recommended"obs_log(...).This cleans up the code a little bit to get rid of the redundant "[DistroAV] " prefixes.
This also lets the code gate the log levels a little better.
I have waffled on doing this several times but I am finally biting the bullet on this.
blogalready usesva_list, so this is not much worse.The only "worse" part is the dynamically allocated and freed buffer used by
snprintf.Hopefully this does not thrash memory too much.