remove(@hapi/nes): remove just sources of the package for #66292 #66372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yped#66292 This is technical removal. In DefinitelyTyped#66292 there is an effort to update DT for upcoming TS language changes (see linked PR for details) and updating this specifc DT package (@hapi/nes) to pass checks againsts current status of TS language would prove fruitless. The upstream JS package already progressed and DT types are out of sync with current module. One could just revert this PR, in case of change to @hapi/nes types is to be done in future. Thank you for your understanding!
Contributor
|
@peterblazejewicz Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 66372,
"author": "peterblazejewicz",
"headCommitOid": "d33826d30bba6693b59bb735c6ae12d00de30f96",
"mergeBaseOid": "15ee4f9f362d9c555838b9e921ee20ccdafa7790",
"lastPushDate": "2023-08-12T14:07:47.000Z",
"lastActivityDate": "2023-08-12T14:07:47.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "hapi__nes",
"kind": "delete",
"files": [
{
"path": "types/hapi__nes/.eslintrc.json",
"kind": "package-meta",
"suspect": "edited"
},
{
"path": "types/hapi__nes/index.d.ts",
"kind": "definition"
},
{
"path": "types/hapi__nes/lib/client.d.ts",
"kind": "definition"
},
{
"path": "types/hapi__nes/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/hapi__nes/test/broadcast-client.ts",
"kind": "test"
},
{
"path": "types/hapi__nes/test/broadcast-server.ts",
"kind": "test"
},
{
"path": "types/hapi__nes/test/client-require.ts",
"kind": "test"
},
{
"path": "types/hapi__nes/test/hapi__nes-tests.ts",
"kind": "test"
},
{
"path": "types/hapi__nes/test/route-authentication-client.ts",
"kind": "test"
},
{
"path": "types/hapi__nes/test/route-authentication-server.ts",
"kind": "test"
},
{
"path": "types/hapi__nes/test/route-invocation-client.ts",
"kind": "test"
},
{
"path": "types/hapi__nes/test/route-invocation-server.ts",
"kind": "test"
},
{
"path": "types/hapi__nes/test/socket.ts",
"kind": "test"
},
{
"path": "types/hapi__nes/test/subscription-filter-client.ts",
"kind": "test"
},
{
"path": "types/hapi__nes/test/subscription-filter-server.ts",
"kind": "test"
},
{
"path": "types/hapi__nes/test/subscriptions-client.ts",
"kind": "test"
},
{
"path": "types/hapi__nes/test/subscriptions-server.ts",
"kind": "test"
},
{
"path": "types/hapi__nes/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/hapi__nes/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"NoHomey",
"saboya",
"lenovouser"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 1675932763,
"ciResult": "pass"
} |
Contributor
|
🔔 @NoHomey @saboya @lenovouser — please review this PR in the next few days. Be sure to explicitly select |
afharo
pushed a commit
to afharo/DefinitelyTyped
that referenced
this pull request
Aug 24, 2023
…yped#66292 (DefinitelyTyped#66372) This is technical removal. In DefinitelyTyped#66292 there is an effort to update DT for upcoming TS language changes (see linked PR for details) and updating this specifc DT package (@hapi/nes) to pass checks againsts current status of TS language would prove fruitless. The upstream JS package already progressed and DT types are out of sync with current module. One could just revert this PR, in case of change to @hapi/nes types is to be done in future. Thank you for your understanding!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technical removal of TS module source code.
In #66292 there is an effort to update DT for upcoming TS language changes (see linked PR for details) and updating this specific DT package (@hapi/nes) to pass checks against current status of TS language would prove too much time consuming. The upstream JS package already progressed and DT types are out of sync with current module. One could just revert this PR, in case of change to @hapi/nes types is to be done in future.
Current @hapi/nes (v13):
https://github.com/hapijs/nes/releases/tag/v13.0.1
Thank you for your understanding!