Skip to content

chore: migrate module keyword to namespace #66292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sandersn merged 3 commits into from
Aug 25, 2023
Merged

chore: migrate module keyword to namespace #66292

sandersn merged 3 commits into from
Aug 25, 2023

Conversation

@JoshuaKGoldberg
Copy link
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 5, 2023 •
edited
Loading

Overview

Ref: microsoft/TypeScript#51825

Enables @typescript-eslint/prefer-namespace-keyword in this repo. The steps I took were pretty straightforward:

  1. Replaced the rules object in .eslintrc.cjs with { '@typescript-eslint/prefer-namespace-keyword': 'error' }
  2. Replaced eslint- in comments with JOSH_IGNORE_- (so that ESLint wouldn't error on missing rules)
  3. Ran npx eslint "./types/**/*.ts" "./types/**/*.tsx" --fix
  4. Undid the JOSH_IGNORE_- replacements
  5. Reset .eslintrc.cjs back to master, then added the '@typescript-eslint/prefer-namespace-keyword': 'error' at the end of rules

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Aug 5, 2023
Closed
JoshuaKGoldberg
JoshuaKGoldberg commented Aug 5, 2023
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review August 11, 2023 18:49
ElizabethSamuel-MSFT
ElizabethSamuel-MSFT approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@ElizabethSamuel-MSFT ElizabethSamuel-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signing off for office-js and office-js-preview - our downstream processes and documentation aren't adversely affected

peterblazejewicz added a commit to peterblazejewicz/DefinitelyTyped that referenced this pull request Aug 12, 2023
@peterblazejewicz
remove(@hapi/nes): remove just sources of the package for DefinitelyT…
d33826d 
…yped#66292

This is technical removal. In DefinitelyTyped#66292 there is an effort to update DT for
upcoming TS language changes (see linked PR for details) and updating
this specifc DT package (@hapi/nes) to pass checks againsts current
status of TS language would prove fruitless. The upstream JS package
already progressed and DT types are out of sync with current module.
One could just revert this PR, in case of change to @hapi/nes types is
to be done in future.

Thank you for your understanding!
@peterblazejewicz peterblazejewicz mentioned this pull request Aug 12, 2023
Merged
2 tasks
weswigham pushed a commit that referenced this pull request Aug 15, 2023
@peterblazejewicz
remove(@hapi/nes): remove just sources of the package for #66292 (#66372
34ad8f5 
)

This is technical removal. In #66292 there is an effort to update DT for
upcoming TS language changes (see linked PR for details) and updating
this specifc DT package (@hapi/nes) to pass checks againsts current
status of TS language would prove fruitless. The upstream JS package
already progressed and DT types are out of sync with current module.
One could just revert this PR, in case of change to @hapi/nes types is
to be done in future.

Thank you for your understanding!
@DangerBotOSS
Copy link

DangerBotOSS commented Aug 20, 2023 •
edited
Loading

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

db.js (unpkg)

was missing the following properties:

  1. version

doctrine (unpkg)

was missing the following properties:

  1. Error

lokijs (unpkg)

was missing the following properties:

  1. deepFreeze
  2. freeze
  3. unFreeze
  4. Resultset
  5. Comparators

murmurhash3js (unpkg)

was missing the following properties:

  1. version

nes (unpkg)

was missing the following properties:

  1. plugin

node-hue-api (unpkg)

was missing the following properties:

  1. BridgeApi
  2. api
  3. connect
  4. scheduledEvent
  5. scene
as well as these 3 other properties...

timer, locateBridges, searchForBridges

precise (unpkg)

was missing the following properties:

  1. precise

revalidator (unpkg)

was missing the following properties:

  1. mixin

simple-url-cache (unpkg)

was missing the following properties:

  1. The declaration doesn't match the JavaScript module 'simple-url-cache'. Reason:
    The JavaScript module can be called or constructed, but the declaration module cannot.

The most common way to resolve this error is to use 'export =' syntax.
To learn more about 'export =' syntax, see https://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require.

  1. pool
  2. locks
  3. helpers
  4. StorageInstance
as well as these 1 other properties...

RedisPool

swiz (unpkg)

was missing the following properties:

  1. help
  2. check
  3. checkPartial

Generated by 🚫 dangerJS against df30a59

JoshuaKGoldberg
JoshuaKGoldberg commented Aug 20, 2023
View reviewed changes
README.md
## The history of Definitely Typed

Definitely Typed is one of the most active repositories on GitHub. You might have wondered how the project came to be. A history of Definitely Typed exists, that was put together by @johnnyreilly. It tells the story of the early days of Definitely Typed, from a repository created by @borisyankov, to the point where it became a pivotal part of the TypeScript ecosystem. [You can read the story of Definitely Typed here](https://johnnyreilly.com/definitely-typed-the-movie).
Definitely Typed is one of the most active repositories on GitHub. You might have wondered how the project came to be. A history of Definitely Typed exists, that was put together by @johnnyreilly. It tells the story of the early days of Definitely Typed, from a repository created by @borisyankov, to the point where it became a pivotal part of the TypeScript ecosystem. [You can read the story of Definitely Typed here](https://johnnyreilly.com/definitely-typed-the-movie).
Copy link
Collaborator Author

@JoshuaKGoldberg JoshuaKGoldberg Aug 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an intentional part of this PR, but I like the change. 😄

sandersn
sandersn reviewed Aug 23, 2023
View reviewed changes
.eslintrc.cjs Outdated
'ts-check': false,
}
],
'@typescript-eslint/prefer-namespace-keyword': 'error',
Copy link
Contributor

@sandersn sandersn Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change now needs to be made on the microsoft/definitelytyped-tools repo in the eslint-plugin package.

Copy link
Collaborator Author

@JoshuaKGoldberg JoshuaKGoldberg Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

microsoft/DefinitelyTyped-tools#716 👍

afharo pushed a commit to afharo/DefinitelyTyped that referenced this pull request Aug 24, 2023
@peterblazejewicz @afharo
remove(@hapi/nes): remove just sources of the package for DefinitelyT…
1e5d168 
…yped#66292 (DefinitelyTyped#66372)

This is technical removal. In DefinitelyTyped#66292 there is an effort to update DT for
upcoming TS language changes (see linked PR for details) and updating
this specifc DT package (@hapi/nes) to pass checks againsts current
status of TS language would prove fruitless. The upstream JS package
already progressed and DT types are out of sync with current module.
One could just revert this PR, in case of change to @hapi/nes types is
to be done in future.

Thank you for your understanding!
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Aug 24, 2023
Merged
@sandersn sandersn merged commit fbbc40d into DefinitelyTyped:master Aug 25, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the module-to-namespace branch August 25, 2023 17:39
@robpalme robpalme mentioned this pull request Oct 14, 2024
Closed
@DanielRosenwasser DanielRosenwasser mentioned this pull request Aug 5, 2025
Closed
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Aug 6, 2025
Closed
Copilot AI mentioned this pull request Sep 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandersn sandersn sandersn approved these changes

@peterblazejewicz peterblazejewicz peterblazejewicz approved these changes

@Rick-Kirkham Rick-Kirkham Rick-Kirkham approved these changes

@ElizabethSamuel-MSFT ElizabethSamuel-MSFT ElizabethSamuel-MSFT approved these changes

@borisyankov borisyankov Awaiting requested review from borisyankov borisyankov is a code owner

@horiuchi horiuchi Awaiting requested review from horiuchi horiuchi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JoshuaKGoldberg @DangerBotOSS @peterblazejewicz @sandersn @Rick-Kirkham @ElizabethSamuel-MSFT