Remove MongoDB - types supported as of 4.0.0#54510
Remove MongoDB - types supported as of 4.0.0#54510typescript-bot merged 5 commits intoDefinitelyTyped:masterfrom ImRodry:master
Conversation
|
@ImRodry Thank you for submitting this PR! This is a live comment which I will keep updated. This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this? 14 packages in this PR (and infra files)
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 54510,
"author": "ImRodry",
"headCommitOid": "54b3297f7581bf3eb0b689cd545607ecf82a012e",
"lastPushDate": "2021-07-26T16:37:45.000Z",
"lastActivityDate": "2021-07-26T20:08:17.000Z",
"mergeOfferDate": "2021-07-26T20:06:36.000Z",
"mergeRequestDate": "2021-07-26T20:08:17.000Z",
"mergeRequestUser": "ImRodry",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": null,
"kind": "edit",
"files": [
{
"path": "notNeededPackages.json",
"kind": "infrastructure"
},
{
"path": "package.json",
"kind": "infrastructure"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "acl",
"kind": "edit",
"files": [
{
"path": "types/acl/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"tkQubo"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "connect-mongodb-session",
"kind": "edit",
"files": [
{
"path": "types/connect-mongodb-session/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"NattapongSiri",
"HoldYourWaffle"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "express-brute-mongo",
"kind": "edit",
"files": [
{
"path": "types/express-brute-mongo/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/express-brute-mongo/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [
"cyrilschumacher"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "gridfs-stream",
"kind": "edit",
"files": [
{
"path": "types/gridfs-stream/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"liorm"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "koa-mongo",
"kind": "edit",
"files": [
{
"path": "types/koa-mongo/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"Shqrp"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "meteor",
"kind": "edit",
"files": [
{
"path": "types/meteor/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"barbatus",
"fullflavedave",
"orefalo",
"dagatsoin",
"ardatan",
"stefanholzapfel",
"andrei-markeev",
"lmachens",
"gunn",
"alesn",
"perbergland",
"nicu-chiciuc",
"ebroder",
"radekmie",
"wadamek65",
"MacRusher",
"ToastHawaii"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "migrate-mongo",
"kind": "edit",
"files": [
{
"path": "types/migrate-mongo/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"amitbeck"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "mongodb-queue",
"kind": "edit",
"files": [
{
"path": "types/mongodb-queue/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"FiveOFive",
"codejockie"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "mongodb",
"kind": "delete",
"files": [
{
"path": "types/mongodb/index.d.ts",
"kind": "definition"
},
{
"path": "types/mongodb/test/collection/aggregate.ts",
"kind": "test"
},
{
"path": "types/mongodb/test/collection/bulkWrite.ts",
"kind": "test"
},
{
"path": "types/mongodb/test/collection/count.ts",
"kind": "test"
},
{
"path": "types/mongodb/test/collection/distinct.ts",
"kind": "test"
},
{
"path": "types/mongodb/test/collection/filterQuery.ts",
"kind": "test"
},
{
"path": "types/mongodb/test/collection/findX.ts",
"kind": "test"
},
{
"path": "types/mongodb/test/collection/insertX.ts",
"kind": "test"
},
{
"path": "types/mongodb/test/collection/mapReduce.ts",
"kind": "test"
},
{
"path": "types/mongodb/test/collection/updateX.ts",
"kind": "test"
},
{
"path": "types/mongodb/test/createIndex.ts",
"kind": "test"
},
{
"path": "types/mongodb/test/cursor.ts",
"kind": "test"
},
{
"path": "types/mongodb/test/index.ts",
"kind": "test"
},
{
"path": "types/mongodb/test/stats.ts",
"kind": "test"
},
{
"path": "types/mongodb/test/transaction.ts",
"kind": "test"
},
{
"path": "types/mongodb/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/mongodb/tslint.json",
"kind": "package-meta-ok"
},
{
"path": "types/mongodb/v1/index.d.ts",
"kind": "definition"
},
{
"path": "types/mongodb/v1/mongodb-tests.ts",
"kind": "test"
},
{
"path": "types/mongodb/v1/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/mongodb/v1/tslint.json",
"kind": "package-meta-ok"
},
{
"path": "types/mongodb/v2/index.d.ts",
"kind": "definition"
},
{
"path": "types/mongodb/v2/mongodb-tests.ts",
"kind": "test"
},
{
"path": "types/mongodb/v2/tsconfig.json",
"kind": "package-meta-ok"
},
{
"path": "types/mongodb/v2/tslint.json",
"kind": "package-meta-ok"
}
],
"owners": [
"CaselIT",
"alanmarcell",
"dante-101",
"mcortesi",
"EnricoPicci",
"AJCStriker",
"julien-c",
"daprahamian",
"denys-bushulyak",
"b4nst",
"sindbach",
"geraldinelemeur",
"various89",
"angela-1",
"hector7",
"floric",
"erikc5000",
"Manc",
"jloveridge",
"ranguna",
"HosseinAgha",
"albertossilva",
"peterblazejewicz",
"LinusU",
"taxilian",
"xamgore",
"avaly",
"HitkoDev",
"Celend",
"jtassin",
"addaleax",
"emmanuelgautier",
"wyattjoh",
"borfig"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
},
{
"name": "mongorito",
"kind": "edit",
"files": [
{
"path": "types/mongorito/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"pinguet62"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "mongration",
"kind": "edit",
"files": [
{
"path": "types/mongration/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"soulthreads"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "multer-gridfs-storage",
"kind": "edit",
"files": [
{
"path": "types/multer-gridfs-storage/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"devconcept"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "node-mongodb-fixtures",
"kind": "edit",
"files": [
{
"path": "types/node-mongodb-fixtures/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"shian15810"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "umzug",
"kind": "edit",
"files": [
{
"path": "types/umzug/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"drinchev",
"mlamp",
"trodi",
"emmanuelgautier"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2021-07-26T20:05:45.000Z",
"isMaintainer": true
},
{
"type": "stale",
"reviewer": "CaselIT",
"date": "2021-07-14T09:53:57.000Z",
"abbrOid": "0386978"
}
],
"mainBotCommentID": 879723268,
"ciResult": "pass"
} |
|
🔔 @CaselIT @alanmarcell @Dante-101 @mcortesi @EnricoPicci @AJCStriker @julien-c @daprahamian @Denys-Bushulyak @b4nst @sindbach @geraldinelemeur @various89 @angela-1 @hector7 @floric @erikc5000 @Manc @jloveridge @Ranguna @HosseinAgha @albertossilva @peterblazejewicz @LinusU @taxilian @xamgore @avaly @HitkoDev @Celend @jtassin @addaleax @emmanuelgautier @wyattjoh @borfig — please review this PR in the next few days. Be sure to explicitly select |
|
@ImRodry The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
CaselIT
left a comment
There was a problem hiding this comment.
I think we should not remove them otherwise there is no way of supporting older versions. Not sure what happens in these cases. My guess is that current version needs to be moved in the v3 folder same as the v2 and v2
|
MongoDB themselves don't support older versions since April (v3.6 included) so there is no reason to keep this. I'm just going through the tedious process of updating every package to support the new types but these need to be removed imo |
|
Now we wait for microsoft/DefinitelyTyped-tools#290 to be merged |
|
you will probably need to request whitelisting |
People who would have been pingedtkQubo NattapongSiri HoldYourWaffle cyrilschumacher liorm Shqrp barbatus fullflavedave orefalo dagatsoin ardatan stefanholzapfel andrei-markeev lmachens gunn alesn perbergland nicu-chiciuc ebroder radekmie wadamek65 MacRusher ToastHawaii amitbeck FiveOFive codejockie CaselIT alanmarcell dante-101 mcortesi EnricoPicci AJCStriker julien-c daprahamian denys-bushulyak b4nst sindbach geraldinelemeur various89 angela-1 hector7 floric erikc5000 Manc jloveridge ranguna HosseinAgha albertossilva peterblazejewicz LinusU taxilian xamgore avaly HitkoDev Celend jtassin addaleax emmanuelgautier wyattjoh borfig pinguet62 soulthreads devconcept shian15810 drinchev mlamp trodi |
|
@ImRodry The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
are there any plans to add anything new into v3? Popular packages like |
it shouldn't be our problem if they decide not to update. The package will still be on npm as deprecated but no updates should be done from now on since the types are handled natively. |
|
One question though @peterblazejewicz why did you make the dependency |
It depends, some of those are older packages, those cannot be referencing v4, in that case |
none on my part. I don't really know what's the usual behavior in this case. |
I went through all issues and fixed them though, wouldn't that be ok too? |
|
Made a PR to add |
|
What's the process to submit changes to the typings now, and does MongoDB Inc. commit to maintain/review those updates? |
You can open PRs to change the source for https://github.com/mongodb/node-mongodb-native at that repository, if that affects the types, those will change along with it. You can also open a ticket at https://jira.mongodb.org/browse/NODE if there is an issue with those typings (or any other part of the package).
I can’t give an authoritative answer, but generally, the Node.js team at mongodb does review community-submitted PRs. |
|
@ImRodry The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@CaselIT Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
|
Ready to merge |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
|
I just published |
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If removing a declaration:
notNeededPackages.json.