Skip to content

Remove MongoDB - types supported as of 4.0.0#54510

Merged
typescript-bot merged 5 commits intoDefinitelyTyped:masterfrom
ImRodry:master
Jul 26, 2021
Merged

Remove MongoDB - types supported as of 4.0.0#54510
typescript-bot merged 5 commits intoDefinitelyTyped:masterfrom
ImRodry:master

Conversation

@ImRodry
Copy link
Contributor

@ImRodry ImRodry commented Jul 14, 2021

Please fill in this template.

Select one of these and delete the others:

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 14, 2021

@ImRodry Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

14 packages in this PR (and infra files)

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect DT infrastructure (notNeededPackages.json, package.json)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 54510,
  "author": "ImRodry",
  "headCommitOid": "54b3297f7581bf3eb0b689cd545607ecf82a012e",
  "lastPushDate": "2021-07-26T16:37:45.000Z",
  "lastActivityDate": "2021-07-26T20:08:17.000Z",
  "mergeOfferDate": "2021-07-26T20:06:36.000Z",
  "mergeRequestDate": "2021-07-26T20:08:17.000Z",
  "mergeRequestUser": "ImRodry",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        },
        {
          "path": "package.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "acl",
      "kind": "edit",
      "files": [
        {
          "path": "types/acl/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "tkQubo"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "connect-mongodb-session",
      "kind": "edit",
      "files": [
        {
          "path": "types/connect-mongodb-session/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "NattapongSiri",
        "HoldYourWaffle"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "express-brute-mongo",
      "kind": "edit",
      "files": [
        {
          "path": "types/express-brute-mongo/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/express-brute-mongo/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "cyrilschumacher"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "gridfs-stream",
      "kind": "edit",
      "files": [
        {
          "path": "types/gridfs-stream/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "liorm"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "koa-mongo",
      "kind": "edit",
      "files": [
        {
          "path": "types/koa-mongo/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Shqrp"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "meteor",
      "kind": "edit",
      "files": [
        {
          "path": "types/meteor/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "barbatus",
        "fullflavedave",
        "orefalo",
        "dagatsoin",
        "ardatan",
        "stefanholzapfel",
        "andrei-markeev",
        "lmachens",
        "gunn",
        "alesn",
        "perbergland",
        "nicu-chiciuc",
        "ebroder",
        "radekmie",
        "wadamek65",
        "MacRusher",
        "ToastHawaii"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "migrate-mongo",
      "kind": "edit",
      "files": [
        {
          "path": "types/migrate-mongo/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "amitbeck"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mongodb-queue",
      "kind": "edit",
      "files": [
        {
          "path": "types/mongodb-queue/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "FiveOFive",
        "codejockie"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mongodb",
      "kind": "delete",
      "files": [
        {
          "path": "types/mongodb/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/mongodb/test/collection/aggregate.ts",
          "kind": "test"
        },
        {
          "path": "types/mongodb/test/collection/bulkWrite.ts",
          "kind": "test"
        },
        {
          "path": "types/mongodb/test/collection/count.ts",
          "kind": "test"
        },
        {
          "path": "types/mongodb/test/collection/distinct.ts",
          "kind": "test"
        },
        {
          "path": "types/mongodb/test/collection/filterQuery.ts",
          "kind": "test"
        },
        {
          "path": "types/mongodb/test/collection/findX.ts",
          "kind": "test"
        },
        {
          "path": "types/mongodb/test/collection/insertX.ts",
          "kind": "test"
        },
        {
          "path": "types/mongodb/test/collection/mapReduce.ts",
          "kind": "test"
        },
        {
          "path": "types/mongodb/test/collection/updateX.ts",
          "kind": "test"
        },
        {
          "path": "types/mongodb/test/createIndex.ts",
          "kind": "test"
        },
        {
          "path": "types/mongodb/test/cursor.ts",
          "kind": "test"
        },
        {
          "path": "types/mongodb/test/index.ts",
          "kind": "test"
        },
        {
          "path": "types/mongodb/test/stats.ts",
          "kind": "test"
        },
        {
          "path": "types/mongodb/test/transaction.ts",
          "kind": "test"
        },
        {
          "path": "types/mongodb/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/mongodb/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/mongodb/v1/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/mongodb/v1/mongodb-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/mongodb/v1/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/mongodb/v1/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/mongodb/v2/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/mongodb/v2/mongodb-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/mongodb/v2/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/mongodb/v2/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "CaselIT",
        "alanmarcell",
        "dante-101",
        "mcortesi",
        "EnricoPicci",
        "AJCStriker",
        "julien-c",
        "daprahamian",
        "denys-bushulyak",
        "b4nst",
        "sindbach",
        "geraldinelemeur",
        "various89",
        "angela-1",
        "hector7",
        "floric",
        "erikc5000",
        "Manc",
        "jloveridge",
        "ranguna",
        "HosseinAgha",
        "albertossilva",
        "peterblazejewicz",
        "LinusU",
        "taxilian",
        "xamgore",
        "avaly",
        "HitkoDev",
        "Celend",
        "jtassin",
        "addaleax",
        "emmanuelgautier",
        "wyattjoh",
        "borfig"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "mongorito",
      "kind": "edit",
      "files": [
        {
          "path": "types/mongorito/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "pinguet62"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mongration",
      "kind": "edit",
      "files": [
        {
          "path": "types/mongration/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "soulthreads"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "multer-gridfs-storage",
      "kind": "edit",
      "files": [
        {
          "path": "types/multer-gridfs-storage/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "devconcept"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "node-mongodb-fixtures",
      "kind": "edit",
      "files": [
        {
          "path": "types/node-mongodb-fixtures/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "shian15810"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "umzug",
      "kind": "edit",
      "files": [
        {
          "path": "types/umzug/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "drinchev",
        "mlamp",
        "trodi",
        "emmanuelgautier"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2021-07-26T20:05:45.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "CaselIT",
      "date": "2021-07-14T09:53:57.000Z",
      "abbrOid": "0386978"
    }
  ],
  "mainBotCommentID": 879723268,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Jul 14, 2021
@typescript-bot
Copy link
Contributor

@ImRodry The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@ImRodry ImRodry marked this pull request as draft July 14, 2021 09:46
Copy link
Contributor

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not remove them otherwise there is no way of supporting older versions. Not sure what happens in these cases. My guess is that current version needs to be moved in the v3 folder same as the v2 and v2

@ImRodry
Copy link
Contributor Author

ImRodry commented Jul 14, 2021

MongoDB themselves don't support older versions since April (v3.6 included) so there is no reason to keep this. I'm just going through the tedious process of updating every package to support the new types but these need to be removed imo

@ImRodry
Copy link
Contributor Author

ImRodry commented Jul 14, 2021

Now we wait for microsoft/DefinitelyTyped-tools#290 to be merged

@ImRodry ImRodry marked this pull request as ready for review July 14, 2021 17:34
@peterblazejewicz
Copy link
Member

peterblazejewicz commented Jul 14, 2021

you will probably need to request whitelisting @types/mongodb, so you could reference a @types/mongodb as a dependnecy, not mongodb in v4.*. Some packages are depending on older versions, say:
https://github.com/OptimalBits/node_acl/blob/master/package.json#L21

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 14, 2021

⚠️ There are too many reviewers for this PR change (67). Merging can only be handled by a DT maintainer.

People who would have been pinged tkQubo NattapongSiri HoldYourWaffle cyrilschumacher liorm Shqrp barbatus fullflavedave orefalo dagatsoin ardatan stefanholzapfel andrei-markeev lmachens gunn alesn perbergland nicu-chiciuc ebroder radekmie wadamek65 MacRusher ToastHawaii amitbeck FiveOFive codejockie CaselIT alanmarcell dante-101 mcortesi EnricoPicci AJCStriker julien-c daprahamian denys-bushulyak b4nst sindbach geraldinelemeur various89 angela-1 hector7 floric erikc5000 Manc jloveridge ranguna HosseinAgha albertossilva peterblazejewicz LinusU taxilian xamgore avaly HitkoDev Celend jtassin addaleax emmanuelgautier wyattjoh borfig pinguet62 soulthreads devconcept shian15810 drinchev mlamp trodi

@typescript-bot
Copy link
Contributor

@ImRodry The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@peterblazejewicz
Copy link
Member

My guess is that current version needs to be moved in the v3 folder same as the v2 and v2

are there any plans to add anything new into v3? Popular packages like mongodb are hard to properly or nicely phaseout in some scenarios. The best would be kept v4 native and remove surces from DT for anything older (so v3 and older). Types for v3 are already published to NPM, there is no scenario those will be removed, only souce from here.
I've done updating mongoose, you folks can use that as sample scenario that can be applied here:
#53417

@ImRodry
Copy link
Contributor Author

ImRodry commented Jul 14, 2021

you will probably need to request whitelisting @types/mongodb, so you could reference a @types/mongodb as a dependnecy, not mongodb in v4.*. Some packages are depending on older versions, say:
https://github.com/OptimalBits/node_acl/blob/master/package.json#L21

it shouldn't be our problem if they decide not to update. The package will still be on npm as deprecated but no updates should be done from now on since the types are handled natively.

@ImRodry
Copy link
Contributor Author

ImRodry commented Jul 14, 2021

One question though @peterblazejewicz why did you make the dependency @types/mongoose and not just mongoose?

@peterblazejewicz
Copy link
Member

One question though @peterblazejewicz why did you make the dependency @types/mongoose and not just mongoose?

It depends, some of those are older packages, those cannot be referencing v4, in that case @types/mongoose and recent published version. Evything that works with v4, should us that version directly, I agree.

@CaselIT
Copy link
Contributor

CaselIT commented Jul 14, 2021

are there any plans to add anything new into v3?

none on my part. I don't really know what's the usual behavior in this case.
I just think that this is similar to what happens when when a library changes major version, where the current types go in a vX subfolder and the new ones start in the main fonder. The only difference in this case is that no new types are added in the main folder.

@ImRodry
Copy link
Contributor Author

ImRodry commented Jul 14, 2021

One question though @peterblazejewicz why did you make the dependency @types/mongoose and not just mongoose?

It depends, some of those are older packages, those cannot be referencing v4, in that case @types/mongoose and recent published version. Evything that works with v4, should us that version directly, I agree.

I went through all issues and fixed them though, wouldn't that be ok too?

@ImRodry
Copy link
Contributor Author

ImRodry commented Jul 15, 2021

Made a PR to add @types/mongodb as an allowed dependency. Once that is merged, I'll update the PR without changing all of these packages and updating them properly

@julien-c
Copy link
Contributor

What's the process to submit changes to the typings now, and does MongoDB Inc. commit to maintain/review those updates?

@addaleax
Copy link
Contributor

What's the process to submit changes to the typings now

You can open PRs to change the source for https://github.com/mongodb/node-mongodb-native at that repository, if that affects the types, those will change along with it. You can also open a ticket at https://jira.mongodb.org/browse/NODE if there is an issue with those typings (or any other part of the package).

and does MongoDB Inc. commit to maintain/review those updates?

I can’t give an authoritative answer, but generally, the Node.js team at mongodb does review community-submitted PRs.

@typescript-bot typescript-bot added The CI failed When GH Actions fails and removed The CI failed When GH Actions fails labels Jul 26, 2021
@typescript-bot
Copy link
Contributor

@ImRodry The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Jul 26, 2021
@typescript-bot
Copy link
Contributor

@CaselIT Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

Copy link
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jul 26, 2021
@typescript-bot
Copy link
Contributor

@ImRodry: Everything looks good here. I am ready to merge this PR (at 54b3297) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@ImRodry
Copy link
Contributor Author

ImRodry commented Jul 26, 2021

Ready to merge

@typescript-bot typescript-bot merged commit dbc8fac into DefinitelyTyped:master Jul 26, 2021
@typescript-bot
Copy link
Contributor

I just published @types/acl@0.4.39 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/connect-mongodb-session@2.4.2 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/express-brute-mongo@0.0.36 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/gridfs-stream@0.5.35 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/koa-mongo@1.9.2 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/meteor@1.4.75 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/migrate-mongo@8.1.2 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/mongodb-queue@4.0.6 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/mongorito@3.0.6 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/mongration@1.0.5 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/multer-gridfs-storage@4.0.4 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/node-mongodb-fixtures@3.2.2 to npm.

@typescript-bot
Copy link
Contributor

I just published @types/umzug@2.3.2 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants