fix(mongoose): remove DT by peterblazejewicz · Pull Request #53417 · DefinitelyTyped/DefinitelyTyped

peterblazejewicz · 2021-05-26T19:13:48Z

5.11.0 introduced types:

https://github.com/Automattic/mongoose/tree/5.11.0
https://thecodebarbarian.com/working-with-mongoose-in-typescript.html

Thanks!

/cc @jamiehaywood

Fixes #53407

Note: this is not expected to merge easily due to wide usage of @types/mongoose, new version introudction
with .d.ts distributed natively, etc.

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Run npm test <package to test>.
Delete the package's directory.
Add it to notNeededPackages.json.

typescript-bot · 2021-05-26T19:14:27Z

@peterblazejewicz Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

18 packages in this PR (and infra files)

forest-express-mongoose — on npm, on unpkg
joigoose — on npm, on unpkg
koa2-ratelimit — on npm, on unpkg
mongoose-auto-increment — on npm, on unpkg
mongoose-autopopulate — on npm, on unpkg
mongoose-deep-populate — on npm, on unpkg
mongoose-delete — on npm, on unpkg
mongoose-geojson-schema — on npm, on unpkg
mongoose-id-validator — on npm, on unpkg
mongoose-lean-virtuals — on npm, on unpkg
mongoose-mock — on npm, on unpkg
mongoose-paginate-v2 — on npm, on unpkg
mongoose-promise — on npm, on unpkg
mongoose-simple-random — on npm, on unpkg
mongoose-unique-validator — on npm, on unpkg
mongoose (probably deleted!) — on npm, on unpkg
multer-gridfs-storage — on npm, on unpkg
resourcejs — on npm, on unpkg
Infra files
- notNeededPackages.json

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes in this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
✅ A DT maintainer needs to approve changes which affect DT infrastructure (notNeededPackages.json)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 53417,
  "author": "peterblazejewicz",
  "headCommitOid": "4c81e341994ab625041cfd4076c9050785f56dcf",
  "lastPushDate": "2021-05-28T20:24:44.000Z",
  "lastActivityDate": "2021-06-01T19:55:44.000Z",
  "mergeOfferDate": "2021-06-01T19:46:48.000Z",
  "mergeRequestDate": "2021-06-01T19:55:44.000Z",
  "mergeRequestUser": "peterblazejewicz",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "forest-express-mongoose",
      "kind": "edit",
      "files": [
        {
          "path": "types/forest-express-mongoose/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "SteveBunlon",
        "ghusse"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "joigoose",
      "kind": "edit",
      "files": [
        {
          "path": "types/joigoose/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "boothwhack"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "koa2-ratelimit",
      "kind": "edit",
      "files": [
        {
          "path": "types/koa2-ratelimit/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "Ovyerus"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "mongoose-auto-increment",
      "kind": "edit",
      "files": [
        {
          "path": "types/mongoose-auto-increment/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "AyaMorisawa"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mongoose-autopopulate",
      "kind": "edit",
      "files": [
        {
          "path": "types/mongoose-autopopulate/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "rann91"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mongoose-deep-populate",
      "kind": "edit",
      "files": [
        {
          "path": "types/mongoose-deep-populate/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/mongoose-deep-populate/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "AyaMorisawa"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mongoose-delete",
      "kind": "edit",
      "files": [
        {
          "path": "types/mongoose-delete/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "ndunks"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mongoose-geojson-schema",
      "kind": "edit",
      "files": [
        {
          "path": "types/mongoose-geojson-schema/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "bondz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mongoose-id-validator",
      "kind": "edit",
      "files": [
        {
          "path": "types/mongoose-id-validator/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "kerolloz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mongoose-lean-virtuals",
      "kind": "edit",
      "files": [
        {
          "path": "types/mongoose-lean-virtuals/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "isaacdecoded"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mongoose-mock",
      "kind": "edit",
      "files": [
        {
          "path": "types/mongoose-mock/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "jt000"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mongoose-paginate-v2",
      "kind": "edit",
      "files": [
        {
          "path": "types/mongoose-paginate-v2/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "linusbrolin",
        "simonxca",
        "woutgg",
        "oktapodia",
        "ChazEpps",
        "gamsterx"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mongoose-promise",
      "kind": "edit",
      "files": [
        {
          "path": "types/mongoose-promise/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "simonxca"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mongoose-simple-random",
      "kind": "edit",
      "files": [
        {
          "path": "types/mongoose-simple-random/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "typescript-bot"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mongoose-unique-validator",
      "kind": "edit",
      "files": [
        {
          "path": "types/mongoose-unique-validator/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "stevehipwell"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "mongoose",
      "kind": "delete",
      "files": [
        {
          "path": "types/mongoose/README.md",
          "kind": "markdown"
        },
        {
          "path": "types/mongoose/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/mongoose/test/definitions.ts",
          "kind": "test"
        },
        {
          "path": "types/mongoose/test/document.ts",
          "kind": "test"
        },
        {
          "path": "types/mongoose/test/model.ts",
          "kind": "test"
        },
        {
          "path": "types/mongoose/test/mongoose.ts",
          "kind": "test"
        },
        {
          "path": "types/mongoose/test/query.ts",
          "kind": "test"
        },
        {
          "path": "types/mongoose/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/mongoose/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/mongoose/v3/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/mongoose/v3/mongoose-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/mongoose/v3/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/mongoose/v3/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/mongoose/v4/README.md",
          "kind": "markdown"
        },
        {
          "path": "types/mongoose/v4/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/mongoose/v4/mongoose-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/mongoose/v4/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/mongoose/v4/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "horiuchi",
        "lukasz-zak",
        "jendrikw",
        "ethanresnick",
        "vologab",
        "jussikinnula",
        "ondratra",
        "alfirin",
        "idandrd",
        "various89",
        "Fazendaaa",
        "NormanPerrin",
        "stablio",
        "emmanuelgautier",
        "frontendmonster",
        "mingchen",
        "penumbra1",
        "HughKu",
        "niuware",
        "vladmel1234",
        "jloveridge",
        "grimmer0125",
        "richarddd",
        "ToucheSir",
        "borfig",
        "dinodeSimon",
        "anthony-kenikh",
        "iamchathu",
        "lkho",
        "tomyam1",
        "nephix",
        "rlaace423",
        "ChazEpps",
        "JanNemcik",
        "cl3dson",
        "richardsimko",
        "ith",
        "jeremyben",
        "andreialecu",
        "tHBp",
        "1pete",
        "guillem-gelabert"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    },
    {
      "name": "multer-gridfs-storage",
      "kind": "edit",
      "files": [
        {
          "path": "types/multer-gridfs-storage/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/multer-gridfs-storage/v3/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "devconcept"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "resourcejs",
      "kind": "edit",
      "files": [
        {
          "path": "types/resourcejs/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "shaunluttin"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "RyanCavanaugh",
      "date": "2021-06-01T19:45:49.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "jamiehaywood",
      "date": "2021-05-28T20:58:13.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 849050262,
  "ciResult": "pass"
}

typescript-bot · 2021-05-26T19:14:27Z

🔔 @horiuchi @lukasz-zak @jendrikw @ethanresnick @vologab @jussikinnula @ondratra @alfirin @idandrd @various89 @Fazendaaa @NormanPerrin @stablio @emmanuelgautier @frontendmonster @mingchen @penumbra1 @HughKu @niuware @Vladmel1234 @jloveridge @grimmer0125 @richarddd @ToucheSir @borfig @dinodeSimon @anthony-kenikh @iamchathu @lkho @tomyam1 @nephix @rlaace423 @chazepps @JanNemcik @cl3dson @richardsimko @ith @jeremyben @andreialecu @tHBp @1pete @guillem-gelabert — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

peterblazejewicz · 2021-05-26T19:18:00Z

all: to be done sequentally, this shoudl be merged as last one, after fixing deps and pre 5.10 version, thx!

typescript-bot · 2021-05-26T19:18:34Z

@peterblazejewicz The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Mongoose ships its own types starting 5.11 At the same time, there is a dozen or more packages on DT that would require minor changes to adapt to that change, either by fixing to already published @types/mongoose or using new native package reference Ref: DefinitelyTyped/DefinitelyTyped#53417 Thanks!

peterblazejewicz · 2021-05-26T21:07:19Z

done: @types/mongoose and mongoose will be now allowed to use in order to fix dependencies matrix, thx! TBC

jamiehaywood · 2021-05-27T08:03:36Z

@peterblazejewicz - awesome job, thanks very much for raising this PR! Having looked through your code I realise I probably could have done it 😅🤦🏻‍♂️ but I've learnt something new 🙂. Have a great week!

'mongoose' is to be removed from DT as part of DefinitelyTyped#53417 This change set fixed @types/mongoose version for this package. Thanks!

@peterblazejewicz

…se` dependency by @peterblazejewicz 'mongoose' is to be removed from DT as part of #53417 This change set fixed @types/mongoose version for this package. Thanks!

5.11.0 introduced types: https://github.com/Automattic/mongoose/tree/5.11.0 https://thecodebarbarian.com/working-with-mongoose-in-typescript.html Thanks!

'mongoose' is to be removed from DT as part of DefinitelyTyped#53417 This change set fixed @types/mongoose version for this package. Thanks!

typescript-bot · 2021-06-01T19:46:48Z

@peterblazejewicz Everything looks good here. Great job! I am ready to merge this PR (at 4c81e34) on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

peterblazejewicz · 2021-06-01T19:55:44Z

Ready to merge 💘

typescript-bot · 2021-06-01T20:34:39Z

I just published @types/forest-express-mongoose@7.5.1 to npm.

typescript-bot · 2021-06-01T20:35:16Z

I just published @types/joigoose@2.0.6 to npm.

typescript-bot · 2021-06-01T20:35:50Z

I just published @types/koa2-ratelimit@0.9.1 to npm.

typescript-bot · 2021-06-01T20:36:16Z

I just published @types/mongoose-auto-increment@5.0.34 to npm.

typescript-bot · 2021-06-01T20:36:28Z

I just published @types/mongoose-autopopulate@0.10.2 to npm.

typescript-bot · 2021-06-01T20:36:39Z

I just published @types/mongoose-deep-populate@2.0.36 to npm.

typescript-bot · 2021-06-01T20:36:53Z

I just published @types/mongoose-delete@0.5.3 to npm.

typescript-bot · 2021-06-01T20:37:07Z

I just published @types/mongoose-geojson-schema@2.1.5 to npm.

typescript-bot · 2021-06-01T20:37:19Z

I just published @types/mongoose-id-validator@0.6.1 to npm.

typescript-bot · 2021-06-01T20:37:31Z

I just published @types/mongoose-lean-virtuals@0.5.2 to npm.

typescript-bot · 2021-06-01T20:37:43Z

I just published @types/mongoose-mock@0.4.34 to npm.

typescript-bot · 2021-06-01T20:37:56Z

I just published @types/mongoose-paginate-v2@1.3.10 to npm.

typescript-bot · 2021-06-01T20:38:09Z

I just published @types/mongoose-promise@4.5.11 to npm.

typescript-bot · 2021-06-01T20:38:22Z

I just published @types/mongoose-simple-random@0.4.9 to npm.

typescript-bot · 2021-06-01T20:38:36Z

I just published @types/mongoose-unique-validator@1.0.5 to npm.

typescript-bot · 2021-06-01T20:38:48Z

I just published @types/multer-gridfs-storage@4.0.2 to npm.

typescript-bot · 2021-06-01T20:38:55Z

I just published @types/multer-gridfs-storage@3.1.6 to npm.

typescript-bot · 2021-06-01T20:39:07Z

I just published @types/resourcejs@1.9.5 to npm.

peterblazejewicz requested a review from horiuchi as a code owner May 26, 2021 19:13

typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Edits Infrastructure labels May 26, 2021

typescript-bot added the The CI failed When GH Actions fails label May 26, 2021

peterblazejewicz mentioned this pull request May 26, 2021

add: mongoose microsoft/DefinitelyTyped-tools#264

Merged

jamiehaywood approved these changes May 27, 2021

View reviewed changes

typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label May 27, 2021

peterblazejewicz mentioned this pull request May 27, 2021

update(forest-express-mongoose): update mongoose dependency #53451

Closed

3 tasks

peterblazejewicz mentioned this pull request May 27, 2021

update(mongoose-deep-populate): fix mongoose dependency version #53454

Closed

3 tasks

peterblazejewicz mentioned this pull request May 27, 2021

update(mongoose-auto-increment): fix mongoose dependency #53455

Closed

3 tasks

peterblazejewicz marked this pull request as draft May 27, 2021 21:52

This was referenced May 27, 2021

update(joigoose): fix mongoose dependency version #53457

Closed

update(mongoose-aggregate-paginate-v2): fix mongoose dependency #53458

Merged

peterblazejewicz added 2 commits May 28, 2021 20:19

remove(mongoose): remove DT

22d0e0a

5.11.0 introduced types: https://github.com/Automattic/mongoose/tree/5.11.0 https://thecodebarbarian.com/working-with-mongoose-in-typescript.html Thanks!

forest-express-mongoose

bdd5311

typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label May 28, 2021

RyanCavanaugh approved these changes Jun 1, 2021

View reviewed changes

typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jun 1, 2021

typescript-bot merged commit d2af2cc into DefinitelyTyped:master Jun 1, 2021

peterblazejewicz deleted the fix/53407 branch June 1, 2021 19:57

sandersn mentioned this pull request Jun 3, 2021

Fix missed mongoose dependents #53580

Merged

peterblazejewicz mentioned this pull request Jul 14, 2021

Remove MongoDB - types supported as of 4.0.0 #54510

Merged

9 tasks

ImRodry mentioned this pull request Sep 1, 2021

Remove node-fetch - not needed as of 3.0.0 #55533

Merged

9 tasks

jakebailey mentioned this pull request Oct 10, 2023

[mongoose] type definitions are not needed since 5.11.0 #49893

Closed

9 tasks

Conversation

peterblazejewicz commented May 26, 2021

Uh oh!

typescript-bot commented May 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

18 packages in this PR (and infra files)

Code Reviews

Status

Uh oh!

typescript-bot commented May 26, 2021

Uh oh!

peterblazejewicz commented May 26, 2021

Uh oh!

typescript-bot commented May 26, 2021

Uh oh!

peterblazejewicz commented May 26, 2021

Uh oh!

jamiehaywood commented May 27, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

peterblazejewicz commented Jun 1, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

typescript-bot commented Jun 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

typescript-bot commented May 26, 2021 •

edited

Loading