update(mongoose-aggregate-paginate-v2): fix mongoose dependency#53458
Conversation
'mongoose' is to be removed from DT as part of DefinitelyTyped#53417 This change set fixed @types/mongoose version for this package. Thanks!
|
@peterblazejewicz Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it. You can test the changes in this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 53458,
"author": "peterblazejewicz",
"headCommitOid": "4ac397c96baa8c862f092aaf76ff2b54be82c7db",
"lastPushDate": "2021-05-27T22:00:13.000Z",
"lastActivityDate": "2021-05-28T00:48:15.000Z",
"mergeOfferDate": "2021-05-28T00:47:34.000Z",
"mergeRequestDate": "2021-05-28T00:48:15.000Z",
"mergeRequestUser": "acrilex1",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "mongoose-aggregate-paginate-v2",
"kind": "edit",
"files": [
{
"path": "types/mongoose-aggregate-paginate-v2/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"acrilex1"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "acrilex1",
"date": "2021-05-28T00:47:00.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 849971184,
"ciResult": "pass"
} |
|
🔔 @acrilex1 — please review this PR in the next few days. Be sure to explicitly select |
|
@peterblazejewicz Everything looks good here. Great job! I am ready to merge this PR (at 4ac397c) on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@acrilex1: you can do this too.) |
|
Ready to merge |
|
I just published |
'mongoose' is to be removed from DT as part of #53417
This change set fixed @types/mongoose version for this package.
Thanks!
npm test <package to test>.