Revert "refactor(node): Move Buffer definition to buffer.d.ts (#4…#45956
Revert "refactor(node): Move Buffer definition to buffer.d.ts (#4…#45956
Buffer definition to buffer.d.ts (#4…#45956Conversation
|
@sandersn Thank you for submitting this PR! This is a live comment which I will keep updated. This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you. Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 45956,
"author": "sandersn",
"owners": [
"Microsoft",
"DefinitelyTyped",
"jkomyno",
"a-tarasyuk",
"alvis",
"r3nya",
"btoueg",
"brunoscheufler",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Flarna",
"Hannes-Magnusson-CK",
"KSXGitHub",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"n-e",
"octo-sniffle",
"galkin",
"parambirs",
"eps1lon",
"SimonSchick",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"j-oliveras",
"bhongy",
"chyzwar",
"trivikr",
"nguymin4",
"yoursunny",
"qwelias",
"ExE-Boss",
"Ryan-Willpower",
"peterblazejewicz",
"addaleax",
"JasonHK"
],
"dangerLevel": "ScopedAndUntested",
"headCommitAbbrOid": "d2bc71e",
"headCommitOid": "d2bc71e2af136143f68b52e44fbd6367b790a511",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastCommitDate": "2020-07-08T17:14:17.000Z",
"lastCommentDate": "2020-07-08T17:41:38.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45956/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Critical",
"anyPackageIsNew": false,
"packages": [
"node"
],
"files": [
{
"filePath": "types/node/buffer.d.ts",
"kind": "definition",
"package": "node"
},
{
"filePath": "types/node/globals.d.ts",
"kind": "definition",
"package": "node"
},
{
"filePath": "types/node/ts3.2/base.d.ts",
"kind": "definition",
"package": "node"
},
{
"filePath": "types/node/ts3.2/buffer.d.ts",
"kind": "definition",
"package": "node"
},
{
"filePath": "types/node/ts3.2/globals.d.ts",
"kind": "definition",
"package": "node"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"reviewersWithStaleReviews": [],
"approvalFlags": 0,
"isChangesRequested": false
} |
|
🔔 @microsoft @DefinitelyTyped @jkomyno @a-tarasyuk @alvis @r3nya @btoueg @BrunoScheufler @smac89 @Touffy @DeividasBakanas @eyqs @Flarna @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @octo-sniffle @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @j-oliveras @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @ExE-Boss @Ryan-Willpower @peterblazejewicz @addaleax @JasonHK - please review this PR in the next few days. Be sure to explicitly select |
|
@sandersn The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
|
There should be no difference between the two I would think. |
|
There are some rules around exporting single identifiers that I don't understand. @weswigham suggested a workaround, but found that it didn't work because of a compiler bug. I posted more details on the original PR. |
|
You could’ve just reverted the removal of |
|
I just published |
…finitelyTyped#4… (DefinitelyTyped#45956) * Revert "refactor(node): Move `Buffer` definition to `buffer.d.ts` (DefinitelyTyped#45845)" This reverts commit a58ce42. * put back reference to globals.d.ts in ts3.2
…finitelyTyped#4… (DefinitelyTyped#45956) * Revert "refactor(node): Move `Buffer` definition to `buffer.d.ts` (DefinitelyTyped#45845)" This reverts commit a58ce42. * put back reference to globals.d.ts in ts3.2
…5845)"
This reverts commit a58ce42.
The original PR breaks pouchdb-core and its dependents, but the CI tests mistakenly did not include those packages in the test set.