refactor(node): Move Buffer definition to buffer.d.ts#45845
refactor(node): Move Buffer definition to buffer.d.ts#45845weswigham merged 1 commit intoDefinitelyTyped:masterfrom
Buffer definition to buffer.d.ts#45845Conversation
|
@ExE-Boss Thank you for submitting this PR! This is a live comment which I will keep updated. This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you. Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 45845,
"author": "ExE-Boss",
"owners": [
"Microsoft",
"DefinitelyTyped",
"jkomyno",
"a-tarasyuk",
"alvis",
"r3nya",
"btoueg",
"brunoscheufler",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Flarna",
"Hannes-Magnusson-CK",
"KSXGitHub",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"n-e",
"octo-sniffle",
"galkin",
"parambirs",
"eps1lon",
"SimonSchick",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"j-oliveras",
"bhongy",
"chyzwar",
"trivikr",
"nguymin4",
"yoursunny",
"qwelias",
"ExE-Boss",
"Ryan-Willpower",
"peterblazejewicz",
"addaleax",
"JasonHK"
],
"dangerLevel": "ScopedAndUntested",
"headCommitAbbrOid": "5e1cafd",
"headCommitOid": "5e1cafd86505aa420ee2eaaaa8e75e25fac80592",
"mergeIsRequested": false,
"stalenessInDays": 3,
"lastCommitDate": "2020-07-02T15:12:04.000Z",
"lastCommentDate": "2020-07-02T15:12:04.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45845/files",
"hasMergeConflict": false,
"authorIsOwner": true,
"isFirstContribution": false,
"popularityLevel": "Critical",
"anyPackageIsNew": false,
"packages": [
"node"
],
"files": [
{
"filePath": "types/node/buffer.d.ts",
"kind": "definition",
"package": "node"
},
{
"filePath": "types/node/globals.d.ts",
"kind": "definition",
"package": "node"
},
{
"filePath": "types/node/ts3.2/base.d.ts",
"kind": "definition",
"package": "node"
},
{
"filePath": "types/node/ts3.2/buffer.d.ts",
"kind": "definition",
"package": "node"
},
{
"filePath": "types/node/ts3.2/globals.d.ts",
"kind": "definition",
"package": "node"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"reviewersWithStaleReviews": [],
"approvalFlags": 0,
"isChangesRequested": false
} |
|
🔔 @microsoft @DefinitelyTyped @jkomyno @a-tarasyuk @alvis @r3nya @btoueg @BrunoScheufler @smac89 @Touffy @DeividasBakanas @eyqs @Flarna @Hannes-Magnusson-CK @KSXGitHub @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @octo-sniffle @galkin @parambirs @eps1lon @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @j-oliveras @bhongy @chyzwar @trivikr @nguymin4 @yoursunny @qwelias @Ryan-Willpower @peterblazejewicz @addaleax @JasonHK - please review this PR in the next few days. Be sure to explicitly select |
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
|
I just published |
…finitelyTyped#45845)" This reverts commit a58ce42.
…finitelyTyped#45845)" This reverts commit a58ce42.
…finitelyTyped#45845)" This reverts commit a58ce42.
|
This breaks pouchdb-core and its dependents, which weren't tested due to a bug in DefinitelyTyped-tools. I'm going to revert this for now. |
|
Looks like a workaround that should work, doesn't because of a bug in the compiler: microsoft/TypeScript#39504 Change import B = globalThis.buffer
export { B as Buffer } |
…finitelyTyped#4… (DefinitelyTyped#45956) * Revert "refactor(node): Move `Buffer` definition to `buffer.d.ts` (DefinitelyTyped#45845)" This reverts commit a58ce42. * put back reference to globals.d.ts in ts3.2
…finitelyTyped#4… (DefinitelyTyped#45956) * Revert "refactor(node): Move `Buffer` definition to `buffer.d.ts` (DefinitelyTyped#45845)" This reverts commit a58ce42. * put back reference to globals.d.ts in ts3.2
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]and not for whole package so that the need for disabling can be reviewed.