Skip to content

Deprecate whatwg-streams in favor for DOM types #38785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RyanCavanaugh merged 1 commit into from
Oct 3, 2019
Merged

Deprecate whatwg-streams in favor for DOM types #38785

RyanCavanaugh merged 1 commit into from
Oct 3, 2019

Conversation

@MattiasBuelens
Copy link
Contributor

@MattiasBuelens MattiasBuelens commented Oct 1, 2019

TypeScript 3.2 shipped with built-in type definitions for streams (see microsoft/TypeScript-DOM-lib-generator#541 and microsoft/TypeScript#28343), so this types package is no longer needed.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@MattiasBuelens
Deprecate whatwg-streams in favor for DOM types
b7b3bdd 
TypeScript 3.2 shipped with built-in type definitions for streams,
so this types package is no longer needed.
MattiasBuelens
MattiasBuelens commented Oct 1, 2019
View reviewed changes
notNeededPackages.json
"libraryName": "typescript",
"typingsPackageName": "whatwg-streams",
"sourceRepoURL": "https://streams.spec.whatwg.org",
"asOfVersion": "3.2.1"
Copy link
Contributor Author

@MattiasBuelens MattiasBuelens Oct 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that in other PRs that removed types for DOM APIs (e.g. #34641), the asOfVersion field is always set to 2.0.0. I'm not sure if there's a special reason for this?

I've put in the TypeScript version in which streams were added to the DOM types. If that's not how this field works, let me know. 🙂

@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 1, 2019 •
edited
Loading

@MattiasBuelens Thank you for submitting this PR!

🔔 @saschanaz @ksm2 - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added Author is Owner The author of this PR is a listed owner of the package. Merge:Express labels Oct 1, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Oct 1, 2019 •
edited
Loading

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. and removed Awaiting reviewer feedback labels Oct 2, 2019
@RyanCavanaugh RyanCavanaugh merged commit 20f812d into DefinitelyTyped:master Oct 3, 2019
@MattiasBuelens MattiasBuelens deleted the deprecate-whatwg-streams branch October 3, 2019 23:26
@MattiasBuelens MattiasBuelens mentioned this pull request Jul 27, 2020
Closed
@MattiasBuelens MattiasBuelens mentioned this pull request Jun 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@saschanaz saschanaz saschanaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MattiasBuelens @typescript-bot @saschanaz @RyanCavanaugh