Lib update Nov 2018 #28343
Merged
Lib update Nov 2018 #28343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mappedTypeRecursiveInference uses the DOM to ensure it operates on a big-enough type to be a valid test.
|
@sandersn Hey, sorry for hijacking this PR, but I just wanted to ask few things. How often are libs updated? Every major, minor release? Also, is this update final before 3.2? |
Member
Author
|
@FrogTheFrog No problem. I don't know if this is written down somewhere already, but I intend to ship DOM updates once per bi-monthly release [1] -- that is, once in 3.1, once in 3.2, once in 3.3, .... This is the final update for 3.2. I'll probably bring the changes over 2-3 times per release into [1] I don't really know what the term should be since we don't follow semver but do have a regular release cycle. |
|
@sandersn I see. Thanks for the info! |
9 tasks
LinusU
added a commit
to LinusU/aws-sdk-js-v3
that referenced
this pull request
Oct 9, 2024
This was added to the upstream dom typings in the Nov 2018 update. ref: microsoft/TypeScript@b830ef8 microsoft/TypeScript#28343 microsoft/TypeScript-DOM-lib-generator#541
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy over the DOM changes from TSJS-lib-generator.
Note that one test changes because it uses DOM types in order to have access to a large tree of types. The test makes sure that the compiler doesn't crash when mapping over very large, wide types.
@DanielRosenwasser let's discuss scheduling for when to merge this PR.