Skip to content

Deprecate whatwg-streams in favor for DOM types #38785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanCavanaugh merged 1 commit into from
Oct 3, 2019
Merged

Deprecate whatwg-streams in favor for DOM types #38785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions notNeededPackages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3906,6 +3906,12 @@
"sourceRepoURL": "https://github.com/neutrinojs/webpack-chain",
"asOfVersion": "5.2.0"
},
{
"libraryName": "typescript",
"typingsPackageName": "whatwg-streams",
"sourceRepoURL": "https://streams.spec.whatwg.org",
"asOfVersion": "3.2.1"
Copy link
Contributor Author

@MattiasBuelens MattiasBuelens Oct 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that in other PRs that removed types for DOM APIs (e.g. #34641), the asOfVersion field is always set to 2.0.0. I'm not sure if there's a special reason for this?

I've put in the TypeScript version in which streams were added to the DOM types. If that's not how this field works, let me know. 🙂

},
{
"libraryName": "winston",
"typingsPackageName": "winston",
Expand Down
167 changes: 0 additions & 167 deletions types/whatwg-streams/index.d.ts
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions types/whatwg-streams/tsconfig.json
View file
Open in desktop

This file was deleted.

80 changes: 0 additions & 80 deletions types/whatwg-streams/tslint.json
View file
Open in desktop

This file was deleted.

Loading