Skip to content

[form-data] Remove @types/form-data since v2.5.0 it bundles types#36926

Closed
mapleeit wants to merge 3 commits intoDefinitelyTyped:masterfrom
mapleeit:feat-remove-form-data
Closed

[form-data] Remove @types/form-data since v2.5.0 it bundles types#36926
mapleeit wants to merge 3 commits intoDefinitelyTyped:masterfrom
mapleeit:feat-remove-form-data

Conversation

@mapleeit
Copy link

@mapleeit mapleeit commented Jul 16, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@mapleeit mapleeit requested a review from Bartvds as a code owner July 16, 2019 08:10
@mapleeit mapleeit mentioned this pull request Jul 16, 2019
Merged
9 tasks
@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Jul 16, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 16, 2019 •
edited
Loading

@mapleeit Thank you for submitting this PR!

🔔 @BendingBender @LinusU @ikokostya @stijnvn @wingsbob @ryanwilsonperkin - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

ffflorian
ffflorian suggested changes Jul 16, 2019
View reviewed changes
@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Jul 16, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 16, 2019

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #36926 diff
Batch compilation
Memory usage (MiB) 100.4 98.8 -1.6%
Type count 17607 17607 0.0%
Assignability cache size 36847 36847 0.0%
Subtype cache size 223 223 0.0%
Identity cache size 4 4 0.0%
Language service
Samples taken 576 576 0.0%
Identifiers in tests 576 576 0.0%
getCompletionsAtPosition
    Mean duration (ms) 670.9 649.3 -3.2%
    Median duration (ms) 669.6 648.9 -3.1%
    Mean CV 6.1% 7.2% +17.3%
    Worst duration (ms) 787.0 754.8 -4.1%
    Worst identifier prependListener e
getQuickInfoAtPosition
    Mean duration (ms) 567.3 552.2 -2.7%
    Median duration (ms) 563.3 549.0 -2.5%
    Mean CV 7.5% 8.2% +8.6%
    Worst duration (ms) 676.0 662.1 -2.1%
    Worst identifier b o

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.

If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Jul 16, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 16, 2019

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

sandersn
sandersn requested changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think got builds without the dependency. At least it did in the overnight run. So can you verify that this change is needed?

@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Other Approved This PR was reviewed and signed-off by a community member. Merge:Express labels Jul 16, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 16, 2019

@mapleeit One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

@mapleeit
Copy link
Author

mapleeit commented Jul 17, 2019 •
edited
Loading

@sandersn I'm not sure about this. I just followed tutorial of removing a package on readme. https://github.com/DefinitelyTyped/DefinitelyTyped#removing-a-package

I noticed that got have a nested node_modules. And outer layer contains the dependencies declaration. I'm not sure should inner layer contains it or not.

image

@sandersn
Copy link
Contributor

sandersn commented Jul 17, 2019

A couple of points.

  1. [form-data] Remove form-data #36819 already removed form-data, as far as I can tell.
  2. The instructions say to add dependencies on everything that fails with npm test after form-data is removed. Does got fail after form-data is removed but before the dependency is added to package.json?

@mapleeit
Copy link
Author

mapleeit commented Jul 18, 2019

Got it. I'll close this.

@mapleeit mapleeit closed this Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandersn sandersn sandersn requested changes

@Bartvds Bartvds Awaiting requested review from Bartvds

+2 more reviewers

@LinusU LinusU LinusU approved these changes

@ffflorian ffflorian ffflorian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Revision needed This PR needs code changes before it can be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mapleeit @typescript-bot @sandersn @LinusU @ffflorian