Skip to content

[form-data] Remove form-data#36819

Merged
sandersn merged 1 commit intoDefinitelyTyped:masterfrom
ffflorian:remove-form-data
Jul 13, 2019
Merged

[form-data] Remove form-data#36819
sandersn merged 1 commit intoDefinitelyTyped:masterfrom
ffflorian:remove-form-data

Conversation

@ffflorian
Copy link
Collaborator

@ffflorian ffflorian commented Jul 11, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

See https://github.com/form-data/form-data/releases/tag/v2.5.0

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Jul 11, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 11, 2019 •
edited
Loading

@ffflorian Thank you for submitting this PR!

🔔 @soywiz @leonyu @BendingBender @LinusU @ikokostya @stijnvn @wingsbob @ryanwilsonperkin @sampsonjoliver @andipaetzold @JiriBalcar @bonnici @Bartvds @joeskeen @ccurrens @lookfirst @mastermatt @josecolella @murbanowicz - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@ffflorian ffflorian requested a review from Bartvds as a code owner July 11, 2019 09:30
@ffflorian
Copy link
Collaborator Author

ffflorian commented Jul 11, 2019 •
edited
Loading

@sandersn types-publisher tells me:

Error: In package.json: Dependency form-data not in whitelist

But I see form-data in the whitelisted dependencies:

https://github.com/microsoft/types-publisher/blob/79dc4eda9669b877d4d56b2b93f5644a4453dc46/dependenciesWhitelist.txt#L59

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 11, 2019 •
edited
Loading

@ffflorian The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ffflorian ffflorian changed the title [form-data] Remove types [form-data] Remove form-data Jul 11, 2019
@sandersn
Copy link
Contributor

sandersn commented Jul 11, 2019

Sorry, forgot to publish types-publisher after merging. I published it just now.

types-publisher works from the production branch, so in the future you can check there to see what its dependency list currently looks like.

@sandersn
Copy link
Contributor

sandersn commented Jul 11, 2019

@ffflorian can you try merging from master? I'm not sure why Azure gets the new types-publisher but Travis does not.

@ffflorian
Copy link
Collaborator Author

ffflorian commented Jul 12, 2019

@sandersn I rebased from master but Travis still has the same problem 🙁

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 12, 2019 •
edited
Loading

@ffflorian The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@sandersn
Copy link
Contributor

sandersn commented Jul 12, 2019

This still fails on Travis, even after I delete its cache. I'm not sure what's going on, but if author(s) will sign off, I'll go ahead and merge regardless.

LinusU
LinusU approved these changes Jul 13, 2019
View reviewed changes
Copy link
Contributor

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jul 13, 2019
@sandersn sandersn merged commit 8d97418 into DefinitelyTyped:master Jul 13, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 13, 2019

I just published @types/got@9.6.1 to npm.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 13, 2019

I just published @types/mailgun-js@0.22.2 to npm.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 13, 2019

I just published @types/request@2.48.2 to npm.

@ffflorian ffflorian deleted the remove-form-data branch July 13, 2019 15:35
@dsifford dsifford mentioned this pull request Jul 14, 2019
Merged
10 tasks
mikeharder added a commit to mikeharder/azure-sdk-for-js that referenced this pull request Jul 15, 2019
@mikeharder
Remove deprecated dev dependency @types/form-data
952e77d 
- TS typings were moved from @types/form-data to form-data in 2.5.0
  - form-data/form-data#428
- @types/form-data is deprecated as of 2.5.0
  - DefinitelyTyped/DefinitelyTyped#36819
@mikeharder mikeharder mentioned this pull request Jul 15, 2019
Merged
mikeharder added a commit to Azure/azure-sdk-for-js that referenced this pull request Jul 15, 2019
@mikeharder
Remove deprecated dev dependency @types/form-data (#4313)
4032855 
- TS typings were moved from @types/form-data to form-data in 2.5.0
  - form-data/form-data#428
- @types/form-data is deprecated as of 2.5.0
  - DefinitelyTyped/DefinitelyTyped#36819
@mapleeit
Copy link

mapleeit commented Jul 16, 2019 •
edited
Loading

I tried to remove @types/form-data several times. But CI blocks it somehow every time. I noticed that today and remade one. This should remove form-data totally (I followed the tutorial of removing package on readme). PTAL if you guys have time. Thank you.

#36926

@sandersn sandersn mentioned this pull request Jul 17, 2019
Closed
9 tasks
iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
@ffflorian
[form-data] Remove form-data (DefinitelyTyped#36819)
e661824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bartvds Bartvds Awaiting requested review from Bartvds Bartvds is a code owner

1 more reviewer

@LinusU LinusU LinusU approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ffflorian @typescript-bot @sandersn @mapleeit @LinusU