Skip to content

chore(profiling): ensure correct order of profiler post-fork hooks#17418

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
kowalski/fix-profiling-ensure-correct-order-of-profiler-post-fork-hooks-17183
Apr 17, 2026
Merged

chore(profiling): ensure correct order of profiler post-fork hooks#17418
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
kowalski/fix-profiling-ensure-correct-order-of-profiler-post-fork-hooks-17183

Conversation

@KowalskiThomas

@KowalskiThomas KowalskiThomas commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Description

This reverts commit 10f1503 / #17417 and reapplies #17183. See original PR for more info and context.

On top of the previous PR, it adds fork handlers so that we lock profile_mtx pre-fork and unlock it post-fork (after making sure the ProfilerState is in a clean state). Doing this allows to avoid cases where the Sampling Thread would try to use corrupt/inconsistent ProfilerState data post-fork.

@datadog-prod-us1-4

This comment has been minimized.

@KowalskiThomas KowalskiThomas changed the title fix(profiling): revert ensure correct order of profiler post-fork hooks chore(profiling): ensure correct order of profiler post-fork hooks Apr 9, 2026
@KowalskiThomas KowalskiThomas added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 9, 2026
@pr-commenter

pr-commenter Bot commented Apr 9, 2026

Copy link
Copy Markdown

Performance SLOs

Comparing candidate kowalski/fix-profiling-ensure-correct-order-of-profiler-post-fork-hooks-17183 (d1602c2) with baseline main (d233350)

📈 Performance Regressions (2 suites)
📈 iastaspects - 118/118

✅ add_aspect

Time: ✅ 104.318µs (SLO: <130.000µs 📉 -19.8%) vs baseline: +3.8%

Memory: ✅ 43.953MB (SLO: <46.000MB -4.5%) vs baseline: +5.0%


✅ add_inplace_aspect

Time: ✅ 100.985µs (SLO: <130.000µs 📉 -22.3%) vs baseline: -0.4%

Memory: ✅ 43.844MB (SLO: <46.000MB -4.7%) vs baseline: +4.7%


✅ add_inplace_noaspect

Time: ✅ 28.085µs (SLO: <40.000µs 📉 -29.8%) vs baseline: -0.7%

Memory: ✅ 43.839MB (SLO: <46.000MB -4.7%) vs baseline: +4.9%


✅ add_noaspect

Time: ✅ 48.955µs (SLO: <70.000µs 📉 -30.1%) vs baseline: +0.2%

Memory: ✅ 43.862MB (SLO: <46.000MB -4.6%) vs baseline: +4.8%


✅ bytearray_aspect

Time: ✅ 256.505µs (SLO: <400.000µs 📉 -35.9%) vs baseline: +1.7%

Memory: ✅ 43.946MB (SLO: <46.000MB -4.5%) vs baseline: +5.0%


✅ bytearray_extend_aspect

Time: ✅ 659.326µs (SLO: <800.000µs 📉 -17.6%) vs baseline: -1.1%

Memory: ✅ 43.915MB (SLO: <46.000MB -4.5%) vs baseline: +5.1%


✅ bytearray_extend_noaspect

Time: ✅ 269.535µs (SLO: <400.000µs 📉 -32.6%) vs baseline: ~same

Memory: ✅ 43.898MB (SLO: <46.000MB -4.6%) vs baseline: +5.0%


✅ bytearray_noaspect

Time: ✅ 141.588µs (SLO: <300.000µs 📉 -52.8%) vs baseline: +2.2%

Memory: ✅ 43.924MB (SLO: <46.000MB -4.5%) vs baseline: +5.2%


✅ bytes_aspect

Time: ✅ 220.919µs (SLO: <300.000µs 📉 -26.4%) vs baseline: +0.6%

Memory: ✅ 43.921MB (SLO: <46.000MB -4.5%) vs baseline: +4.9%


✅ bytes_noaspect

Time: ✅ 134.064µs (SLO: <200.000µs 📉 -33.0%) vs baseline: -0.7%

Memory: ✅ 43.741MB (SLO: <46.000MB -4.9%) vs baseline: +4.6%


✅ bytesio_aspect

Time: ✅ 3.783ms (SLO: <5.000ms 📉 -24.3%) vs baseline: -1.1%

Memory: ✅ 43.926MB (SLO: <46.000MB -4.5%) vs baseline: +4.9%


✅ bytesio_noaspect

Time: ✅ 317.940µs (SLO: <420.000µs 📉 -24.3%) vs baseline: ~same

Memory: ✅ 43.900MB (SLO: <46.000MB -4.6%) vs baseline: +5.0%


✅ capitalize_aspect

Time: ✅ 88.177µs (SLO: <300.000µs 📉 -70.6%) vs baseline: +0.3%

Memory: ✅ 43.883MB (SLO: <46.000MB -4.6%) vs baseline: +5.0%


✅ capitalize_noaspect

Time: ✅ 253.538µs (SLO: <300.000µs 📉 -15.5%) vs baseline: +2.2%

Memory: ✅ 43.835MB (SLO: <46.000MB -4.7%) vs baseline: +4.7%


✅ casefold_aspect

Time: ✅ 88.444µs (SLO: <500.000µs 📉 -82.3%) vs baseline: -0.3%

Memory: ✅ 43.871MB (SLO: <46.000MB -4.6%) vs baseline: +4.7%


✅ casefold_noaspect

Time: ✅ 308.782µs (SLO: <500.000µs 📉 -38.2%) vs baseline: +1.1%

Memory: ✅ 43.825MB (SLO: <46.000MB -4.7%) vs baseline: +4.7%


✅ decode_aspect

Time: ✅ 86.796µs (SLO: <100.000µs 📉 -13.2%) vs baseline: -0.8%

Memory: ✅ 43.799MB (SLO: <46.000MB -4.8%) vs baseline: +4.7%


✅ decode_noaspect

Time: ✅ 155.878µs (SLO: <210.000µs 📉 -25.8%) vs baseline: -0.9%

Memory: ✅ 43.909MB (SLO: <46.000MB -4.5%) vs baseline: +4.8%


✅ encode_aspect

Time: ✅ 84.636µs (SLO: <200.000µs 📉 -57.7%) vs baseline: +0.2%

Memory: ✅ 43.832MB (SLO: <46.000MB -4.7%) vs baseline: +5.0%


✅ encode_noaspect

Time: ✅ 143.695µs (SLO: <200.000µs 📉 -28.2%) vs baseline: +0.2%

Memory: ✅ 43.842MB (SLO: <46.000MB -4.7%) vs baseline: +4.7%


✅ format_aspect

Time: ✅ 14.651ms (SLO: <19.200ms 📉 -23.7%) vs baseline: +0.3%

Memory: ✅ 43.949MB (SLO: <46.000MB -4.5%) vs baseline: +4.8%


✅ format_map_aspect

Time: ✅ 16.469ms (SLO: <21.500ms 📉 -23.4%) vs baseline: ~same

Memory: ✅ 43.922MB (SLO: <46.000MB -4.5%) vs baseline: +4.6%


✅ format_map_noaspect

Time: ✅ 380.092µs (SLO: <500.000µs 📉 -24.0%) vs baseline: -2.7%

Memory: ✅ 43.897MB (SLO: <46.000MB -4.6%) vs baseline: +5.0%


✅ format_noaspect

Time: ✅ 308.453µs (SLO: <500.000µs 📉 -38.3%) vs baseline: -1.5%

Memory: ✅ 43.948MB (SLO: <46.000MB -4.5%) vs baseline: +5.1%


✅ index_aspect

Time: ✅ 136.588µs (SLO: <300.000µs 📉 -54.5%) vs baseline: 📈 +10.4%

Memory: ✅ 43.829MB (SLO: <46.000MB -4.7%) vs baseline: +4.8%


✅ index_noaspect

Time: ✅ 40.980µs (SLO: <300.000µs 📉 -86.3%) vs baseline: +0.8%

Memory: ✅ 43.803MB (SLO: <46.000MB -4.8%) vs baseline: +4.7%


✅ join_aspect

Time: ✅ 209.173µs (SLO: <300.000µs 📉 -30.3%) vs baseline: -0.7%

Memory: ✅ 43.836MB (SLO: <46.000MB -4.7%) vs baseline: +4.6%


✅ join_noaspect

Time: ✅ 141.565µs (SLO: <300.000µs 📉 -52.8%) vs baseline: -1.8%

Memory: ✅ 43.849MB (SLO: <46.000MB -4.7%) vs baseline: +4.8%


✅ ljust_aspect

Time: ✅ 576.000µs (SLO: <700.000µs 📉 -17.7%) vs baseline: 📈 +14.6%

Memory: ✅ 43.848MB (SLO: <46.000MB -4.7%) vs baseline: +4.6%


✅ ljust_noaspect

Time: ✅ 256.621µs (SLO: <300.000µs 📉 -14.5%) vs baseline: -0.5%

Memory: ✅ 43.842MB (SLO: <46.000MB -4.7%) vs baseline: +4.9%


✅ lower_aspect

Time: ✅ 302.973µs (SLO: <500.000µs 📉 -39.4%) vs baseline: -2.9%

Memory: ✅ 43.868MB (SLO: <46.000MB -4.6%) vs baseline: +5.0%


✅ lower_noaspect

Time: ✅ 238.619µs (SLO: <300.000µs 📉 -20.5%) vs baseline: +0.9%

Memory: ✅ 43.786MB (SLO: <46.000MB -4.8%) vs baseline: +4.6%


✅ lstrip_aspect

Time: ✅ 0.275ms (SLO: <3.000ms 📉 -90.8%) vs baseline: -1.9%

Memory: ✅ 43.910MB (SLO: <46.000MB -4.5%) vs baseline: +4.8%


✅ lstrip_noaspect

Time: ✅ 0.180ms (SLO: <3.000ms 📉 -94.0%) vs baseline: +2.1%

Memory: ✅ 43.826MB (SLO: <46.000MB -4.7%) vs baseline: +4.8%


✅ modulo_aspect

Time: ✅ 14.309ms (SLO: <18.750ms 📉 -23.7%) vs baseline: +0.4%

Memory: ✅ 43.967MB (SLO: <46.000MB -4.4%) vs baseline: +5.1%


✅ modulo_aspect_for_bytearray_bytearray

Time: ✅ 14.789ms (SLO: <19.350ms 📉 -23.6%) vs baseline: ~same

Memory: ✅ 43.931MB (SLO: <46.000MB -4.5%) vs baseline: +5.1%


✅ modulo_aspect_for_bytes

Time: ✅ 14.391ms (SLO: <18.900ms 📉 -23.9%) vs baseline: -0.3%

Memory: ✅ 43.973MB (SLO: <46.000MB -4.4%) vs baseline: +5.0%


✅ modulo_aspect_for_bytes_bytearray

Time: ✅ 14.677ms (SLO: <19.150ms 📉 -23.4%) vs baseline: ~same

Memory: ✅ 43.964MB (SLO: <46.000MB -4.4%) vs baseline: +5.0%


✅ modulo_noaspect

Time: ✅ 0.364ms (SLO: <3.000ms 📉 -87.9%) vs baseline: -1.2%

Memory: ✅ 43.820MB (SLO: <46.000MB -4.7%) vs baseline: +4.4%


✅ replace_aspect

Time: ✅ 18.511ms (SLO: <24.000ms 📉 -22.9%) vs baseline: ~same

Memory: ✅ 43.933MB (SLO: <46.000MB -4.5%) vs baseline: +4.7%


✅ replace_noaspect

Time: ✅ 284.912µs (SLO: <400.000µs 📉 -28.8%) vs baseline: +0.3%

Memory: ✅ 43.860MB (SLO: <46.000MB -4.7%) vs baseline: +4.8%


✅ repr_aspect

Time: ✅ 325.271µs (SLO: <420.000µs 📉 -22.6%) vs baseline: +0.5%

Memory: ✅ 43.881MB (SLO: <46.000MB -4.6%) vs baseline: +4.9%


✅ repr_noaspect

Time: ✅ 47.260µs (SLO: <90.000µs 📉 -47.5%) vs baseline: +0.9%

Memory: ✅ 43.839MB (SLO: <46.000MB -4.7%) vs baseline: +5.0%


✅ rstrip_aspect

Time: ✅ 391.220µs (SLO: <500.000µs 📉 -21.8%) vs baseline: +1.0%

Memory: ✅ 43.875MB (SLO: <46.000MB -4.6%) vs baseline: +4.9%


✅ rstrip_noaspect

Time: ✅ 182.505µs (SLO: <300.000µs 📉 -39.2%) vs baseline: -1.4%

Memory: ✅ 43.768MB (SLO: <46.000MB -4.9%) vs baseline: +4.5%


✅ slice_aspect

Time: ✅ 185.734µs (SLO: <300.000µs 📉 -38.1%) vs baseline: +0.6%

Memory: ✅ 43.839MB (SLO: <46.000MB -4.7%) vs baseline: +4.7%


✅ slice_noaspect

Time: ✅ 53.839µs (SLO: <90.000µs 📉 -40.2%) vs baseline: -1.0%

Memory: ✅ 43.812MB (SLO: <46.000MB -4.8%) vs baseline: +4.6%


✅ stringio_aspect

Time: ✅ 3.789ms (SLO: <5.000ms 📉 -24.2%) vs baseline: -1.1%

Memory: ✅ 43.853MB (SLO: <46.000MB -4.7%) vs baseline: +4.5%


✅ stringio_noaspect

Time: ✅ 379.287µs (SLO: <500.000µs 📉 -24.1%) vs baseline: +8.9%

Memory: ✅ 43.710MB (SLO: <46.000MB -5.0%) vs baseline: +4.5%


✅ strip_aspect

Time: ✅ 275.622µs (SLO: <350.000µs 📉 -21.3%) vs baseline: -2.1%

Memory: ✅ 43.867MB (SLO: <46.000MB -4.6%) vs baseline: +4.8%


✅ strip_noaspect

Time: ✅ 179.855µs (SLO: <240.000µs 📉 -25.1%) vs baseline: +1.4%

Memory: ✅ 43.830MB (SLO: <46.000MB -4.7%) vs baseline: +4.8%


✅ swapcase_aspect

Time: ✅ 336.947µs (SLO: <500.000µs 📉 -32.6%) vs baseline: +0.8%

Memory: ✅ 43.913MB (SLO: <46.000MB -4.5%) vs baseline: +4.9%


✅ swapcase_noaspect

Time: ✅ 275.310µs (SLO: <400.000µs 📉 -31.2%) vs baseline: +0.4%

Memory: ✅ 43.763MB (SLO: <46.000MB -4.9%) vs baseline: +4.8%


✅ title_aspect

Time: ✅ 333.185µs (SLO: <500.000µs 📉 -33.4%) vs baseline: +0.6%

Memory: ✅ 43.936MB (SLO: <46.000MB -4.5%) vs baseline: +5.0%


✅ title_noaspect

Time: ✅ 259.590µs (SLO: <400.000µs 📉 -35.1%) vs baseline: -1.2%

Memory: ✅ 43.865MB (SLO: <46.000MB -4.6%) vs baseline: +4.8%


✅ translate_aspect

Time: ✅ 504.055µs (SLO: <700.000µs 📉 -28.0%) vs baseline: +1.0%

Memory: ✅ 43.870MB (SLO: <46.000MB -4.6%) vs baseline: +4.8%


✅ translate_noaspect

Time: ✅ 427.306µs (SLO: <500.000µs 📉 -14.5%) vs baseline: -0.1%

Memory: ✅ 43.879MB (SLO: <46.000MB -4.6%) vs baseline: +4.7%


✅ upper_aspect

Time: ✅ 302.980µs (SLO: <500.000µs 📉 -39.4%) vs baseline: -0.6%

Memory: ✅ 43.824MB (SLO: <46.000MB -4.7%) vs baseline: +4.7%


✅ upper_noaspect

Time: ✅ 234.259µs (SLO: <400.000µs 📉 -41.4%) vs baseline: -1.1%

Memory: ✅ 43.864MB (SLO: <46.000MB -4.6%) vs baseline: +4.7%


📈 iastaspectsospath - 24/24

✅ ospathbasename_aspect

Time: ✅ 512.982µs (SLO: <700.000µs 📉 -26.7%) vs baseline: 📈 +19.6%

Memory: ✅ 43.824MB (SLO: <46.000MB -4.7%) vs baseline: +5.0%


✅ ospathbasename_noaspect

Time: ✅ 437.655µs (SLO: <700.000µs 📉 -37.5%) vs baseline: +0.2%

Memory: ✅ 43.959MB (SLO: <46.000MB -4.4%) vs baseline: +4.9%


✅ ospathjoin_aspect

Time: ✅ 630.421µs (SLO: <700.000µs -9.9%) vs baseline: +0.3%

Memory: ✅ 43.923MB (SLO: <46.000MB -4.5%) vs baseline: +5.0%


✅ ospathjoin_noaspect

Time: ✅ 647.267µs (SLO: <700.000µs -7.5%) vs baseline: ~same

Memory: ✅ 43.820MB (SLO: <46.000MB -4.7%) vs baseline: +4.8%


✅ ospathnormcase_aspect

Time: ✅ 356.075µs (SLO: <700.000µs 📉 -49.1%) vs baseline: -0.4%

Memory: ✅ 43.797MB (SLO: <46.000MB -4.8%) vs baseline: +4.7%


✅ ospathnormcase_noaspect

Time: ✅ 367.768µs (SLO: <700.000µs 📉 -47.5%) vs baseline: +0.4%

Memory: ✅ 43.881MB (SLO: <46.000MB -4.6%) vs baseline: +5.0%


✅ ospathsplit_aspect

Time: ✅ 491.297µs (SLO: <700.000µs 📉 -29.8%) vs baseline: +0.5%

Memory: ✅ 43.937MB (SLO: <46.000MB -4.5%) vs baseline: +5.0%


✅ ospathsplit_noaspect

Time: ✅ 505.212µs (SLO: <700.000µs 📉 -27.8%) vs baseline: +0.5%

Memory: ✅ 43.770MB (SLO: <46.000MB -4.8%) vs baseline: +4.8%


✅ ospathsplitdrive_aspect

Time: ✅ 373.512µs (SLO: <700.000µs 📉 -46.6%) vs baseline: -1.6%

Memory: ✅ 43.965MB (SLO: <46.000MB -4.4%) vs baseline: +5.1%


✅ ospathsplitdrive_noaspect

Time: ✅ 72.579µs (SLO: <700.000µs 📉 -89.6%) vs baseline: +0.2%

Memory: ✅ 43.816MB (SLO: <46.000MB -4.7%) vs baseline: +4.8%


✅ ospathsplitext_aspect

Time: ✅ 463.227µs (SLO: <700.000µs 📉 -33.8%) vs baseline: +0.9%

Memory: ✅ 43.915MB (SLO: <46.000MB -4.5%) vs baseline: +5.0%


✅ ospathsplitext_noaspect

Time: ✅ 468.618µs (SLO: <700.000µs 📉 -33.1%) vs baseline: -1.0%

Memory: ✅ 43.869MB (SLO: <46.000MB -4.6%) vs baseline: +4.8%

🟡 Near SLO Breach (5 suites)
🟡 djangosimple - 30/30

✅ appsec

Time: ✅ 19.875ms (SLO: <22.300ms 📉 -10.9%) vs baseline: +0.4%

Memory: ✅ 69.343MB (SLO: <73.500MB -5.7%) vs baseline: +4.8%


✅ exception-replay-enabled

Time: ✅ 1.368ms (SLO: <1.450ms -5.7%) vs baseline: ~same

Memory: ✅ 67.653MB (SLO: <71.500MB -5.4%) vs baseline: +4.9%


✅ iast

Time: ✅ 19.880ms (SLO: <22.250ms 📉 -10.7%) vs baseline: -0.4%

Memory: ✅ 69.419MB (SLO: <75.000MB -7.4%) vs baseline: +5.1%


✅ profiler

Time: ✅ 15.153ms (SLO: <16.550ms -8.4%) vs baseline: +0.2%

Memory: ✅ 60.197MB (SLO: <61.000MB 🟡 -1.3%) vs baseline: +5.2%


✅ resource-renaming

Time: ✅ 19.973ms (SLO: <21.750ms -8.2%) vs baseline: +0.5%

Memory: ✅ 69.268MB (SLO: <73.500MB -5.8%) vs baseline: +4.9%


✅ span-code-origin

Time: ✅ 20.383ms (SLO: <28.200ms 📉 -27.7%) vs baseline: +0.9%

Memory: ✅ 69.353MB (SLO: <75.000MB -7.5%) vs baseline: +4.8%


✅ tracer

Time: ✅ 19.897ms (SLO: <21.750ms -8.5%) vs baseline: +0.3%

Memory: ✅ 69.442MB (SLO: <75.000MB -7.4%) vs baseline: +5.0%


✅ tracer-and-profiler

Time: ✅ 21.240ms (SLO: <23.500ms -9.6%) vs baseline: +0.1%

Memory: ✅ 71.329MB (SLO: <75.000MB -4.9%) vs baseline: +4.8%


✅ tracer-dont-create-db-spans

Time: ✅ 19.981ms (SLO: <21.500ms -7.1%) vs baseline: ~same

Memory: ✅ 69.403MB (SLO: <75.000MB -7.5%) vs baseline: +5.0%


✅ tracer-minimal

Time: ✅ 16.921ms (SLO: <17.500ms -3.3%) vs baseline: ~same

Memory: ✅ 69.334MB (SLO: <75.000MB -7.6%) vs baseline: +4.8%


✅ tracer-native

Time: ✅ 19.905ms (SLO: <21.750ms -8.5%) vs baseline: +1.1%

Memory: ✅ 69.315MB (SLO: <72.500MB -4.4%) vs baseline: +4.8%


✅ tracer-no-caches

Time: ✅ 17.715ms (SLO: <19.650ms -9.8%) vs baseline: -0.8%

Memory: ✅ 69.333MB (SLO: <75.000MB -7.6%) vs baseline: +4.8%


✅ tracer-no-databases

Time: ✅ 19.559ms (SLO: <20.100ms -2.7%) vs baseline: ~same

Memory: ✅ 69.363MB (SLO: <75.000MB -7.5%) vs baseline: +5.0%


✅ tracer-no-middleware

Time: ✅ 19.531ms (SLO: <21.500ms -9.2%) vs baseline: -0.5%

Memory: ✅ 69.393MB (SLO: <75.000MB -7.5%) vs baseline: +4.9%


✅ tracer-no-templates

Time: ✅ 19.965ms (SLO: <22.000ms -9.2%) vs baseline: +0.9%

Memory: ✅ 69.385MB (SLO: <73.500MB -5.6%) vs baseline: +4.8%


🟡 otelspan - 22/22

✅ add-event

Time: ✅ 40.608ms (SLO: <47.150ms 📉 -13.9%) vs baseline: -0.6%

Memory: ✅ 41.185MB (SLO: <47.000MB 📉 -12.4%) vs baseline: +5.0%


✅ add-metrics

Time: ✅ 235.052ms (SLO: <344.800ms 📉 -31.8%) vs baseline: -0.2%

Memory: ✅ 45.653MB (SLO: <47.500MB -3.9%) vs baseline: +4.7%


✅ add-tags

Time: ✅ 276.324ms (SLO: <330.000ms 📉 -16.3%) vs baseline: -0.1%

Memory: ✅ 45.593MB (SLO: <47.500MB -4.0%) vs baseline: +4.6%


✅ get-context

Time: ✅ 83.637ms (SLO: <92.350ms -9.4%) vs baseline: -0.1%

Memory: ✅ 41.465MB (SLO: <46.500MB 📉 -10.8%) vs baseline: +5.1%


✅ is-recording

Time: ✅ 39.271ms (SLO: <44.500ms 📉 -11.8%) vs baseline: +0.4%

Memory: ✅ 41.167MB (SLO: <47.500MB 📉 -13.3%) vs baseline: +4.6%


✅ record-exception

Time: ✅ 60.912ms (SLO: <67.650ms -10.0%) vs baseline: -0.4%

Memory: ✅ 41.710MB (SLO: <47.000MB 📉 -11.3%) vs baseline: +4.8%


✅ set-status

Time: ✅ 45.282ms (SLO: <50.400ms 📉 -10.2%) vs baseline: +0.7%

Memory: ✅ 41.211MB (SLO: <47.000MB 📉 -12.3%) vs baseline: +5.3%


✅ start

Time: ✅ 40.061ms (SLO: <44.500ms -10.0%) vs baseline: +3.3%

Memory: ✅ 41.126MB (SLO: <47.000MB 📉 -12.5%) vs baseline: +4.8%


✅ start-finish

Time: ✅ 90.299ms (SLO: <91.000ms 🟡 -0.8%) vs baseline: +0.2%

Memory: ✅ 38.692MB (SLO: <46.500MB 📉 -16.8%) vs baseline: +4.5%


✅ start-finish-telemetry

Time: ✅ 91.789ms (SLO: <92.000ms 🟡 -0.2%) vs baseline: +0.2%

Memory: ✅ 38.712MB (SLO: <46.500MB 📉 -16.7%) vs baseline: +5.0%


✅ update-name

Time: ✅ 40.225ms (SLO: <45.150ms 📉 -10.9%) vs baseline: +0.2%

Memory: ✅ 41.327MB (SLO: <47.000MB 📉 -12.1%) vs baseline: +5.2%


🟡 recursivecomputation - 8/8

✅ deep

Time: ✅ 312.144ms (SLO: <320.950ms -2.7%) vs baseline: -0.4%

Memory: ✅ 37.336MB (SLO: <38.750MB -3.6%) vs baseline: +4.7%


✅ deep-profiled

Time: ✅ 328.086ms (SLO: <359.150ms -8.6%) vs baseline: -0.1%

Memory: ✅ 43.726MB (SLO: <46.000MB -4.9%) vs baseline: +5.0%


✅ medium

Time: ✅ 7.399ms (SLO: <7.400ms 🟡 ~same) vs baseline: -0.7%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +4.9%


✅ shallow

Time: ✅ 1.048ms (SLO: <1.050ms 🟡 -0.2%) vs baseline: +2.0%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +5.0%


🟡 span - 26/26

✅ add-event

Time: ✅ 19.587ms (SLO: <22.500ms 📉 -12.9%) vs baseline: +0.3%

Memory: ✅ 38.454MB (SLO: <53.000MB 📉 -27.4%) vs baseline: +5.0%


✅ add-metrics

Time: ✅ 89.190ms (SLO: <93.500ms -4.6%) vs baseline: +0.2%

Memory: ✅ 42.870MB (SLO: <53.000MB 📉 -19.1%) vs baseline: +4.7%


✅ add-tags

Time: ✅ 149.457ms (SLO: <155.000ms -3.6%) vs baseline: +0.7%

Memory: ✅ 42.930MB (SLO: <53.000MB 📉 -19.0%) vs baseline: +4.9%


✅ get-context

Time: ✅ 18.762ms (SLO: <20.500ms -8.5%) vs baseline: ~same

Memory: ✅ 38.381MB (SLO: <53.000MB 📉 -27.6%) vs baseline: +4.9%


✅ is-recording

Time: ✅ 18.923ms (SLO: <20.500ms -7.7%) vs baseline: +0.4%

Memory: ✅ 38.322MB (SLO: <53.000MB 📉 -27.7%) vs baseline: +4.6%


✅ record-exception

Time: ✅ 38.531ms (SLO: <41.000ms -6.0%) vs baseline: +0.5%

Memory: ✅ 38.910MB (SLO: <53.000MB 📉 -26.6%) vs baseline: +5.2%


✅ set-status

Time: ✅ 20.685ms (SLO: <22.000ms -6.0%) vs baseline: +0.3%

Memory: ✅ 38.394MB (SLO: <53.000MB 📉 -27.6%) vs baseline: +5.1%


✅ start

Time: ✅ 19.673ms (SLO: <20.500ms -4.0%) vs baseline: +5.4%

Memory: ✅ 38.364MB (SLO: <53.000MB 📉 -27.6%) vs baseline: +5.1%


✅ start-finish

Time: ✅ 58.377ms (SLO: <58.500ms 🟡 -0.2%) vs baseline: +0.2%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +4.9%


✅ start-finish-telemetry

Time: ✅ 59.575ms (SLO: <60.000ms 🟡 -0.7%) vs baseline: -0.2%

Memory: ✅ 36.196MB (SLO: <38.000MB -4.7%) vs baseline: +4.7%


✅ start-finish-traceid128

Time: ✅ 60.792ms (SLO: <62.000ms 🟡 -1.9%) vs baseline: +0.2%

Memory: ✅ 36.196MB (SLO: <38.000MB -4.7%) vs baseline: +5.1%


✅ start-traceid128

Time: ✅ 18.775ms (SLO: <22.500ms 📉 -16.6%) vs baseline: +0.4%

Memory: ✅ 38.292MB (SLO: <53.000MB 📉 -27.8%) vs baseline: +4.4%


✅ update-name

Time: ✅ 19.381ms (SLO: <22.000ms 📉 -11.9%) vs baseline: +0.3%

Memory: ✅ 38.443MB (SLO: <53.000MB 📉 -27.5%) vs baseline: +5.0%


🟡 tracer - 6/6

✅ large

Time: ✅ 32.999ms (SLO: <32.950ms +0.2%) vs baseline: ~same

Memory: ✅ 37.768MB (SLO: <39.250MB -3.8%) vs baseline: +4.8%


✅ medium

Time: ✅ 3.320ms (SLO: <3.500ms -5.1%) vs baseline: +0.6%

Memory: ✅ 36.255MB (SLO: <38.750MB -6.4%) vs baseline: +4.9%


✅ small

Time: ✅ 384.752µs (SLO: <390.000µs 🟡 -1.3%) vs baseline: +3.8%

Memory: ✅ 36.255MB (SLO: <38.750MB -6.4%) vs baseline: +4.9%

⚠️ Unstable Tests (2 suites)
⚠️ coreapiscenario - 10/10 (1 unstable)

⚠️ context_with_data_listeners

Time: ⚠️ 13.670µs (SLO: <20.000µs 📉 -31.6%) vs baseline: +0.1%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +4.7%


✅ context_with_data_no_listeners

Time: ✅ 3.607µs (SLO: <10.000µs 📉 -63.9%) vs baseline: -2.0%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +5.0%


✅ get_item_exists

Time: ✅ 0.580µs (SLO: <10.000µs 📉 -94.2%) vs baseline: +0.5%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +5.0%


✅ get_item_missing

Time: ✅ 0.633µs (SLO: <10.000µs 📉 -93.7%) vs baseline: ~same

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +4.7%


✅ set_item

Time: ✅ 24.435µs (SLO: <30.000µs 📉 -18.5%) vs baseline: -0.9%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +5.0%


⚠️ packagesupdateimporteddependencies - 24/24 (1 unstable)

✅ import_many

Time: ✅ 156.230µs (SLO: <170.000µs -8.1%) vs baseline: +0.3%

Memory: ✅ 41.638MB (SLO: <46.000MB -9.5%) vs baseline: +5.8%


✅ import_many_cached

Time: ✅ 121.114µs (SLO: <130.000µs -6.8%) vs baseline: +0.4%

Memory: ✅ 41.419MB (SLO: <46.000MB -10.0%) vs baseline: +5.8%


✅ import_many_stdlib

Time: ✅ 0.800ms (SLO: <1.750ms 📉 -54.3%) vs baseline: +0.3%

Memory: ✅ 41.586MB (SLO: <46.000MB -9.6%) vs baseline: +6.0%


⚠️ import_many_stdlib_cached

Time: ⚠️ 0.187ms (SLO: <1.100ms 📉 -83.0%) vs baseline: -0.2%

Memory: ✅ 41.323MB (SLO: <46.000MB 📉 -10.2%) vs baseline: +5.0%


✅ import_many_unknown

Time: ✅ 837.479µs (SLO: <890.000µs -5.9%) vs baseline: +0.9%

Memory: ✅ 41.459MB (SLO: <46.000MB -9.9%) vs baseline: +4.9%


✅ import_many_unknown_cached

Time: ✅ 798.418µs (SLO: <870.000µs -8.2%) vs baseline: +0.5%

Memory: ✅ 41.801MB (SLO: <46.000MB -9.1%) vs baseline: +6.6%


✅ import_one

Time: ✅ 19.902µs (SLO: <30.000µs 📉 -33.7%) vs baseline: +0.1%

Memory: ✅ 41.925MB (SLO: <46.000MB -8.9%) vs baseline: +6.9%


✅ import_one_cache

Time: ✅ 6.317µs (SLO: <10.000µs 📉 -36.8%) vs baseline: +0.2%

Memory: ✅ 41.622MB (SLO: <46.000MB -9.5%) vs baseline: +5.9%


✅ import_one_stdlib

Time: ✅ 18.881µs (SLO: <20.000µs -5.6%) vs baseline: +1.1%

Memory: ✅ 41.599MB (SLO: <46.000MB -9.6%) vs baseline: +5.5%


✅ import_one_stdlib_cache

Time: ✅ 6.365µs (SLO: <10.000µs 📉 -36.3%) vs baseline: +1.4%

Memory: ✅ 41.325MB (SLO: <46.000MB 📉 -10.2%) vs baseline: +6.0%


✅ import_one_unknown

Time: ✅ 45.566µs (SLO: <50.000µs -8.9%) vs baseline: +0.2%

Memory: ✅ 41.522MB (SLO: <46.000MB -9.7%) vs baseline: +6.0%


✅ import_one_unknown_cache

Time: ✅ 6.339µs (SLO: <10.000µs 📉 -36.6%) vs baseline: +1.2%

Memory: ✅ 41.259MB (SLO: <43.000MB -4.0%) vs baseline: +5.6%

✅ All Tests Passing (17 suites)
codeprovenancefork - 2/2

✅ fork-10

Time: ✅ 2.183s (SLO: <2.300s -5.1%) vs baseline: +2.9%

Memory: ✅ 17.439MB (SLO: <20.000MB 📉 -12.8%) vs baseline: +5.3%


errortrackingdjangosimple - 6/6

✅ errortracking-enabled-all

Time: ✅ 16.465ms (SLO: <19.850ms 📉 -17.1%) vs baseline: -0.4%

Memory: ✅ 68.852MB (SLO: <75.000MB -8.2%) vs baseline: +4.9%


✅ errortracking-enabled-user

Time: ✅ 16.516ms (SLO: <19.400ms 📉 -14.9%) vs baseline: +0.1%

Memory: ✅ 68.872MB (SLO: <75.000MB -8.2%) vs baseline: +4.9%


✅ tracer-enabled

Time: ✅ 16.534ms (SLO: <19.450ms 📉 -15.0%) vs baseline: +0.1%

Memory: ✅ 68.831MB (SLO: <75.000MB -8.2%) vs baseline: +4.8%


errortrackingflasksqli - 6/6

✅ errortracking-enabled-all

Time: ✅ 2.119ms (SLO: <2.300ms -7.9%) vs baseline: -0.5%

Memory: ✅ 56.393MB (SLO: <60.000MB -6.0%) vs baseline: +4.8%


✅ errortracking-enabled-user

Time: ✅ 2.130ms (SLO: <2.250ms -5.3%) vs baseline: -0.2%

Memory: ✅ 56.460MB (SLO: <60.000MB -5.9%) vs baseline: +5.0%


✅ tracer-enabled

Time: ✅ 2.128ms (SLO: <2.300ms -7.5%) vs baseline: ~same

Memory: ✅ 56.221MB (SLO: <60.000MB -6.3%) vs baseline: +5.1%


flasksimple - 18/18

✅ appsec-get

Time: ✅ 3.424ms (SLO: <4.750ms 📉 -27.9%) vs baseline: +0.4%

Memory: ✅ 56.570MB (SLO: <66.500MB 📉 -14.9%) vs baseline: +4.8%


✅ appsec-post

Time: ✅ 2.904ms (SLO: <6.750ms 📉 -57.0%) vs baseline: +0.2%

Memory: ✅ 56.529MB (SLO: <66.500MB 📉 -15.0%) vs baseline: +4.8%


✅ appsec-telemetry

Time: ✅ 3.411ms (SLO: <4.750ms 📉 -28.2%) vs baseline: +0.2%

Memory: ✅ 56.551MB (SLO: <66.500MB 📉 -15.0%) vs baseline: +4.8%


✅ debugger

Time: ✅ 1.880ms (SLO: <2.000ms -6.0%) vs baseline: -0.1%

Memory: ✅ 49.353MB (SLO: <51.500MB -4.2%) vs baseline: +4.8%


✅ iast-get

Time: ✅ 1.873ms (SLO: <2.000ms -6.4%) vs baseline: ~same

Memory: ✅ 45.991MB (SLO: <49.000MB -6.1%) vs baseline: +4.8%


✅ profiler

Time: ✅ 1.907ms (SLO: <2.100ms -9.2%) vs baseline: -0.6%

Memory: ✅ 52.145MB (SLO: <53.500MB -2.5%) vs baseline: +5.0%


✅ resource-renaming

Time: ✅ 3.387ms (SLO: <3.650ms -7.2%) vs baseline: ~same

Memory: ✅ 56.594MB (SLO: <60.000MB -5.7%) vs baseline: +5.0%


✅ tracer

Time: ✅ 3.397ms (SLO: <3.650ms -6.9%) vs baseline: -0.3%

Memory: ✅ 56.549MB (SLO: <60.000MB -5.8%) vs baseline: +4.8%


✅ tracer-native

Time: ✅ 3.401ms (SLO: <3.650ms -6.8%) vs baseline: +0.2%

Memory: ✅ 56.549MB (SLO: <60.000MB -5.8%) vs baseline: +4.9%


flasksqli - 6/6

✅ appsec-enabled

Time: ✅ 2.121ms (SLO: <4.200ms 📉 -49.5%) vs baseline: +0.4%

Memory: ✅ 56.336MB (SLO: <66.000MB 📉 -14.6%) vs baseline: +4.9%


✅ iast-enabled

Time: ✅ 2.134ms (SLO: <2.800ms 📉 -23.8%) vs baseline: +0.5%

Memory: ✅ 56.403MB (SLO: <62.500MB -9.8%) vs baseline: +5.1%


✅ tracer-enabled

Time: ✅ 2.120ms (SLO: <2.250ms -5.8%) vs baseline: +0.2%

Memory: ✅ 56.296MB (SLO: <60.000MB -6.2%) vs baseline: +4.8%


forktime - 4/4

✅ baseline

Time: ✅ 1.931ms (SLO: <3.000ms 📉 -35.6%) vs baseline: +2.5%

Memory: ✅ 29.334MB (SLO: <33.000MB 📉 -11.1%) vs baseline: +5.0%


✅ configured

Time: ✅ 10.187ms (SLO: <13.000ms 📉 -21.6%) vs baseline: +0.4%

Memory: ✅ 56.452MB (SLO: <60.000MB -5.9%) vs baseline: +4.9%


httppropagationextract - 60/60

✅ all_styles_all_headers

Time: ✅ 80.622µs (SLO: <100.000µs 📉 -19.4%) vs baseline: +4.7%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +4.8%


✅ b3_headers

Time: ✅ 12.890µs (SLO: <20.000µs 📉 -35.5%) vs baseline: +0.7%

Memory: ✅ 36.196MB (SLO: <38.000MB -4.7%) vs baseline: +4.7%


✅ b3_single_headers

Time: ✅ 11.938µs (SLO: <20.000µs 📉 -40.3%) vs baseline: -0.4%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +4.7%


✅ datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

Time: ✅ 60.450µs (SLO: <80.000µs 📉 -24.4%) vs baseline: +0.2%

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +4.6%


✅ datadog_tracecontext_tracestate_propagated_on_trace_id_match

Time: ✅ 63.659µs (SLO: <80.000µs 📉 -20.4%) vs baseline: ~same

Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +5.0%


✅ empty_headers

Time: ✅ 1.296µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +0.4%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +4.9%


✅ full_t_id_datadog_headers

Time: ✅ 21.700µs (SLO: <30.000µs 📉 -27.7%) vs baseline: +0.3%

Memory: ✅ 36.313MB (SLO: <38.000MB -4.4%) vs baseline: +4.7%


✅ invalid_priority_header

Time: ✅ 5.869µs (SLO: <10.000µs 📉 -41.3%) vs baseline: -0.3%

Memory: ✅ 36.176MB (SLO: <38.000MB -4.8%) vs baseline: +4.7%


✅ invalid_span_id_header

Time: ✅ 5.894µs (SLO: <10.000µs 📉 -41.1%) vs baseline: +0.1%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +4.9%


✅ invalid_tags_header

Time: ✅ 5.923µs (SLO: <10.000µs 📉 -40.8%) vs baseline: +0.2%

Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +5.0%


✅ invalid_trace_id_header

Time: ✅ 5.904µs (SLO: <10.000µs 📉 -41.0%) vs baseline: -0.4%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +4.9%


✅ large_header_no_matches

Time: ✅ 27.127µs (SLO: <30.000µs -9.6%) vs baseline: ~same

Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +5.0%


✅ large_valid_headers_all

Time: ✅ 28.385µs (SLO: <40.000µs 📉 -29.0%) vs baseline: +0.4%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +4.8%


✅ medium_header_no_matches

Time: ✅ 9.370µs (SLO: <20.000µs 📉 -53.2%) vs baseline: +0.9%

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +4.9%


✅ medium_valid_headers_all

Time: ✅ 10.741µs (SLO: <20.000µs 📉 -46.3%) vs baseline: -0.5%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +4.6%


✅ none_propagation_style

Time: ✅ 1.385µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +0.4%

Memory: ✅ 36.353MB (SLO: <38.000MB -4.3%) vs baseline: +5.1%


✅ tracecontext_headers

Time: ✅ 32.672µs (SLO: <40.000µs 📉 -18.3%) vs baseline: ~same

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +4.6%


✅ valid_headers_all

Time: ✅ 5.897µs (SLO: <10.000µs 📉 -41.0%) vs baseline: -0.1%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +5.0%


✅ valid_headers_basic

Time: ✅ 5.470µs (SLO: <10.000µs 📉 -45.3%) vs baseline: -0.3%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +4.5%


✅ wsgi_empty_headers

Time: ✅ 1.297µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +0.3%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +4.7%


✅ wsgi_invalid_priority_header

Time: ✅ 5.993µs (SLO: <10.000µs 📉 -40.1%) vs baseline: +1.0%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +4.9%


✅ wsgi_invalid_span_id_header

Time: ✅ 1.299µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +0.7%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +4.9%


✅ wsgi_invalid_tags_header

Time: ✅ 5.949µs (SLO: <10.000µs 📉 -40.5%) vs baseline: +0.3%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +5.0%


✅ wsgi_invalid_trace_id_header

Time: ✅ 6.014µs (SLO: <10.000µs 📉 -39.9%) vs baseline: +0.7%

Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +5.0%


✅ wsgi_large_header_no_matches

Time: ✅ 28.718µs (SLO: <40.000µs 📉 -28.2%) vs baseline: +0.9%

Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +4.9%


✅ wsgi_large_valid_headers_all

Time: ✅ 29.711µs (SLO: <40.000µs 📉 -25.7%) vs baseline: +0.4%

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +4.9%


✅ wsgi_medium_header_no_matches

Time: ✅ 9.491µs (SLO: <20.000µs 📉 -52.5%) vs baseline: +0.3%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +4.9%


✅ wsgi_medium_valid_headers_all

Time: ✅ 11.087µs (SLO: <20.000µs 📉 -44.6%) vs baseline: +1.4%

Memory: ✅ 36.333MB (SLO: <38.000MB -4.4%) vs baseline: +5.0%


✅ wsgi_valid_headers_all

Time: ✅ 5.943µs (SLO: <10.000µs 📉 -40.6%) vs baseline: +0.2%

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +4.6%


✅ wsgi_valid_headers_basic

Time: ✅ 5.507µs (SLO: <10.000µs 📉 -44.9%) vs baseline: +0.5%

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +4.7%


httppropagationinject - 15/15

✅ ids_only

Time: ✅ 20.898µs (SLO: <30.000µs 📉 -30.3%) vs baseline: +4.2%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +4.8%


✅ with_all

Time: ✅ 27.086µs (SLO: <40.000µs 📉 -32.3%) vs baseline: +1.0%

Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +5.0%


✅ with_dd_origin

Time: ✅ 23.841µs (SLO: <30.000µs 📉 -20.5%) vs baseline: +0.5%

Memory: ✅ 36.372MB (SLO: <38.000MB -4.3%) vs baseline: +5.2%


✅ with_priority_and_origin

Time: ✅ 23.441µs (SLO: <40.000µs 📉 -41.4%) vs baseline: +1.0%

Memory: ✅ 36.196MB (SLO: <38.000MB -4.7%) vs baseline: +4.7%


✅ with_sampling_priority

Time: ✅ 20.141µs (SLO: <30.000µs 📉 -32.9%) vs baseline: +0.5%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +4.9%


✅ with_tags

Time: ✅ 25.078µs (SLO: <40.000µs 📉 -37.3%) vs baseline: -0.8%


✅ with_tags_invalid

Time: ✅ 26.703µs (SLO: <40.000µs 📉 -33.2%) vs baseline: +0.8%

Memory: ✅ 36.313MB (SLO: <38.000MB -4.4%) vs baseline: +4.9%


✅ with_tags_max_size

Time: ✅ 25.481µs (SLO: <40.000µs 📉 -36.3%) vs baseline: -0.5%

Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +4.9%


iastaspectssplit - 12/12

✅ rsplit_aspect

Time: ✅ 164.841µs (SLO: <250.000µs 📉 -34.1%) vs baseline: +7.4%

Memory: ✅ 43.757MB (SLO: <46.000MB -4.9%) vs baseline: +5.0%


✅ rsplit_noaspect

Time: ✅ 158.869µs (SLO: <250.000µs 📉 -36.5%) vs baseline: +0.6%

Memory: ✅ 43.882MB (SLO: <46.000MB -4.6%) vs baseline: +5.1%


✅ split_aspect

Time: ✅ 153.820µs (SLO: <250.000µs 📉 -38.5%) vs baseline: +0.9%

Memory: ✅ 43.858MB (SLO: <46.000MB -4.7%) vs baseline: +4.8%


✅ split_noaspect

Time: ✅ 158.789µs (SLO: <250.000µs 📉 -36.5%) vs baseline: -0.3%

Memory: ✅ 43.810MB (SLO: <46.000MB -4.8%) vs baseline: +4.9%


✅ splitlines_aspect

Time: ✅ 152.486µs (SLO: <250.000µs 📉 -39.0%) vs baseline: +0.7%

Memory: ✅ 43.916MB (SLO: <46.000MB -4.5%) vs baseline: +4.6%


✅ splitlines_noaspect

Time: ✅ 157.971µs (SLO: <250.000µs 📉 -36.8%) vs baseline: +0.5%

Memory: ✅ 43.823MB (SLO: <46.000MB -4.7%) vs baseline: +4.9%


iastpropagation - 8/8

✅ no-propagation

Time: ✅ 48.002µs (SLO: <60.000µs 📉 -20.0%) vs baseline: -1.0%

Memory: ✅ 40.088MB (SLO: <42.000MB -4.6%) vs baseline: +5.1%


✅ propagation_enabled

Time: ✅ 136.791µs (SLO: <190.000µs 📉 -28.0%) vs baseline: -0.2%

Memory: ✅ 40.069MB (SLO: <42.000MB -4.6%) vs baseline: +5.1%


✅ propagation_enabled_100

Time: ✅ 1.580ms (SLO: <2.300ms 📉 -31.3%) vs baseline: +0.4%

Memory: ✅ 39.892MB (SLO: <42.000MB -5.0%) vs baseline: +4.5%


✅ propagation_enabled_1000

Time: ✅ 29.162ms (SLO: <34.550ms 📉 -15.6%) vs baseline: -0.3%

Memory: ✅ 40.029MB (SLO: <42.000MB -4.7%) vs baseline: +4.9%


otelsdkspan - 24/24

✅ add-event

Time: ✅ 40.909ms (SLO: <42.000ms -2.6%) vs baseline: -0.2%

Memory: ✅ 39.046MB (SLO: <40.750MB -4.2%) vs baseline: +5.1%


✅ add-link

Time: ✅ 36.826ms (SLO: <38.550ms -4.5%) vs baseline: +1.1%

Memory: ✅ 39.046MB (SLO: <40.750MB -4.2%) vs baseline: +4.9%


✅ add-metrics

Time: ✅ 220.237ms (SLO: <232.000ms -5.1%) vs baseline: -0.7%

Memory: ✅ 39.007MB (SLO: <40.750MB -4.3%) vs baseline: +5.1%


✅ add-tags

Time: ✅ 213.092ms (SLO: <221.600ms -3.8%) vs baseline: +0.8%

Memory: ✅ 39.086MB (SLO: <40.750MB -4.1%) vs baseline: +5.2%


✅ get-context

Time: ✅ 29.187ms (SLO: <31.300ms -6.8%) vs baseline: +0.2%

Memory: ✅ 38.574MB (SLO: <40.750MB -5.3%) vs baseline: +4.5%


✅ is-recording

Time: ✅ 29.197ms (SLO: <31.000ms -5.8%) vs baseline: +0.5%

Memory: ✅ 38.692MB (SLO: <40.750MB -5.0%) vs baseline: +4.8%


✅ record-exception

Time: ✅ 63.843ms (SLO: <65.850ms -3.0%) vs baseline: +0.3%

Memory: ✅ 39.145MB (SLO: <40.750MB -3.9%) vs baseline: +5.3%


✅ set-status

Time: ✅ 31.954ms (SLO: <34.150ms -6.4%) vs baseline: -0.7%

Memory: ✅ 39.046MB (SLO: <40.750MB -4.2%) vs baseline: +5.1%


✅ start

Time: ✅ 29.423ms (SLO: <30.150ms -2.4%) vs baseline: +1.5%

Memory: ✅ 38.791MB (SLO: <40.750MB -4.8%) vs baseline: +5.1%


✅ start-finish

Time: ✅ 34.103ms (SLO: <35.350ms -3.5%) vs baseline: ~same

Memory: ✅ 39.066MB (SLO: <40.750MB -4.1%) vs baseline: +5.1%


✅ start-finish-telemetry

Time: ✅ 34.266ms (SLO: <35.450ms -3.3%) vs baseline: +0.1%

Memory: ✅ 38.987MB (SLO: <40.750MB -4.3%) vs baseline: +4.8%


✅ update-name

Time: ✅ 31.305ms (SLO: <33.400ms -6.3%) vs baseline: +0.1%

Memory: ✅ 38.889MB (SLO: <40.750MB -4.6%) vs baseline: +5.0%


packagespackageforrootmodulemapping - 4/4

✅ cache_off

Time: ✅ 344.427ms (SLO: <354.300ms -2.8%) vs baseline: ~same

Memory: ✅ 42.215MB (SLO: <46.000MB -8.2%) vs baseline: +4.7%


✅ cache_on

Time: ✅ 0.392µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +1.6%

Memory: ✅ 41.263MB (SLO: <46.000MB 📉 -10.3%) vs baseline: +5.0%


rand - 2/2

✅ rand128bits

Time: ✅ 0.182µs (SLO: <21.000µs 📉 -99.1%) vs baseline: +0.5%


✅ rand64bits

Time: ✅ 0.122µs (SLO: <15.000µs 📉 -99.2%) vs baseline: -0.8%


ratelimiter - 12/12

✅ defaults

Time: ✅ 2.352µs (SLO: <10.000µs 📉 -76.5%) vs baseline: +0.3%

Memory: ✅ 36.530MB (SLO: <38.000MB -3.9%) vs baseline: +4.9%


✅ high_rate_limit

Time: ✅ 2.412µs (SLO: <10.000µs 📉 -75.9%) vs baseline: -0.4%

Memory: ✅ 36.549MB (SLO: <38.000MB -3.8%) vs baseline: +5.2%


✅ long_window

Time: ✅ 2.374µs (SLO: <10.000µs 📉 -76.3%) vs baseline: +1.0%

Memory: ✅ 36.530MB (SLO: <38.000MB -3.9%) vs baseline: +4.9%


✅ low_rate_limit

Time: ✅ 2.352µs (SLO: <10.000µs 📉 -76.5%) vs baseline: -0.4%

Memory: ✅ 36.510MB (SLO: <38.000MB -3.9%) vs baseline: +4.8%


✅ no_rate_limit

Time: ✅ 0.830µs (SLO: <10.000µs 📉 -91.7%) vs baseline: ~same

Memory: ✅ 36.549MB (SLO: <38.000MB -3.8%)


✅ short_window

Time: ✅ 2.479µs (SLO: <10.000µs 📉 -75.2%) vs baseline: -0.5%

Memory: ✅ 36.549MB (SLO: <38.000MB -3.8%)


samplingrules - 8/8

✅ average_match

Time: ✅ 169.546µs (SLO: <290.000µs 📉 -41.5%) vs baseline: +0.2%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +5.1%


✅ high_match

Time: ✅ 216.227µs (SLO: <480.000µs 📉 -55.0%) vs baseline: -0.1%

Memory: ✅ 36.176MB (SLO: <38.000MB -4.8%) vs baseline: +4.8%


✅ low_match

Time: ✅ 120.024µs (SLO: <120.000µs ~same) vs baseline: ~same

Memory: ✅ 701.633MB (SLO: <780.000MB 📉 -10.0%) vs baseline: +4.9%


✅ very_low_match

Time: ✅ 3.102ms (SLO: <8.500ms 📉 -63.5%) vs baseline: -0.3%

Memory: ✅ 78.709MB (SLO: <85.000MB -7.4%) vs baseline: +5.0%


sethttpmeta - 32/32

✅ all-disabled

Time: ✅ 10.578µs (SLO: <20.000µs 📉 -47.1%) vs baseline: -0.3%

Memory: ✅ 37.061MB (SLO: <38.750MB -4.4%) vs baseline: +4.9%


✅ all-enabled

Time: ✅ 39.793µs (SLO: <50.000µs 📉 -20.4%) vs baseline: +1.9%

Memory: ✅ 36.982MB (SLO: <38.750MB -4.6%) vs baseline: +4.9%


✅ collectipvariant_exists

Time: ✅ 39.905µs (SLO: <50.000µs 📉 -20.2%) vs baseline: -0.2%

Memory: ✅ 37.080MB (SLO: <38.750MB -4.3%) vs baseline: +4.9%


✅ no-collectipvariant

Time: ✅ 39.038µs (SLO: <50.000µs 📉 -21.9%) vs baseline: -0.3%

Memory: ✅ 37.021MB (SLO: <38.750MB -4.5%) vs baseline: +4.9%


✅ no-useragentvariant

Time: ✅ 37.737µs (SLO: <50.000µs 📉 -24.5%) vs baseline: -0.4%

Memory: ✅ 37.100MB (SLO: <38.750MB -4.3%) vs baseline: +5.2%


✅ obfuscation-no-query

Time: ✅ 39.719µs (SLO: <50.000µs 📉 -20.6%) vs baseline: +0.1%

Memory: ✅ 37.080MB (SLO: <38.750MB -4.3%) vs baseline: +4.9%


✅ obfuscation-regular-case-explicit-query

Time: ✅ 76.056µs (SLO: <90.000µs 📉 -15.5%) vs baseline: +0.3%

Memory: ✅ 37.552MB (SLO: <38.750MB -3.1%) vs baseline: +5.2%


✅ obfuscation-regular-case-implicit-query

Time: ✅ 76.414µs (SLO: <90.000µs 📉 -15.1%) vs baseline: -0.4%

Memory: ✅ 37.473MB (SLO: <38.750MB -3.3%) vs baseline: +5.0%


✅ obfuscation-send-querystring-disabled

Time: ✅ 154.442µs (SLO: <170.000µs -9.2%) vs baseline: ~same

Memory: ✅ 37.532MB (SLO: <38.750MB -3.1%) vs baseline: +5.0%


✅ obfuscation-worst-case-explicit-query

Time: ✅ 149.082µs (SLO: <160.000µs -6.8%) vs baseline: ~same

Memory: ✅ 37.454MB (SLO: <38.750MB -3.3%) vs baseline: +4.7%


✅ obfuscation-worst-case-implicit-query

Time: ✅ 155.191µs (SLO: <170.000µs -8.7%) vs baseline: ~same

Memory: ✅ 37.552MB (SLO: <38.750MB -3.1%) vs baseline: +5.2%


✅ useragentvariant_exists_1

Time: ✅ 38.488µs (SLO: <50.000µs 📉 -23.0%) vs baseline: -0.3%

Memory: ✅ 36.962MB (SLO: <38.750MB -4.6%) vs baseline: +4.5%


✅ useragentvariant_exists_2

Time: ✅ 39.383µs (SLO: <50.000µs 📉 -21.2%) vs baseline: -0.7%

Memory: ✅ 37.100MB (SLO: <38.750MB -4.3%) vs baseline: +4.6%


✅ useragentvariant_exists_3

Time: ✅ 38.916µs (SLO: <50.000µs 📉 -22.2%) vs baseline: -0.9%

Memory: ✅ 37.021MB (SLO: <38.750MB -4.5%) vs baseline: +4.6%


✅ useragentvariant_not_exists_1

Time: ✅ 38.713µs (SLO: <50.000µs 📉 -22.6%) vs baseline: +0.2%

Memory: ✅ 37.120MB (SLO: <38.750MB -4.2%) vs baseline: +5.3%


✅ useragentvariant_not_exists_2

Time: ✅ 38.393µs (SLO: <50.000µs 📉 -23.2%) vs baseline: -0.8%

Memory: ✅ 37.021MB (SLO: <38.750MB -4.5%) vs baseline: +4.5%


telemetryaddmetric - 30/30

✅ 1-count-metric-1-times

Time: ✅ 2.324µs (SLO: <20.000µs 📉 -88.4%) vs baseline: +9.6%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +4.8%


✅ 1-count-metrics-100-times

Time: ✅ 153.574µs (SLO: <220.000µs 📉 -30.2%) vs baseline: -1.2%

Memory: ✅ 36.255MB (SLO: <38.000MB -4.6%) vs baseline: +4.9%


✅ 1-distribution-metric-1-times

Time: ✅ 2.395µs (SLO: <20.000µs 📉 -88.0%) vs baseline: -0.2%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +4.7%


✅ 1-distribution-metrics-100-times

Time: ✅ 163.383µs (SLO: <230.000µs 📉 -29.0%) vs baseline: -0.2%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +4.9%


✅ 1-gauge-metric-1-times

Time: ✅ 1.968µs (SLO: <20.000µs 📉 -90.2%) vs baseline: ~same

Memory: ✅ 36.196MB (SLO: <38.000MB -4.7%) vs baseline: +4.7%


✅ 1-gauge-metrics-100-times

Time: ✅ 136.125µs (SLO: <150.000µs -9.2%) vs baseline: -0.3%

Memory: ✅ 36.196MB (SLO: <38.000MB -4.7%) vs baseline: +4.7%


✅ 1-rate-metric-1-times

Time: ✅ 2.256µs (SLO: <20.000µs 📉 -88.7%) vs baseline: +0.2%

Memory: ✅ 36.196MB (SLO: <38.000MB -4.7%) vs baseline: +4.8%


✅ 1-rate-metrics-100-times

Time: ✅ 168.666µs (SLO: <250.000µs 📉 -32.5%) vs baseline: -0.1%

Memory: ✅ 36.215MB (SLO: <38.000MB -4.7%) vs baseline: +4.7%


✅ 100-count-metrics-100-times

Time: ✅ 15.602ms (SLO: <22.000ms 📉 -29.1%) vs baseline: +0.8%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +4.8%


✅ 100-distribution-metrics-100-times

Time: ✅ 1.727ms (SLO: <2.550ms 📉 -32.3%) vs baseline: +0.5%

Memory: ✅ 36.235MB (SLO: <38.000MB -4.6%) vs baseline: +4.8%


✅ 100-gauge-metrics-100-times

Time: ✅ 1.402ms (SLO: <1.550ms -9.6%) vs baseline: ~same

Memory: ✅ 36.274MB (SLO: <38.000MB -4.5%) vs baseline: +5.1%


✅ 100-rate-metrics-100-times

Time: ✅ 1.734ms (SLO: <2.550ms 📉 -32.0%) vs baseline: -0.4%

Memory: ✅ 36.294MB (SLO: <38.000MB -4.5%) vs baseline: +5.0%


✅ flush-1-metric

Time: ✅ 3.591µs (SLO: <20.000µs 📉 -82.0%) vs baseline: ~same

Memory: ✅ 36.667MB (SLO: <38.000MB -3.5%) vs baseline: +5.1%


✅ flush-100-metrics

Time: ✅ 175.347µs (SLO: <250.000µs 📉 -29.9%) vs baseline: +0.8%

Memory: ✅ 36.628MB (SLO: <38.000MB -3.6%) vs baseline: +4.8%


✅ flush-1000-metrics

Time: ✅ 2.194ms (SLO: <2.500ms 📉 -12.2%) vs baseline: ~same

Memory: ✅ 37.061MB (SLO: <38.750MB -4.4%) vs baseline: +4.9%

ℹ️ Scenarios Missing SLO Configuration (46 scenarios)

The following scenarios exist in candidate data but have no SLO thresholds configured:

  • coreapiscenario-core_dispatch_listeners
  • coreapiscenario-core_dispatch_no_listeners
  • coreapiscenario-core_dispatch_with_results_listeners
  • coreapiscenario-core_dispatch_with_results_no_listeners
  • djangosimple-baseline
  • errortrackingdjangosimple-baseline
  • errortrackingflasksqli-baseline
  • flasksimple-baseline
  • flasksqli-baseline
  • iast_aspects-re_expand_aspect
  • iast_aspects-re_expand_noaspect
  • iast_aspects-re_findall_aspect
  • iast_aspects-re_findall_noaspect
  • iast_aspects-re_finditer_aspect
  • iast_aspects-re_finditer_noaspect
  • iast_aspects-re_fullmatch_aspect
  • iast_aspects-re_fullmatch_noaspect
  • iast_aspects-re_group_aspect
  • iast_aspects-re_group_noaspect
  • iast_aspects-re_groups_aspect
  • iast_aspects-re_groups_noaspect
  • iast_aspects-re_match_aspect
  • iast_aspects-re_match_noaspect
  • iast_aspects-re_search_aspect
  • iast_aspects-re_search_noaspect
  • iast_aspects-re_sub_aspect
  • iast_aspects-re_sub_noaspect
  • iast_aspects-re_subn_aspect
  • iast_aspects-re_subn_noaspect
  • sethttpmeta-obfuscation-disabled
  • startup-baseline
  • startup-baseline_django
  • startup-baseline_flask
  • startup-ddtrace_run
  • startup-ddtrace_run_appsec
  • startup-ddtrace_run_profiling
  • startup-ddtrace_run_runtime_metrics
  • startup-ddtrace_run_send_span
  • startup-ddtrace_run_telemetry_disabled
  • startup-ddtrace_run_telemetry_enabled
  • startup-import_ddtrace
  • startup-import_ddtrace_auto
  • startup-import_ddtrace_auto_django
  • startup-import_ddtrace_auto_flask
  • startup-import_ddtrace_django
  • startup-import_ddtrace_flask

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Apr 9, 2026

Copy link
Copy Markdown

Codeowners resolved as

ddtrace/internal/datadog/profiling/dd_wrapper/include/profile.hpp       @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/profile.cpp           @DataDog/profiling-python
ddtrace/internal/datadog/profiling/dd_wrapper/src/profiler_state.cpp    @DataDog/profiling-python
ddtrace/internal/datadog/profiling/stack/src/sampler.cpp                @DataDog/profiling-python

@KowalskiThomas

Copy link
Copy Markdown
Contributor Author

@codex review this, make sure you pay extra attention to how locking and their allocations work around forks!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d082021d3e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@KowalskiThomas

Copy link
Copy Markdown
Contributor Author

@codex review again

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 151527e6e2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ddtrace/internal/datadog/profiling/dd_wrapper/src/profile.cpp Outdated
@KowalskiThomas

Copy link
Copy Markdown
Contributor Author

@codex review again!

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

https://datadoghq.atlassian.net/browse/PROF-13112

This fixes a rare segmentation fault that could occur when a profiled application forks.

```
```

The root cause of this crash seems to be unfortunate timing on fork. What happened was that, due to ordering of fork handlers, `stack`'s post-fork hook would run _before_ `dd_wrapper`'s. On multi-core systems where we got unlucky, because `stack`'s post-fork hook would restart the Sampling Thread, this meant the Sampling Thread could start before `dd_wrapper`'s post-fork hook had completed (or even before it had started).
As a result, `dd_wrapper` would (try to) reset the `Profile` object that the Sampling Thread was writing to through the `Sample` APIs, resulting in a race and all kinds of fun memory issues, such as this crash.
Note that the other way around could also happen, where the Sampling Thread could try to write to the `Profile` object that had already been dropped/freed by `dd_wrapper`.

AFAIK, other Profilers shouldn't be impacted as they run in the Main Thread, so I think the risk that they may be writing to the Profile before it's ready post-fork is effectively inexistent.

As far as I can tell, there is no risk in registering that post-fork hook at library load time, instead of when the Stack Profiler is started. What `stack_atfork_child` is calling `stack_postfork_cleanup`, which we already did at library load time [meaning it's safe to do even when the Profiler doesn't run], then calling `Sampler::restart_after_fork`, which only restarts the Profiler if it was running pre-fork (which in an app that does not use the Profiler is a no-op).

Co-authored-by: thomas.kowalski <thomas.kowalski@datadoghq.com>
@KowalskiThomas KowalskiThomas force-pushed the kowalski/fix-profiling-ensure-correct-order-of-profiler-post-fork-hooks-17183 branch 3 times, most recently from 3720018 to 1abb880 Compare April 15, 2026 14:46
@KowalskiThomas KowalskiThomas added the Profiling Continous Profling label Apr 15, 2026
@KowalskiThomas

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@KowalskiThomas KowalskiThomas marked this pull request as ready for review April 15, 2026 14:53
@KowalskiThomas KowalskiThomas requested a review from a team as a code owner April 15, 2026 14:53

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1abb880dbf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ddtrace/internal/datadog/profiling/stack/src/sampler.cpp Outdated
@KowalskiThomas KowalskiThomas marked this pull request as draft April 15, 2026 15:06
@KowalskiThomas

Copy link
Copy Markdown
Contributor Author

@codex review

@KowalskiThomas KowalskiThomas force-pushed the kowalski/fix-profiling-ensure-correct-order-of-profiler-post-fork-hooks-17183 branch from 1abb880 to cb9159b Compare April 15, 2026 15:26
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@KowalskiThomas KowalskiThomas marked this pull request as ready for review April 15, 2026 17:58

@r1viollet r1viollet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm
this looks strictly better, though overall difficult to reason about

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit b0bcf1b into main Apr 17, 2026
427 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the kowalski/fix-profiling-ensure-correct-order-of-profiler-post-fork-hooks-17183 branch April 17, 2026 13:43
dubloom pushed a commit that referenced this pull request Apr 21, 2026
…17418)

## Description

This reverts commit 10f1503 / #17417 and reapplies #17183. See original PR for more info and context. 

On top of the previous PR, it adds fork handlers so that we lock `profile_mtx` pre-fork and unlock it post-fork (after making sure the `ProfilerState` is in a clean state). Doing this allows to avoid cases where the Sampling Thread would try to use corrupt/inconsistent `ProfilerState` data post-fork. 

Co-authored-by: thomas.kowalski <thomas.kowalski@datadoghq.com>
emmettbutler pushed a commit that referenced this pull request May 6, 2026
…17418)

## Description

This reverts commit 10f1503 / #17417 and reapplies #17183. See original PR for more info and context. 

On top of the previous PR, it adds fork handlers so that we lock `profile_mtx` pre-fork and unlock it post-fork (after making sure the `ProfilerState` is in a clean state). Doing this allows to avoid cases where the Sampling Thread would try to use corrupt/inconsistent `ProfilerState` data post-fork. 

Co-authored-by: thomas.kowalski <thomas.kowalski@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants