chore(profiling): revert ensure correct order of profiler post-fork hooks#17417
Merged
juanjux merged 1 commit intoApr 9, 2026
Merged
Conversation
This reverts commit 10f1503.
2452139 to
a931bc9
Compare
Codeowners resolved as |
juanjux
approved these changes
Apr 9, 2026
This comment has been minimized.
This comment has been minimized.
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
that referenced
this pull request
Apr 17, 2026
…17418) ## Description This reverts commit 10f1503 / #17417 and reapplies #17183. See original PR for more info and context. On top of the previous PR, it adds fork handlers so that we lock `profile_mtx` pre-fork and unlock it post-fork (after making sure the `ProfilerState` is in a clean state). Doing this allows to avoid cases where the Sampling Thread would try to use corrupt/inconsistent `ProfilerState` data post-fork. Co-authored-by: thomas.kowalski <thomas.kowalski@datadoghq.com>
dubloom
pushed a commit
that referenced
this pull request
Apr 21, 2026
…17418) ## Description This reverts commit 10f1503 / #17417 and reapplies #17183. See original PR for more info and context. On top of the previous PR, it adds fork handlers so that we lock `profile_mtx` pre-fork and unlock it post-fork (after making sure the `ProfilerState` is in a clean state). Doing this allows to avoid cases where the Sampling Thread would try to use corrupt/inconsistent `ProfilerState` data post-fork. Co-authored-by: thomas.kowalski <thomas.kowalski@datadoghq.com>
emmettbutler
pushed a commit
that referenced
this pull request
May 6, 2026
…17418) ## Description This reverts commit 10f1503 / #17417 and reapplies #17183. See original PR for more info and context. On top of the previous PR, it adds fork handlers so that we lock `profile_mtx` pre-fork and unlock it post-fork (after making sure the `ProfilerState` is in a clean state). Doing this allows to avoid cases where the Sampling Thread would try to use corrupt/inconsistent `ProfilerState` data post-fork. Co-authored-by: thomas.kowalski <thomas.kowalski@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
This reverts #17183 which seems to have been causing a lot of flakiness in system tests (and crashes there).