Skip to content

bump libdatadog version to v25#7971

Merged
vandonr merged 2 commits intomasterfrom
vandonr/bump
Dec 18, 2025
Merged

bump libdatadog version to v25#7971
vandonr merged 2 commits intomasterfrom
vandonr/bump

Conversation

@vandonr
Copy link
Contributor

@vandonr vandonr commented Dec 18, 2025

Summary of changes

just a bump, I need this new version to pass process tags with profiles.
I just pass null for now (it's an optional field), I'll pass the tags in #7715 once this is merged, to make it easier to detect issues if any.

Reason for change

Implementation details

Test coverage

Other details

https://github.com/DataDog/libdatadog/releases/tag/v25.0.0

@vandonr vandonr requested review from a team as code owners December 18, 2025 09:37
gleocadie
gleocadie approved these changes Dec 18, 2025
View reviewed changes
Copy link
Collaborator

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Dec 18, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7971) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration73.36 ± (73.42 - 73.73) ms68.30 ± (68.31 - 68.49) ms-6.9%✅
.NET Framework 4.8 - Bailout
duration77.44 ± (77.33 - 77.67) ms72.05 ± (72.02 - 72.22) ms-7.0%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1043.73 ± (1051.54 - 1062.40) ms1002.63 ± (1003.94 - 1009.08) ms-3.9%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms22.52 ± (22.47 - 22.57) ms21.93 ± (21.89 - 21.96) ms-2.6%✅
process.time_to_main_ms83.69 ± (83.49 - 83.89) ms78.48 ± (78.34 - 78.63) ms-6.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.89 ± (10.89 - 10.89) MB10.91 ± (10.90 - 10.92) MB+0.2%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.48 ± (22.44 - 22.52) ms21.79 ± (21.77 - 21.81) ms-3.1%✅
process.time_to_main_ms85.60 ± (85.40 - 85.80) ms79.42 ± (79.32 - 79.52) ms-7.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.94 ± (10.93 - 10.94) MB10.93 ± (10.93 - 10.94) MB-0.1%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms219.85 ± (218.54 - 221.16) ms211.52 ± (209.67 - 213.36) ms-3.8%✅
process.time_to_main_ms492.73 ± (491.98 - 493.49) ms470.30 ± (469.78 - 470.83) ms-4.6%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed47.99 ± (47.96 - 48.01) MB48.12 ± (48.09 - 48.14) MB+0.3%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅
.NET 6 - Baseline
process.internal_duration_ms21.39 ± (21.36 - 21.43) ms20.70 ± (20.68 - 20.72) ms-3.2%✅
process.time_to_main_ms73.31 ± (73.14 - 73.49) ms68.23 ± (68.08 - 68.38) ms-6.9%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.61 ± (10.60 - 10.61) MB10.63 ± (10.62 - 10.63) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.31 ± (21.28 - 21.35) ms20.78 ± (20.69 - 20.88) ms-2.5%✅
process.time_to_main_ms74.28 ± (74.11 - 74.45) ms69.47 ± (69.20 - 69.74) ms-6.5%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.66 ± (10.65 - 10.66) MB10.67 ± (10.66 - 10.67) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms206.90 ± (205.89 - 207.91) ms198.54 ± (197.51 - 199.56) ms-4.0%✅
process.time_to_main_ms457.80 ± (457.07 - 458.53) ms440.35 ± (439.79 - 440.90) ms-3.8%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.45 ± (48.42 - 48.48) MB48.19 ± (48.13 - 48.26) MB-0.5%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms19.60 ± (19.57 - 19.63) ms18.81 ± (18.78 - 18.84) ms-4.0%✅
process.time_to_main_ms72.40 ± (72.27 - 72.54) ms67.05 ± (66.94 - 67.16) ms-7.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.67 ± (7.67 - 7.68) MB7.66 ± (7.65 - 7.67) MB-0.2%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.57 ± (19.52 - 19.62) ms18.82 ± (18.79 - 18.85) ms-3.8%✅
process.time_to_main_ms73.84 ± (73.67 - 74.00) ms68.30 ± (68.23 - 68.37) ms-7.5%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.73 ± (7.72 - 7.74) MB7.70 ± (7.70 - 7.71) MB-0.3%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms187.34 ± (186.55 - 188.13) ms180.17 ± (179.13 - 181.22) ms-3.8%✅
process.time_to_main_ms441.84 ± (441.19 - 442.49) ms423.70 ± (423.15 - 424.26) ms-4.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.35 ± (36.32 - 36.39) MB36.26 ± (36.23 - 36.30) MB-0.2%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.1%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration193.21 ± (193.02 - 193.76) ms193.12 ± (193.26 - 194.14) ms-0.0%✅
.NET Framework 4.8 - Bailout
duration197.35 ± (197.23 - 197.83) ms197.05 ± (196.89 - 197.51) ms-0.2%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1110.24 ± (1112.17 - 1120.23) ms1113.83 ± (1115.01 - 1121.83) ms+0.3%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms187.72 ± (187.36 - 188.08) ms189.56 ± (189.10 - 190.03) ms+1.0%✅⬆️
process.time_to_main_ms80.57 ± (80.34 - 80.80) ms81.40 ± (81.13 - 81.68) ms+1.0%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.11 ± (16.08 - 16.14) MB16.14 ± (16.11 - 16.16) MB+0.2%✅⬆️
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (19 - 20)-0.1%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms187.02 ± (186.72 - 187.31) ms187.21 ± (186.96 - 187.47) ms+0.1%✅⬆️
process.time_to_main_ms81.74 ± (81.59 - 81.89) ms82.05 ± (81.92 - 82.19) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.13 ± (16.11 - 16.16) MB16.22 ± (16.19 - 16.25) MB+0.6%✅⬆️
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (21 - 21)+0.3%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms395.67 ± (393.09 - 398.24) ms397.04 ± (394.31 - 399.78) ms+0.3%✅⬆️
process.time_to_main_ms476.54 ± (475.78 - 477.31) ms476.94 ± (476.12 - 477.75) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.35 ± (58.19 - 58.50) MB58.33 ± (58.18 - 58.48) MB-0.0%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.1%✅
.NET 6 - Baseline
process.internal_duration_ms192.47 ± (192.09 - 192.84) ms195.39 ± (195.02 - 195.76) ms+1.5%✅⬆️
process.time_to_main_ms70.07 ± (69.86 - 70.28) ms72.47 ± (72.23 - 72.70) ms+3.4%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed15.93 ± (15.77 - 16.09) MB16.38 ± (16.36 - 16.40) MB+2.8%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)19 ± (19 - 19)+4.0%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms190.99 ± (190.65 - 191.33) ms194.11 ± (193.66 - 194.56) ms+1.6%✅⬆️
process.time_to_main_ms70.61 ± (70.52 - 70.70) ms72.52 ± (72.30 - 72.73) ms+2.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed15.98 ± (15.82 - 16.13) MB16.44 ± (16.42 - 16.47) MB+2.9%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)20 ± (20 - 20)+4.8%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms408.83 ± (406.32 - 411.34) ms413.55 ± (410.69 - 416.41) ms+1.2%✅⬆️
process.time_to_main_ms444.75 ± (444.16 - 445.34) ms446.93 ± (446.23 - 447.63) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed58.79 ± (58.64 - 58.94) MB58.83 ± (58.68 - 58.97) MB+0.1%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms190.47 ± (190.08 - 190.86) ms190.66 ± (190.20 - 191.12) ms+0.1%✅⬆️
process.time_to_main_ms69.30 ± (69.12 - 69.48) ms69.82 ± (69.65 - 69.99) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.73 ± (11.70 - 11.75) MB11.75 ± (11.72 - 11.78) MB+0.2%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.1%✅
.NET 8 - Bailout
process.internal_duration_ms188.79 ± (188.50 - 189.09) ms191.30 ± (190.91 - 191.68) ms+1.3%✅⬆️
process.time_to_main_ms70.23 ± (70.11 - 70.35) ms71.41 ± (71.24 - 71.58) ms+1.7%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.78 ± (11.75 - 11.81) MB11.80 ± (11.77 - 11.84) MB+0.2%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-0.1%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms360.05 ± (358.30 - 361.80) ms363.91 ± (362.67 - 365.15) ms+1.1%✅⬆️
process.time_to_main_ms426.78 ± (426.05 - 427.51) ms429.44 ± (428.74 - 430.15) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed47.90 ± (47.87 - 47.93) MB47.95 ± (47.93 - 47.97) MB+0.1%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.1%✅
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7971) - mean (68ms)  : 67, 70
    master - mean (74ms)  : 71, 76

    section Bailout
    This PR (7971) - mean (72ms)  : 71, 73
    master - mean (77ms)  : 76, 79

    section CallTarget+Inlining+NGEN
    This PR (7971) - mean (1,007ms)  : 970, 1043
    master - mean (1,057ms)  : 976, 1138
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7971) - mean (106ms)  : 103, 108
    master - mean (113ms)  : 110, 116

    section Bailout
    This PR (7971) - mean (106ms)  : 105, 107
    master - mean (115ms)  : 112, 118

    section CallTarget+Inlining+NGEN
    This PR (7971) - mean (710ms)  : 670, 749
    master - mean (745ms)  : 710, 780
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7971) - mean (94ms)  : 91, 96
    master - mean (101ms)  : 98, 104

    section Bailout
    This PR (7971) - mean (95ms)  : 89, 100
    master - mean (102ms)  : 100, 104

    section CallTarget+Inlining+NGEN
    This PR (7971) - mean (666ms)  : 643, 688
    master - mean (691ms)  : 667, 715
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7971) - mean (92ms)  : 90, 94
    master - mean (100ms)  : 97, 103

    section Bailout
    This PR (7971) - mean (93ms)  : 92, 95
    master - mean (101ms)  : 99, 103

    section CallTarget+Inlining+NGEN
    This PR (7971) - mean (632ms)  : 618, 647
    master - mean (660ms)  : 636, 683
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7971) - mean (194ms)  : 189, 198
    master - mean (193ms)  : 190, 197

    section Bailout
    This PR (7971) - mean (197ms)  : 194, 200
    master - mean (198ms)  : 195, 200

    section CallTarget+Inlining+NGEN
    This PR (7971) - mean (1,118ms)  : 1069, 1168
    master - mean (1,116ms)  : 1058, 1174
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7971) - mean (279ms)  : 273, 286
    master - mean (277ms)  : 272, 281

    section Bailout
    This PR (7971) - mean (277ms)  : 274, 281
    master - mean (277ms)  : 273, 282

    section CallTarget+Inlining+NGEN
    This PR (7971) - mean (917ms)  : 873, 961
    master - mean (905ms)  : 866, 945
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7971) - mean (277ms)  : 271, 283
    master - mean (271ms)  : 265, 276

    section Bailout
    This PR (7971) - mean (275ms)  : 263, 287
    master - mean (270ms)  : 265, 275

    section CallTarget+Inlining+NGEN
    This PR (7971) - mean (897ms)  : 846, 948
    master - mean (888ms)  : 847, 928
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7971) - mean (270ms)  : 263, 278
    master - mean (270ms)  : 260, 280

    section Bailout
    This PR (7971) - mean (272ms)  : 265, 279
    master - mean (268ms)  : 264, 272

    section CallTarget+Inlining+NGEN
    This PR (7971) - mean (824ms)  : 793, 855
    master - mean (819ms)  : 797, 842
Loading

@pr-commenter
Copy link

pr-commenter bot commented Dec 18, 2025

Benchmarks

Benchmark execution time: 2025-12-18 11:18:53

Comparing candidate commit 3f023f7 in PR branch vandonr/bump with baseline commit 0e61a90 in branch master.

Found 6 performance improvements and 3 performance regressions! Performance is the same for 159 metrics, 18 unstable metrics.

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟩 execution_time [-24.504ms; -18.217ms] or [-11.435%; -8.501%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net472

  • 🟩 throughput [+175003.679op/s; +176628.739op/s] or [+5.576%; +5.628%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

  • 🟩 execution_time [-23.324ms; -16.646ms] or [-10.273%; -7.332%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0

  • 🟩 execution_time [-20.933ms; -20.665ms] or [-10.492%; -10.358%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟥 execution_time [+59.847ms; +64.166ms] or [+35.763%; +38.344%]

scenario:Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery netcoreapp3.1

  • 🟩 throughput [+19802.429op/s; +28014.667op/s] or [+5.242%; +7.416%]

scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync netcoreapp3.1

  • 🟥 execution_time [+10.389ms; +15.593ms] or [+5.341%; +8.016%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟥 execution_time [+17.037ms; +22.591ms] or [+8.651%; +11.471%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

  • 🟩 execution_time [-16.260ms; -10.848ms] or [-7.744%; -5.166%]

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 18, 2025 •
edited by datadog-official bot
Loading

⚠️ Tests

✨ Fix all issues with Cursor

⚠️ Warnings

❄️ 1 New flaky test detected

DirectlyShipsLogs from Datadog.Trace.ClrProfiler.IntegrationTests.ILoggerExtendedLoggerTests (Datadog) (Fix with Cursor) 
Expected logs to contain only items matching (Convert(x.LogLevel, Int32) == 2), but 
{
    Datadog.Trace.TestHelpers.MockLogsIntake+Log
    {
        Env = "integration_tests", 
        EventId = "22", 
        Exception = <null>, 
        Host = "integration_ilogger_tests", 
        LogLevel = DirectSubmissionLogLevel.Warning {value: 3}, 
        Message = "As of "12/18/2025 11:12:31 +00:00", the heartbeat has been running for "00:00:02.4906110" which is longer than "00:00:01". This could be caused by thread pool starvation.", 
...

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3f023f7 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@vandonr vandonr merged commit 16675ff into master Dec 18, 2025
77 of 79 checks passed
@vandonr vandonr deleted the vandonr/bump branch December 18, 2025 13:07
@github-actions github-actions bot added this to the vNext-v3 milestone Dec 18, 2025
@andrewlock andrewlock added the libdatadog Updates to the libdatadog library and Rust integration label Dec 22, 2025
andrewlock added a commit that referenced this pull request Dec 22, 2025
@andrewlock
Revert "bump libdatadog version to v25 (#7971)"
1714920 
This reverts commit 16675ff.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gleocadie gleocadie gleocadie approved these changes

Assignees

No one assigned

Labels

libdatadog Updates to the libdatadog library and Rust integration

Projects

None yet

Milestone

3.34.0

Development

Successfully merging this pull request may close these issues.

3 participants

@vandonr @gleocadie @andrewlock