Conversation
BenchmarksBenchmark execution time: 2026-01-06 11:30:09 Comparing candidate commit b0ef6ed in PR branch Found 5 performance improvements and 8 performance regressions! Performance is the same for 158 metrics, 15 unstable metrics. scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0
scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool netcoreapp3.1
scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1
scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1
scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0
|
59c4d11 to
4c74919
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7715) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7715) - mean (70ms) : 66, 74
master - mean (68ms) : 67, 70
section Bailout
This PR (7715) - mean (73ms) : 71, 75
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (7715) - mean (1,016ms) : 964, 1068
master - mean (1,008ms) : 968, 1048
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7715) - mean (107ms) : 104, 109
master - mean (106ms) : 104, 108
section Bailout
This PR (7715) - mean (107ms) : 106, 109
master - mean (107ms) : 106, 108
section CallTarget+Inlining+NGEN
This PR (7715) - mean (743ms) : 681, 805
master - mean (731ms) : 669, 793
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7715) - mean (94ms) : 92, 97
master - mean (93ms) : 91, 96
section Bailout
This PR (7715) - mean (95ms) : 94, 96
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (7715) - mean (715ms) : 674, 756
master - mean (713ms) : 682, 744
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7715) - mean (93ms) : 90, 95
master - mean (92ms) : 90, 94
section Bailout
This PR (7715) - mean (94ms) : 93, 95
master - mean (93ms) : 92, 94
section CallTarget+Inlining+NGEN
This PR (7715) - mean (640ms) : 620, 659
master - mean (630ms) : 618, 643
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7715) - mean (196ms) : 191, 201
master - mean (193ms) : 189, 198
section Bailout
This PR (7715) - mean (200ms) : 194, 206
master - mean (197ms) : 194, 199
section CallTarget+Inlining+NGEN
This PR (7715) - mean (1,126ms) : 1066, 1185
master - mean (1,112ms) : 1061, 1164
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7715) - mean (280ms) : 274, 287
master - mean (277ms) : 272, 282
section Bailout
This PR (7715) - mean (280ms) : 277, 284
master - mean (277ms) : 273, 282
section CallTarget+Inlining+NGEN
This PR (7715) - mean (934ms) : 893, 976
master - mean (918ms) : 871, 966
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7715) - mean (276ms) : 265, 288
master - mean (270ms) : 264, 275
section Bailout
This PR (7715) - mean (277ms) : 267, 287
master - mean (270ms) : 266, 274
section CallTarget+Inlining+NGEN
This PR (7715) - mean (926ms) : 862, 990
master - mean (926ms) : 889, 963
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7715) - mean (274ms) : 264, 285
master - mean (270ms) : 265, 275
section Bailout
This PR (7715) - mean (275ms) : 266, 283
master - mean (270ms) : 266, 273
section CallTarget+Inlining+NGEN
This PR (7715) - mean (838ms) : 804, 871
master - mean (829ms) : 799, 860
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This comment has been minimized.
This comment has been minimized.
vandonr
commented
Nov 19, 2025
cda70d2 to
51b8a5f
Compare
wantsui
reviewed
Nov 19, 2025
profiler/test/Datadog.Profiler.IntegrationTests/ProcessTagsTest.cs
Outdated
Show resolved
Hide resolved
e453aaf to
a5a1ba3
Compare
Contributor
Author
|
putting it back in draft because I just saw with Gregory that we need to put the tag in a dedicated field that requires a change in libdatadog, an issue that java and go didn't have. |
vandonr
added a commit
that referenced
this pull request
Dec 18, 2025
## Summary of changes just a bump, I need this new version to pass process tags with profiles. I just pass null for now (it's an optional field), I'll pass the tags in #7715 once this is merged, to make it easier to detect issues if any. ## Reason for change ## Implementation details ## Test coverage ## Other details <!-- Fixes #{issue} --> https://github.com/DataDog/libdatadog/releases/tag/v25.0.0 <!--⚠️ Note: Where possible, please obtain 2 approvals prior to merging. Unless CODEOWNERS specifies otherwise, for external teams it is typically best to have one review from a team member, and one review from apm-dotnet. Trivial changes do not require 2 reviews. MergeQueue is NOT enabled in this repository. If you have write access to the repo, the PR has 1-2 approvals (see above), and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #apm-dotnet channel in Slack. -->
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Write process tags to profiles
Reason for change
OLDAIDM-701
AIDM-195
Implementation details
Most of the C++ code is AI generated, fed with PR #4298
Test coverage
Other details