Make the Instrumentation.cs file owned by everyone#7416
Merged
andrewlock merged 1 commit intomasterfrom Aug 19, 2025
Merged
Conversation
bouwkast
approved these changes
Aug 19, 2025
zacharycmontoya
approved these changes
Aug 19, 2025
andrewlock
added a commit
that referenced
this pull request
Aug 19, 2025
## Summary of changes Try to fix dynamic instrumentation tests ## Reason for change The debugger tests are broken in master because #7398 didn't trigger the debugger tests to run ## Implementation details Add the log message it expects ## Test coverage Will trigger a dedicated test run to make sure we test the debugger ## Other details We should probably update the `Instrumentation` file to be co-owned, to make sure this kind of thing doesn't happen again - #7416
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Make the
Instrumentation.csfile owned by everyoneReason for change
#7398 was a change to debugger initialization, but it didn't run the debugger tests because the Instrumentation.cs file wasn't owned by them. So had to run them manually in #7415.
Implementation details
Add all the teams to be Instrumentation.cs owners, because it can impact all products
Test coverage
N/A
Other details