Try to fix dynamic instrumentation tests#7415
Merged
andrewlock merged 1 commit intomasterfrom Aug 19, 2025
Merged
Conversation
bouwkast
approved these changes
Aug 19, 2025
|
andrewlock
added a commit
that referenced
this pull request
Aug 19, 2025
## Summary of changes Make the `Instrumentation.cs` file owned by everyone ## Reason for change #7398 was a change to debugger initialization, but it didn't run the debugger tests because the Instrumentation.cs file wasn't owned by them. So had to run them manually in #7415. ## Implementation details Add all the teams to be Instrumentation.cs owners, because it can impact all products ## Test coverage N/A ## Other details <!-- Fixes #{issue} --> <!--⚠️ Note: Where possible, please obtain 2 approvals prior to merging. Unless CODEOWNERS specifies otherwise, for external teams it is typically best to have one review from a team member, and one review from apm-dotnet. Trivial changes do not require 2 reviews. MergeQueue is NOT enabled in this repository. If you have write access to the repo, the PR has 1-2 approvals (see above), and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #apm-dotnet channel in Slack. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Try to fix dynamic instrumentation tests
Reason for change
The debugger tests are broken in master because #7398 didn't trigger the debugger tests to run
Implementation details
Add the log message it expects
Test coverage
Will trigger a dedicated test run to make sure we test the debugger
Other details
We should probably update the
Instrumentationfile to be co-owned, to make sure this kind of thing doesn't happen againInstrumentation.csfile owned by everyone #7416