Skip to content

enable baggage propagator by default#6258

Merged
lucaspimentel merged 6 commits intomasterfrom
lpimentel/baggage-default-config
Nov 8, 2024
Merged

enable baggage propagator by default#6258
lucaspimentel merged 6 commits intomasterfrom
lpimentel/baggage-default-config

Conversation

@lucaspimentel
Copy link
Member

@lucaspimentel lucaspimentel commented Nov 7, 2024 •
edited
Loading

Summary of changes

Missed from #6158 😅

  • Add baggage to the default list of propagators.

Reason for change

Adding support for OpenTelemetry baggage.

Implementation details

Add "baggage" to the default list of propagators in DD_TRACE_PROPAGATION_STYLE.

Test coverage

Fixed all failing tests after the change, including

  • tests for default config values
  • telemetry tests

bonus:

  • added a propagator test where baggage header is no present
  • fixed an unrelated test that threw an exception on missing headers

Other details

Follow-up from #6158.

@lucaspimentel Graphite App
Copy link
Member Author

lucaspimentel commented Nov 7, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lucaspimentel and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Nov 7, 2024
@lucaspimentel lucaspimentel marked this pull request as ready for review November 7, 2024 22:06
@lucaspimentel lucaspimentel requested a review from a team as a code owner November 7, 2024 22:06
@lucaspimentel lucaspimentel mentioned this pull request Nov 7, 2024
Merged
@andrewlock
Copy link
Member

andrewlock commented Nov 7, 2024 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6258) - mean (69ms)  : 68, 71
     .   : milestone, 69,
    master - mean (70ms)  : 68, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6258) - mean (1,112ms)  : 1088, 1136
     .   : milestone, 1112,
    master - mean (1,109ms)  : 1089, 1130
     .   : milestone, 1109,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6258) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (108ms)  : 106, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6258) - mean (775ms)  : 765, 785
     .   : milestone, 775,
    master - mean (774ms)  : 761, 787
     .   : milestone, 774,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6258) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6258) - mean (731ms)  : 714, 748
     .   : milestone, 731,
    master - mean (731ms)  : 714, 749
     .   : milestone, 731,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6258) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (190ms)  : 187, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6258) - mean (1,222ms)  : 1198, 1246
     .   : milestone, 1222,
    master - mean (1,221ms)  : 1196, 1245
     .   : milestone, 1221,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6258) - mean (276ms)  : 273, 280
     .   : milestone, 276,
    master - mean (276ms)  : 271, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6258) - mean (954ms)  : 928, 979
     .   : milestone, 954,
    master - mean (949ms)  : 929, 970
     .   : milestone, 949,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6258) - mean (264ms)  : 260, 269
     .   : milestone, 264,
    master - mean (264ms)  : 261, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6258) - mean (933ms)  : 915, 951
     .   : milestone, 933,
    master - mean (937ms)  : 912, 962
     .   : milestone, 937,
Loading

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 7, 2024 •
edited
Loading

Datadog Report

Branch report: lpimentel/baggage-default-config
Commit report: 9b4c1f1
Test service: dd-trace-dotnet

✅ 0 Failed, 367718 Passed, 2077 Skipped, 14h 50m 8.14s Total Time

@andrewlock
Copy link
Member

andrewlock commented Nov 8, 2024 •
edited
Loading

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6258) (11.114M)   : 0, 11113592
    master (10.997M)   : 0, 10996753
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6258) (7.221M)   : 0, 7221439
    master (7.329M)   : 0, 7329017
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.585M)   : 0, 7585394

    section Manual
    master (11.125M)   : 0, 11125496

    section Manual + Automatic
    This PR (6258) (6.618M)   : 0, 6617986
    master (6.809M)   : 0, 6808876

    section DD_TRACE_ENABLED=0
    master (10.150M)   : 0, 10150367
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6258) (9.682M)   : 0, 9682306
    master (9.707M)   : 0, 9707388
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6258) (6.428M)   : 0, 6427746
    master (6.476M)   : 0, 6475612

    section Trace stats
    master (6.777M)   : 0, 6777106

    section Manual
    master (9.734M)   : 0, 9734034

    section Manual + Automatic
    This PR (6258) (6.114M)   : 0, 6113804
    master (6.059M)   : 0, 6058944

    section DD_TRACE_ENABLED=0
    master (8.813M)   : 0, 8813139
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6258) (10.021M)   : 0, 10021488
    master (9.993M)   : 0, 9992615
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6258) (6.540M)   : 0, 6539873
    master (6.458M)   : 0, 6457816
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.238M)   : 0, 7237969

    section Manual
    master (9.898M)   : 0, 9898436

    section Manual + Automatic
    This PR (6258) (6.001M)   : 0, 6001382
    master (5.998M)   : 0, 5998172

    section DD_TRACE_ENABLED=0
    master (9.390M)   : 0, 9390453
Loading

@andrewlock
Copy link
Member

andrewlock commented Nov 8, 2024 •
edited
Loading

Benchmarks Report for tracer 🐌

Benchmarks for #6258 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.168
  • 1 benchmarks are slower, with geometric mean 1.131
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.96μs 34.7ns 130ns 0.0197 0.00788 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.2μs 49.2ns 197ns 0.0219 0.011 0 5.79 KB
master StartStopWithChild net472 16.5μs 63.7ns 247ns 1.05 0.31 0.0921 6.21 KB
#6258 StartStopWithChild net6.0 7.8μs 44.1ns 303ns 0.0154 0.0077 0 5.61 KB
#6258 StartStopWithChild netcoreapp3.1 10.2μs 55.4ns 293ns 0.0192 0.00961 0 5.8 KB
#6258 StartStopWithChild net472 16.3μs 42.4ns 164ns 1.03 0.29 0.0967 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 480μs 666ns 2.58μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 639μs 539ns 2.09μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 840μs 596ns 2.31μs 0.419 0 0 3.3 KB
#6258 WriteAndFlushEnrichedTraces net6.0 491μs 1.36μs 5.1μs 0 0 0 2.7 KB
#6258 WriteAndFlushEnrichedTraces netcoreapp3.1 633μs 254ns 984ns 0 0 0 2.7 KB
#6258 WriteAndFlushEnrichedTraces net472 841μs 757ns 2.93μs 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 202μs 1.19μs 11.7μs 0.202 0 0 18.73 KB
master SendRequest netcoreapp3.1 222μs 1.28μs 11.3μs 0.224 0 0 20.89 KB
master SendRequest net472 0.00103ns 0.000386ns 0.0015ns 0 0 0 0 b
#6258 SendRequest net6.0 194μs 969ns 4.22μs 0.202 0 0 18.73 KB
#6258 SendRequest netcoreapp3.1 219μs 1.25μs 9.41μs 0.21 0 0 20.89 KB
#6258 SendRequest net472 0.000243ns 0.000158ns 0.000592ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 576μs 2.71μs 14.6μs 0.581 0 0 41.64 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 690μs 3.63μs 18.1μs 0.34 0 0 41.86 KB
master WriteAndFlushEnrichedTraces net472 843μs 3.46μs 13.4μs 8.28 2.48 0.414 53.28 KB
#6258 WriteAndFlushEnrichedTraces net6.0 552μs 2.7μs 13.2μs 0.556 0 0 41.44 KB
#6258 WriteAndFlushEnrichedTraces netcoreapp3.1 690μs 2.05μs 7.68μs 0.345 0 0 41.8 KB
#6258 WriteAndFlushEnrichedTraces net472 886μs 3.09μs 11.6μs 8.36 2.64 0.44 53.33 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.21μs 0.601ns 2.33ns 0.0145 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.78μs 1.84ns 7.12ns 0.0134 0 0 1.02 KB
master ExecuteNonQuery net472 2.08μs 2.54ns 9.83ns 0.156 0.00104 0 987 B
#6258 ExecuteNonQuery net6.0 1.29μs 0.91ns 3.41ns 0.0142 0 0 1.02 KB
#6258 ExecuteNonQuery netcoreapp3.1 1.74μs 1.47ns 5.68ns 0.0139 0 0 1.02 KB
#6258 ExecuteNonQuery net472 2.1μs 1.19ns 4.62ns 0.156 0.00105 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.2μs 0.805ns 3.01ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.59μs 1.3ns 5.04ns 0.0136 0 0 976 B
master CallElasticsearch net472 2.66μs 0.681ns 2.55ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.29μs 2.25ns 8.42ns 0.0134 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.79μs 0.628ns 2.43ns 0.0133 0 0 1.02 KB
master CallElasticsearchAsync net472 2.62μs 0.822ns 3.07ns 0.167 0 0 1.05 KB
#6258 CallElasticsearch net6.0 1.18μs 0.807ns 3.02ns 0.0136 0 0 976 B
#6258 CallElasticsearch netcoreapp3.1 1.55μs 0.694ns 2.69ns 0.0132 0 0 976 B
#6258 CallElasticsearch net472 2.53μs 1.67ns 6.48ns 0.158 0 0 995 B
#6258 CallElasticsearchAsync net6.0 1.38μs 0.56ns 2.17ns 0.0132 0 0 952 B
#6258 CallElasticsearchAsync netcoreapp3.1 1.68μs 0.694ns 2.6ns 0.0142 0 0 1.02 KB
#6258 CallElasticsearchAsync net472 2.57μs 0.735ns 2.65ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.23μs 0.557ns 2.16ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.69μs 0.727ns 2.82ns 0.0127 0 0 952 B
master ExecuteAsync net472 1.73μs 1.43ns 5.55ns 0.145 0 0 915 B
#6258 ExecuteAsync net6.0 1.24μs 0.671ns 2.33ns 0.0131 0 0 952 B
#6258 ExecuteAsync netcoreapp3.1 1.6μs 0.489ns 1.89ns 0.0128 0 0 952 B
#6258 ExecuteAsync net472 1.85μs 1ns 3.75ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.53μs 1.68ns 6.28ns 0.0331 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.31μs 2.64ns 10.2ns 0.0369 0 0 2.85 KB
master SendAsync net472 7.51μs 1.74ns 6.51ns 0.494 0 0 3.12 KB
#6258 SendAsync net6.0 4.32μs 2.41ns 9.01ns 0.0326 0 0 2.31 KB
#6258 SendAsync netcoreapp3.1 5.28μs 2.17ns 8.42ns 0.0373 0 0 2.85 KB
#6258 SendAsync net472 7.6μs 0.69ns 2.49ns 0.493 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.48μs 1.24ns 4.65ns 0.023 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.26μs 2.01ns 7.79ns 0.0217 0 0 1.64 KB
master EnrichedLog net472 2.62μs 0.921ns 3.44ns 0.249 0 0 1.57 KB
#6258 EnrichedLog net6.0 1.51μs 1.42ns 5.31ns 0.0228 0 0 1.64 KB
#6258 EnrichedLog netcoreapp3.1 2.09μs 0.783ns 2.93ns 0.0223 0 0 1.64 KB
#6258 EnrichedLog net472 2.68μs 0.884ns 3.31ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 117μs 72.5ns 261ns 0.059 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 122μs 253ns 979ns 0.0608 0 0 4.28 KB
master EnrichedLog net472 151μs 134ns 503ns 0.684 0.228 0 4.46 KB
#6258 EnrichedLog net6.0 119μs 149ns 577ns 0 0 0 4.28 KB
#6258 EnrichedLog netcoreapp3.1 123μs 122ns 457ns 0 0 0 4.28 KB
#6258 EnrichedLog net472 154μs 213ns 797ns 0.689 0.23 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.99μs 1.16ns 4.51ns 0.03 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.13μs 3.92ns 15.2ns 0.0288 0 0 2.2 KB
master EnrichedLog net472 4.72μs 1.44ns 5.56ns 0.319 0 0 2.02 KB
#6258 EnrichedLog net6.0 3.01μs 0.695ns 2.6ns 0.0301 0 0 2.2 KB
#6258 EnrichedLog netcoreapp3.1 4.15μs 1.7ns 6.36ns 0.029 0 0 2.2 KB
#6258 EnrichedLog net472 4.89μs 1.17ns 4.37ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.4μs 0.527ns 2.04ns 0.016 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.7μs 0.906ns 3.51ns 0.0156 0 0 1.14 KB
master SendReceive net472 2.16μs 0.914ns 3.54ns 0.183 0 0 1.16 KB
#6258 SendReceive net6.0 1.41μs 0.953ns 3.69ns 0.0161 0 0 1.14 KB
#6258 SendReceive netcoreapp3.1 1.75μs 1.07ns 4.14ns 0.0149 0 0 1.14 KB
#6258 SendReceive net472 2.14μs 0.709ns 2.55ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.77μs 7.93ns 30.7ns 0.0219 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.88μs 1.29ns 4.83ns 0.0213 0 0 1.65 KB
master EnrichedLog net472 4.41μs 2.54ns 9.5ns 0.323 0 0 2.04 KB
#6258 EnrichedLog net6.0 2.8μs 1.18ns 4.58ns 0.0223 0 0 1.6 KB
#6258 EnrichedLog netcoreapp3.1 3.8μs 1.11ns 4.29ns 0.0227 0 0 1.65 KB
#6258 EnrichedLog net472 4.35μs 1.4ns 5.44ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6258

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.131 573.45 648.74

Faster 🎉 in #6258

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.206 479.53 397.60 bimodal
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.131 781.10 690.46

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 482ns 2.58ns 13.9ns 0.00804 0 0 576 B
master StartFinishSpan netcoreapp3.1 573ns 0.61ns 2.36ns 0.008 0 0 576 B
master StartFinishSpan net472 776ns 0.219ns 0.848ns 0.0917 0 0 578 B
master StartFinishScope net6.0 544ns 0.244ns 0.946ns 0.00979 0 0 696 B
master StartFinishScope netcoreapp3.1 781ns 0.534ns 2.07ns 0.00959 0 0 696 B
master StartFinishScope net472 884ns 1.48ns 5.74ns 0.104 0 0 658 B
#6258 StartFinishSpan net6.0 397ns 0.268ns 1.04ns 0.00815 0 0 576 B
#6258 StartFinishSpan netcoreapp3.1 649ns 0.949ns 3.68ns 0.00775 0 0 576 B
#6258 StartFinishSpan net472 723ns 0.797ns 3.09ns 0.0917 0 0 578 B
#6258 StartFinishScope net6.0 507ns 0.325ns 1.22ns 0.00976 0 0 696 B
#6258 StartFinishScope netcoreapp3.1 691ns 0.636ns 2.29ns 0.00939 0 0 696 B
#6258 StartFinishScope net472 821ns 0.904ns 3.5ns 0.105 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 682ns 0.401ns 1.55ns 0.0099 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 937ns 0.436ns 1.69ns 0.00899 0 0 696 B
master RunOnMethodBegin net472 1.1μs 0.356ns 1.38ns 0.104 0 0 658 B
#6258 RunOnMethodBegin net6.0 618ns 0.386ns 1.44ns 0.00985 0 0 696 B
#6258 RunOnMethodBegin netcoreapp3.1 935ns 0.769ns 2.98ns 0.00899 0 0 696 B
#6258 RunOnMethodBegin net472 1.12μs 1.27ns 4.92ns 0.104 0 0 658 B

@lucaspimentel lucaspimentel force-pushed the lpimentel/baggage-default-config branch from 2d5f25e to f7a7862 Compare November 8, 2024 01:43
@lucaspimentel lucaspimentel force-pushed the lpimentel/baggage-default-config branch from f7a7862 to 9ee5013 Compare November 8, 2024 16:46
@lucaspimentel lucaspimentel force-pushed the lpimentel/baggage-default-config branch from 9ee5013 to 6f8057c Compare November 8, 2024 16:48
@lucaspimentel lucaspimentel changed the title add baggage to default propagators add baggage propagator to the default list of propagators Nov 8, 2024
@lucaspimentel lucaspimentel merged commit bc9c54d into master Nov 8, 2024
@lucaspimentel Graphite App
Copy link
Member Author

lucaspimentel commented Nov 8, 2024

Merge activity

  • Nov 8, 1:46 PM EST: A user merged this pull request with Graphite.

@lucaspimentel lucaspimentel deleted the lpimentel/baggage-default-config branch November 8, 2024 18:46
@github-actions github-actions bot added this to the vNext-v3 milestone Nov 8, 2024
@lucaspimentel lucaspimentel changed the title add baggage propagator to the default list of propagators enable baggage propagator by default Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes

@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

area:opentelemetry OpenTelemetry support area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) type:new-feature

Projects

None yet

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@lucaspimentel @andrewlock @zacharycmontoya