Baggage part 2/3: propagation by lucaspimentel · Pull Request #6158 · DataDog/dd-trace-dotnet

lucaspimentel · 2024-10-15T20:35:35Z

Summary of changes

Add a baggage propagator, and inject/extract baggage everywhere we already inject/extract trace context.

Reason for change

Adding support for OpenTelemetry baggage.

Implementation details

add W3CBaggagePropagator
- emit telemetry when injecting and extracting using header_style:baggage metric tag
add new "baggage" value for DD_TRACE_PROPAGATION_STYLE and friends, used by SpanContextPropagatorFactory
add new settings DD_TRACE_BAGGAGE_MAX_ITEMS and DD_TRACE_BAGGAGE_MAX_BYTES
- configuration telemetry is handled automatically
- add these names to config telemetry allow list (config_norm_rules.json)
- increment new telemetry metrics when these limits are reached

Test coverage

add test in SpanContextPropagatorFactoryTests for "baggage" ➡️ W3CBaggagePropagator
add W3CBaggagePropagatorTests with inject/extract tests

Other details

n/a

lucaspimentel · 2024-10-15T20:35:48Z

Baggage part 3/3: add public api to Datadog.Trace.Manual #6190
Baggage part 2/3: propagation #6158 👈
Baggage part 1/3: change propagator signatures #6157
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lucaspimentel and the rest of your teammates on Graphite

datadog-ddstaging · 2024-10-15T20:54:45Z

Datadog Report

Branch report: lpimentel/baggage-datadog-api-2
Commit report: 2a52921
Test service: dd-trace-dotnet

✅ 0 Failed, 369031 Passed, 2120 Skipped, 16h 21m 10.52s Total Time

andrewlock · 2024-10-18T21:06:56Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6158) - mean (69ms)  : 68, 71
     .   : milestone, 69,
    master - mean (70ms)  : 68, 71
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6158) - mean (1,112ms)  : 1092, 1132
     .   : milestone, 1112,
    master - mean (1,112ms)  : 1092, 1131
     .   : milestone, 1112,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6158) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (109ms)  : 107, 111
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6158) - mean (769ms)  : 752, 785
     .   : milestone, 769,
    master - mean (773ms)  : 763, 784
     .   : milestone, 773,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6158) - mean (91ms)  : 89, 94
     .   : milestone, 91,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6158) - mean (726ms)  : 708, 743
     .   : milestone, 726,
    master - mean (731ms)  : 713, 749
     .   : milestone, 731,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6158) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (190ms)  : 187, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6158) - mean (1,222ms)  : 1197, 1248
     .   : milestone, 1222,
    master - mean (1,222ms)  : 1199, 1246
     .   : milestone, 1222,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6158) - mean (276ms)  : 272, 281
     .   : milestone, 276,
    master - mean (277ms)  : 272, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6158) - mean (950ms)  : 932, 968
     .   : milestone, 950,
    master - mean (950ms)  : 929, 970
     .   : milestone, 950,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6158) - mean (264ms)  : 260, 268
     .   : milestone, 264,
    master - mean (265ms)  : 260, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6158) - mean (932ms)  : 915, 949
     .   : milestone, 932,
    master - mean (934ms)  : 910, 958
     .   : milestone, 934,

andrewlock · 2024-10-18T21:36:52Z

Benchmarks Report for tracer 🐌

Benchmarks for #6158 compared to master:

1 benchmarks are slower, with geometric mean 1.342
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.91μs	43.4ns	344ns	0.0156	0.00781	0	5.6 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	47.2ns	254ns	0.0204	0.0102	0	5.8 KB
master	`StartStopWithChild`	net472	16.5μs	66.3ns	257ns	1.03	0.299	0.0888	6.22 KB
#6158	`StartStopWithChild`	net6.0	7.89μs	44.1ns	296ns	0.0203	0.0081	0	5.61 KB
#6158	`StartStopWithChild`	netcoreapp3.1	10.1μs	54.2ns	302ns	0.0199	0.00993	0	5.8 KB
#6158	`StartStopWithChild`	net472	16.5μs	42.4ns	164ns	1.06	0.328	0.0903	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	484μs	206ns	770ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	641μs	302ns	1.13μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	838μs	615ns	2.38μs	0.417	3.3 KB
#6158	`WriteAndFlushEnrichedTraces`	net6.0	484μs	293ns	1.14μs	0	2.7 KB
#6158	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	636μs	584ns	2.26μs	0	2.7 KB
#6158	`WriteAndFlushEnrichedTraces`	net472	842μs	476ns	1.84μs	0.422	3.29 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	204μs	1.16μs	8.85μs	0.202	18.73 KB
master	`SendRequest`	netcoreapp3.1	225μs	1.29μs	10.7μs	0.222	20.89 KB
master	`SendRequest`	net472	0.000142ns	9.84E‑05ns	0.000355ns	0	0 b
#6158	`SendRequest`	net6.0	202μs	1.15μs	8.23μs	0.205	18.73 KB
#6158	`SendRequest`	netcoreapp3.1	222μs	1.24μs	8.06μs	0.226	20.89 KB
#6158	`SendRequest`	net472	0.00087ns	0.000473ns	0.00171ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	583μs	3.26μs	21.4μs	0.561	0	0	41.84 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	695μs	3.54μs	16.2μs	0.34	0	0	41.83 KB
master	`WriteAndFlushEnrichedTraces`	net472	886μs	4.42μs	20.7μs	8.48	2.23	0.446	53.29 KB
#6158	`WriteAndFlushEnrichedTraces`	net6.0	563μs	2.65μs	9.92μs	0.548	0	0	41.68 KB
#6158	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	687μs	2.68μs	12μs	0.34	0	0	41.72 KB
#6158	`WriteAndFlushEnrichedTraces`	net472	838μs	3.82μs	14.8μs	8.12	2.44	0.406	53.28 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.35μs	1.33ns	4.6ns	0.0145	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.88μs	1.81ns	7.01ns	0.0133	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.12μs	2.61ns	10.1ns	0.156	0.00106	987 B
#6158	`ExecuteNonQuery`	net6.0	1.39μs	1.5ns	5.82ns	0.014	0	1.02 KB
#6158	`ExecuteNonQuery`	netcoreapp3.1	1.79μs	1.23ns	4.6ns	0.0135	0	1.02 KB
#6158	`ExecuteNonQuery`	net472	2.08μs	1.55ns	5.79ns	0.157	0.00104	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.22μs	0.387ns	1.5ns	0.014	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.56μs	0.533ns	1.85ns	0.0132	976 B
master	`CallElasticsearch`	net472	2.49μs	0.974ns	3.51ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.24μs	0.783ns	3.03ns	0.0131	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.67μs	0.821ns	2.96ns	0.0133	1.02 KB
master	`CallElasticsearchAsync`	net472	2.59μs	0.649ns	2.43ns	0.167	1.05 KB
#6158	`CallElasticsearch`	net6.0	1.24μs	0.408ns	1.53ns	0.0137	976 B
#6158	`CallElasticsearch`	netcoreapp3.1	1.49μs	0.442ns	1.71ns	0.0133	976 B
#6158	`CallElasticsearch`	net472	2.55μs	0.493ns	1.71ns	0.158	995 B
#6158	`CallElasticsearchAsync`	net6.0	1.21μs	0.468ns	1.75ns	0.0133	952 B
#6158	`CallElasticsearchAsync`	netcoreapp3.1	1.68μs	1.12ns	4.03ns	0.0141	1.02 KB
#6158	`CallElasticsearchAsync`	net472	2.62μs	1.27ns	4.9ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.24μs	4.63ns	17.9ns	0.0133	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.61μs	1.33ns	4.97ns	0.0121	952 B
master	`ExecuteAsync`	net472	1.76μs	0.468ns	1.75ns	0.145	915 B
#6158	`ExecuteAsync`	net6.0	1.32μs	0.804ns	3.01ns	0.0133	952 B
#6158	`ExecuteAsync`	netcoreapp3.1	1.59μs	1.02ns	3.83ns	0.0128	952 B
#6158	`ExecuteAsync`	net472	1.8μs	0.463ns	1.79ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.35μs	2.27ns	8.79ns	0.0326	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.23μs	2.36ns	8.52ns	0.0366	2.85 KB
master	`SendAsync`	net472	7.43μs	2.13ns	8.26ns	0.493	3.12 KB
#6158	`SendAsync`	net6.0	4.39μs	2.94ns	11.4ns	0.0328	2.31 KB
#6158	`SendAsync`	netcoreapp3.1	5.29μs	1.19ns	4.59ns	0.037	2.85 KB
#6158	`SendAsync`	net472	7.79μs	1.78ns	6.91ns	0.494	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.43μs	1.43ns	5.36ns	0.0231	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.3μs	1.4ns	5.43ns	0.023	1.64 KB
master	`EnrichedLog`	net472	2.51μs	0.725ns	2.81ns	0.249	1.57 KB
#6158	`EnrichedLog`	net6.0	1.46μs	0.825ns	3.2ns	0.0227	1.64 KB
#6158	`EnrichedLog`	netcoreapp3.1	2.13μs	1.47ns	5.7ns	0.0222	1.64 KB
#6158	`EnrichedLog`	net472	2.42μs	1.33ns	5.14ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	118μs	266ns	1.03μs	0.0588	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	122μs	273ns	1.06μs	0.061	0	4.28 KB
master	`EnrichedLog`	net472	153μs	189ns	733ns	0.691	0.23	4.46 KB
#6158	`EnrichedLog`	net6.0	119μs	135ns	522ns	0.0587	0	4.28 KB
#6158	`EnrichedLog`	netcoreapp3.1	122μs	155ns	581ns	0	0	4.28 KB
#6158	`EnrichedLog`	net472	154μs	144ns	538ns	0.696	0.232	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.07μs	10.6ns	41.2ns	0.0306	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.09μs	1.12ns	4.34ns	0.0306	2.2 KB
master	`EnrichedLog`	net472	4.97μs	1.36ns	5.27ns	0.32	2.02 KB
#6158	`EnrichedLog`	net6.0	2.91μs	0.75ns	2.9ns	0.0305	2.2 KB
#6158	`EnrichedLog`	netcoreapp3.1	4.07μs	1.42ns	5.51ns	0.0286	2.2 KB
#6158	`EnrichedLog`	net472	4.88μs	1.53ns	5.92ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.41μs	1.49ns	5.76ns	0.0162	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.7μs	0.581ns	2.09ns	0.0153	1.14 KB
master	`SendReceive`	net472	2.07μs	1.37ns	5.29ns	0.183	1.16 KB
#6158	`SendReceive`	net6.0	1.5μs	0.66ns	2.47ns	0.0157	1.14 KB
#6158	`SendReceive`	netcoreapp3.1	1.81μs	0.662ns	2.48ns	0.0151	1.14 KB
#6158	`SendReceive`	net472	2.05μs	0.62ns	2.24ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.64μs	1.6ns	6ns	0.0224	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.97μs	1ns	3.75ns	0.0218	1.65 KB
master	`EnrichedLog`	net472	4.39μs	1.61ns	6.03ns	0.322	2.04 KB
#6158	`EnrichedLog`	net6.0	2.72μs	0.595ns	2.3ns	0.0218	1.6 KB
#6158	`EnrichedLog`	netcoreapp3.1	4.07μs	2.74ns	10.3ns	0.0224	1.65 KB
#6158	`EnrichedLog`	net472	4.29μs	2.89ns	11.2ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6158

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.342	402.38	539.89

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	403ns	0.218ns	0.843ns	0.00809	576 B
master	`StartFinishSpan`	netcoreapp3.1	546ns	0.322ns	1.25ns	0.00788	576 B
master	`StartFinishSpan`	net472	775ns	0.826ns	3.2ns	0.0918	578 B
master	`StartFinishScope`	net6.0	487ns	0.419ns	1.57ns	0.00976	696 B
master	`StartFinishScope`	netcoreapp3.1	704ns	0.852ns	3.3ns	0.00926	696 B
master	`StartFinishScope`	net472	898ns	1.22ns	4.73ns	0.104	658 B
#6158	`StartFinishSpan`	net6.0	540ns	0.195ns	0.757ns	0.0079	576 B
#6158	`StartFinishSpan`	netcoreapp3.1	574ns	0.558ns	2.16ns	0.00785	576 B
#6158	`StartFinishSpan`	net472	736ns	0.804ns	3.11ns	0.0917	578 B
#6158	`StartFinishScope`	net6.0	492ns	0.301ns	1.13ns	0.00987	696 B
#6158	`StartFinishScope`	netcoreapp3.1	667ns	0.926ns	3.59ns	0.00928	696 B
#6158	`StartFinishScope`	net472	878ns	0.68ns	2.64ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	593ns	0.508ns	1.97ns	0.00986	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	972ns	0.904ns	3.5ns	0.00947	696 B
master	`RunOnMethodBegin`	net472	1.17μs	1.3ns	5.02ns	0.104	658 B
#6158	`RunOnMethodBegin`	net6.0	610ns	0.702ns	2.72ns	0.00979	696 B
#6158	`RunOnMethodBegin`	netcoreapp3.1	902ns	0.713ns	2.67ns	0.00905	696 B
#6158	`RunOnMethodBegin`	net472	1.17μs	1.09ns	4.21ns	0.104	658 B

andrewlock · 2024-10-18T21:41:43Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6158) (11.190M)   : 0, 11190158
    master (11.131M)   : 0, 11130779
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6158) (7.271M)   : 0, 7271217
    master (7.310M)   : 0, 7310157
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.599M)   : 0, 7598556

    section Manual
    master (11.073M)   : 0, 11072548

    section Manual + Automatic
    This PR (6158) (6.737M)   : 0, 6737409
    master (6.775M)   : 0, 6775349

    section DD_TRACE_ENABLED=0
    master (10.251M)   : 0, 10251396

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6158) (9.634M)   : 0, 9634399
    master (9.713M)   : 0, 9712554
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6158) (6.356M)   : 0, 6355927
    master (6.514M)   : 0, 6513986

    section Trace stats
    master (6.710M)   : 0, 6710317

    section Manual
    master (9.670M)   : 0, 9669749

    section Manual + Automatic
    This PR (6158) (5.927M)   : 0, 5926961
    master (6.015M)   : 0, 6015065

    section DD_TRACE_ENABLED=0
    master (8.772M)   : 0, 8772254

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6158) (9.975M)   : 0, 9974890
    master (10.153M)   : 0, 10152752
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6158) (6.503M)   : 0, 6503265
    master (6.377M)   : 0, 6376641
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.126M)   : 0, 7126124

    section Manual
    master (10.105M)   : 0, 10104968

    section Manual + Automatic
    This PR (6158) (6.222M)   : 0, 6222391
    master (5.901M)   : 0, 5901347

    section DD_TRACE_ENABLED=0
    master (9.225M)   : 0, 9225046

lucaspimentel mentioned this pull request Oct 15, 2024

Baggage part 1/3: change propagator signatures #6157

Merged

lucaspimentel changed the title ~~add baggage to telemetry metric tags~~ Baggage, part 2/2 Oct 15, 2024

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-1 branch from 049b7ea to 33ab4e6 Compare October 15, 2024 22:27

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-2 branch 4 times, most recently from 481ba3f to c3c7e69 Compare October 15, 2024 23:42

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-1 branch 2 times, most recently from 85d9334 to 421d2ff Compare October 16, 2024 22:54

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-2 branch from c3c7e69 to 218e6a7 Compare October 16, 2024 22:54

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-1 branch from 421d2ff to c758827 Compare October 17, 2024 21:34

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-2 branch from 218e6a7 to 94afec5 Compare October 17, 2024 21:34

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-1 branch from c758827 to 26cde15 Compare October 18, 2024 19:36

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-2 branch from 94afec5 to 3f25685 Compare October 18, 2024 19:36

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-1 branch from 26cde15 to 3d56729 Compare October 18, 2024 20:34

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-2 branch from 3f25685 to b050a90 Compare October 18, 2024 20:35

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-1 branch from 3d56729 to be793d8 Compare October 18, 2024 21:40

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-1 branch from be793d8 to c2e67f9 Compare October 21, 2024 20:07

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-2 branch from b050a90 to 0b9cdb2 Compare October 21, 2024 20:07

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-1 branch from bf56863 to cdae7b7 Compare October 22, 2024 15:35

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-2 branch from 0b9cdb2 to f471d76 Compare October 22, 2024 15:36

lucaspimentel changed the title ~~Baggage, part 2/2~~ Baggage, part 2/2: implement propagation Oct 22, 2024

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-1 branch from cdae7b7 to b1144ee Compare October 22, 2024 20:56

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-2 branch from f471d76 to 1f82c57 Compare October 22, 2024 20:56

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-1 branch from b1144ee to 7c1cce4 Compare October 23, 2024 02:28

lucaspimentel added 27 commits November 7, 2024 10:27

add support for W3CBaggagePropagator in SpanContextPropagatorFactory

332c30c

update SpanContextPropagatorFactoryTests

7589475

add W3CBaggagePropagatorTests

20b3387

try to avoid heap allocations when percent-encoding

2faf701

add tests with commas in the baggage value

2cef3e8

#else

129bdad

don't use stack for large buffers

7cc27eb

add telemetry metric for truncated propagation headers

04ae3b1

update auto-generated files

dd57dc0

emit telemetry from baggage propagator

ecf7159

use string length instead of Encoding.UTF8.GetByteCount()

df1ff1b

return original string if nothing needs to be encoded

f8cfd25

make method private

80aadfa

use Tracer.Instance as fallback

c8a64a1

add a few more test cases for baggage size limits

de50965

update config_norm_rules.json

d83d98e

use Tracer.Instance.Settings

7400a99

Revert adding ContextHeaderTruncationReason

8fce180

use a new telemetry metric tag

65aa7c1

fix telemetry usage in propagator

a85e074

update auto-generated files

627c9e2

rename ForEach() to Enumerate()

e3034d8

update common_metrics.json

e360fe9

use try/finally to return rented buffer

53fb094

remove unnecessary local method

b02ea98

handle null argument

7a2579b

add more test cases and clean up others

2a52921

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-2 branch from c2e5057 to 2a52921 Compare November 7, 2024 15:39

This was referenced Nov 7, 2024

enable baggage propagator by default #6258

Merged

baggage propagator clean up #6266

Merged

Conversation

lucaspimentel commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

lucaspimentel commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datadog-ddstaging bot commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

Uh oh!

andrewlock commented Oct 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Execution-Time Benchmarks Report ⏱️

Uh oh!

andrewlock commented Oct 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6158

Raw results

Raw results

Uh oh!

andrewlock commented Oct 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Throughput/Crank Report ⚡

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lucaspimentel commented Oct 15, 2024 •

edited

Loading

lucaspimentel commented Oct 15, 2024 •

edited

Loading

datadog-ddstaging bot commented Oct 15, 2024 •

edited

Loading

andrewlock commented Oct 18, 2024 •

edited

Loading

andrewlock commented Oct 18, 2024 •

edited

Loading

andrewlock commented Oct 18, 2024 •

edited

Loading