Minor: rename .bazel:defs:cache:ephemeral to :progressive#47022
Conversation
### What does this PR do? ```diff -.bazel:defs:cache:ephemeral +.bazel:defs:cache:progressive ``` ### Motivation My bad, "ephemeral" was kind of misleading: admittedly used by ephemeral _runners_, but not ephemeral in itself since it's stored to S3. ### Additional Notes "progressive" better reflects the controlled policy introduced in #46151: only `main` pushes to the cache, keeping it growing incrementally rather than going back and forth depending on the last pushing branch - whether antiquated or exploratory.
Gitlab CI Configuration ChangesRenamed Jobs
Changes Summary
ℹ️ Diff available in the job log. |
Files inventory check summaryFile checks results against ancestor d3c12201: Results for datadog-agent_7.78.0~devel.git.171.a8bbec3.pipeline.99354792-1_amd64.deb:No change detected |
alopezz
left a comment
There was a problem hiding this comment.
No strong opinion here. I guess ephemeral was initially introduced in contrast to the persistent runners that we had – distinction that no longer applies.
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: a4cd277 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.33 | [-1.71, +4.36] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.33 | [-1.71, +4.36] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +0.47 | [-1.00, +1.93] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_memory | memory utilization | +0.46 | [+0.39, +0.53] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.24 | [+0.18, +0.31] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.22 | [+0.11, +0.32] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.12 | [+0.08, +0.16] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_metrics | memory utilization | +0.12 | [-0.04, +0.27] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.11 | [-0.05, +0.27] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.06 | [-0.16, +0.28] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.03 | [-0.11, +0.17] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.02 | [-0.10, +0.14] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.02 | [-0.11, +0.14] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.09, +0.09] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.02 | [-0.40, +0.37] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.02 | [-0.07, +0.04] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.02 | [-0.07, +0.03] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.06 | [-0.48, +0.36] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.07 | [-0.55, +0.41] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.08 | [-0.12, -0.03] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.12 | [-0.29, +0.05] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.28 | [-0.32, -0.24] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.64 | [-0.72, -0.56] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -1.23 | [-1.44, -1.02] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
### What does this PR do? Replace `.cache/go*` / `.cache/ms-go*` globs with explicit `.cache/go` / `.cache/ms-go` paths in both the GitLab progressive cache config and the GitHub Actions bazel-cache action. ### Motivation The go-build directory (`.cache/go-build`, `.cache/ms-go-build`) accounts for ~94% of the progressive cache (~16 GB uncompressed). It grows without bound because Go's time-based GC only fires when the `go` command is invoked with that GOCACHE path, which never happens in a Bazel-centric CI where `rules_go` compiles inside sandboxes with a different GOCACHE. This change is intentionally minimal: once merged, the next cache push will contain only the remaining ~6% (module download cache + toolchain), flushing the accumulated go-build bloat from S3. That reduced footprint is a prerequisite for safely reverting the cache key from `bazel-$CI_JOB_NAME` back to `bazel-$CI_RUNNER_DESCRIPTION` (see TODO comment added in #47022).
### What does this PR do? Replace `.cache/go*` / `.cache/ms-go*` globs with explicit `.cache/go` / `.cache/ms-go` paths in both the GitLab progressive cache config and its GitHub Actions counterpart. ### Motivation The Go build directory (`.cache/go-build`, `.cache/ms-go-build`) accounts for ~94% of the progressive cache (~16 GB uncompressed). It grows without bound because Go's time-based GC only fires when the `go` command is invoked with that `GOCACHE` path, which never happens in a Bazel-centric CI where `rules_go` compiles inside sandboxes. ### Additional Notes This change is **intentionally minimal**: once merged, the next cache push will contain only the remaining ~6% (module download cache + toolchain), flushing the accumulated go-build bloat from S3. That reduced footprint is a prerequisite for safely reverting the cache key from `bazel-$CI_JOB_NAME` back to `bazel-$CI_RUNNER_DESCRIPTION` (see TODO comment added in #47022). Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
What does this PR do?
Motivation
My bad, "ephemeral" was kind of misleading: admittedly used by ephemeral runners, but not ephemeral in itself since it's stored to S3 and retrieved from it...
Additional Notes
"progressive" better reflects the controlled policy introduced in #46151: only
mainpushes to the cache, keeping it growing incrementally rather than going back and forth depending on the last pushing branch - whether antiquated or exploratory ("latest wins").