Exclude `[ms-]go-build` paths from progressive cache by rdesgroppes · Pull Request #47748 · DataDog/datadog-agent

rdesgroppes · 2026-03-11T23:22:02Z

What does this PR do?

Replace .cache/go* / .cache/ms-go* globs with explicit .cache/go / .cache/ms-go paths in both the GitLab progressive cache config and its GitHub Actions counterpart.

Motivation

The Go build directory (.cache/go-build, .cache/ms-go-build) accounts for ~94% of the progressive cache (~16 GB uncompressed).
It grows without bound because Go's time-based GC only fires when the go command is invoked with that GOCACHE path, which never happens in a Bazel-centric CI where rules_go compiles inside sandboxes.

Additional Notes

This change is intentionally minimal: once merged, the next cache push will contain only the remaining ~6% (module download cache + toolchain), flushing the accumulated go-build bloat from S3.
That reduced footprint is a prerequisite for safely reverting the cache key from bazel-$CI_JOB_NAME back to
bazel-$CI_RUNNER_DESCRIPTION (see TODO comment added in #47022).

### What does this PR do? Replace `.cache/go*` / `.cache/ms-go*` globs with explicit `.cache/go` / `.cache/ms-go` paths in both the GitLab progressive cache config and the GitHub Actions bazel-cache action. ### Motivation The go-build directory (`.cache/go-build`, `.cache/ms-go-build`) accounts for ~94% of the progressive cache (~16 GB uncompressed). It grows without bound because Go's time-based GC only fires when the `go` command is invoked with that GOCACHE path, which never happens in a Bazel-centric CI where `rules_go` compiles inside sandboxes with a different GOCACHE. This change is intentionally minimal: once merged, the next cache push will contain only the remaining ~6% (module download cache + toolchain), flushing the accumulated go-build bloat from S3. That reduced footprint is a prerequisite for safely reverting the cache key from `bazel-$CI_JOB_NAME` back to `bazel-$CI_RUNNER_DESCRIPTION` (see TODO comment added in #47022).

agent-platform-auto-pr · 2026-03-11T23:26:24Z

Gitlab CI Configuration Changes

⚠️ Diff too large to display on Github.

Changes Summary

Removed	Modified	Added	Renamed
0	110	0	0

ℹ️ Diff available in the job log.

agent-platform-auto-pr · 2026-03-11T23:48:27Z

Files inventory check summary

File checks results against ancestor 29de6847:

Results for datadog-agent_7.78.0~devel.git.524.b9bf274.pipeline.102043863-1_amd64.deb:

No change detected

cit-pr-commenter-54b7da · 2026-03-12T09:33:04Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 52d8386f-478c-4b38-be6d-0818c4dd5cf5

Baseline: 4545098
Comparison: 00cb6a1
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-0.29	[-3.31, +2.73]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+3.71	[+2.10, +5.32]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.43	[+0.39, +0.47]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	+0.15	[-0.09, +0.38]	1	Logs bounds checks dashboard
➖	ddot_logs	memory utilization	+0.14	[+0.09, +0.20]	1	Logs
➖	docker_containers_memory	memory utilization	+0.12	[+0.05, +0.19]	1	Logs
➖	ddot_metrics	memory utilization	+0.11	[-0.07, +0.29]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.03	[-0.19, +0.26]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.02	[-0.43, +0.46]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.02	[-0.14, +0.17]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.10, +0.10]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.00	[-0.51, +0.52]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.01	[-0.19, +0.18]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.20, +0.18]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.02	[-0.40, +0.37]	1	Logs
➖	file_tree	memory utilization	-0.02	[-0.07, +0.03]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.03	[-0.10, +0.04]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.04	[-0.10, +0.01]	1	Logs
➖	quality_gate_idle	memory utilization	-0.06	[-0.11, -0.01]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulative	memory utilization	-0.06	[-0.21, +0.08]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.25	[-0.41, -0.09]	1	Logs
➖	docker_containers_cpu	% cpu utilization	-0.29	[-3.31, +2.73]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.49	[-0.59, -0.39]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.57	[-0.68, -0.47]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	538 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	272.64MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	715 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.19GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.23GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.21GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 = 3	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	172.54MiB ≤ 175MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 = 3	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	489.43MiB ≤ 550MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	206.95MiB ≤ 220MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	342.47 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	409.41MiB ≤ 475MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Mar 11, 2026

dd-octo-sts bot added internal Identify a non-fork PR team/agent-devx team/agent-build labels Mar 11, 2026

github-actions bot added the short review PR is simple enough to be reviewed quickly label Mar 11, 2026

rdesgroppes marked this pull request as ready for review March 11, 2026 23:26

rdesgroppes requested review from a team as code owners March 11, 2026 23:26

alopezz approved these changes Mar 12, 2026

View reviewed changes

chouetz approved these changes Mar 12, 2026

View reviewed changes

gh-worker-dd-mergequeue-cf854d bot merged commit 00cb6a1 into main Mar 12, 2026
305 of 312 checks passed

gh-worker-dd-mergequeue-cf854d bot deleted the regis.desgroppes/bazel-drop-go-build-cache branch March 12, 2026 08:43

github-actions bot added this to the 7.78.0 milestone Mar 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exclude `[ms-]go-build` paths from progressive cache#47748

Exclude `[ms-]go-build` paths from progressive cache#47748
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/bazel-drop-go-build-cache

rdesgroppes commented Mar 11, 2026 •

edited

Loading

Uh oh!

agent-platform-auto-pr bot commented Mar 11, 2026

Uh oh!

agent-platform-auto-pr bot commented Mar 11, 2026

Uh oh!

Uh oh!

cit-pr-commenter-54b7da bot commented Mar 12, 2026

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rdesgroppes commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

Uh oh!

agent-platform-auto-pr bot commented Mar 11, 2026

Gitlab CI Configuration Changes

Changes Summary

Uh oh!

agent-platform-auto-pr bot commented Mar 11, 2026

Files inventory check summary

Results for datadog-agent_7.78.0~devel.git.524.b9bf274.pipeline.102043863-1_amd64.deb:

Uh oh!

Uh oh!

cit-pr-commenter-54b7da bot commented Mar 12, 2026

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rdesgroppes commented Mar 11, 2026 •

edited

Loading