[ABLD-135] Use available `bazel` spawn strategy on Windows by rdesgroppes · Pull Request #40328 · DataDog/datadog-agent

rdesgroppes · 2025-08-27T22:10:11Z

Motivation

The sandboxed spawn strategy is alas unavailable on Windows as of bazel 8.3.1:

ERROR: 'sandboxed' was requested for mnemonic  but no strategy with that identifier was registered.
 Valid values are: [dynamic_worker, standalone, dynamic, remote, worker, local]

What does this PR do?

The present change therefore consists in splitting spawn strategies per OS:

Darwin & Linux: sandboxed, (as earlier)
Windows: standalone. (closest match, that is without involving remote execution)

Possible Drawbacks / Trade-offs

Despite not being isolated, standalone is slightly closer to sandboxed than local in that it respects some bazel restrictions. (working directory, for instance)

The `sandboxed` spawn strategy is alas unavailable on Windows as of `bazel` 8.3.1: ``` ERROR: 'sandboxed' was requested for mnemonic but no strategy with that identifier was registered. Valid values are: [dynamic_worker, standalone, dynamic, remote, worker, local] ``` The present change therefore consists in splitting spawn strategies per OS: - Darwin & Linux: `sandboxed`, (as earlier) - Windows: `standalone`. (closest match, that is without involving remote execution) Despite not being isolated, `standalone` is slightly closer to `sandboxed` than `local` in that it respects _some_ `bazel` restrictions. (working directory, for instance)

cit-pr-commenter · 2025-08-27T22:56:41Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c5014d2a-b47b-44d3-a579-f411631575fd

Baseline: 48c2688
Comparison: bf4f826
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+3.28	[+0.12, +6.45]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_memory	memory utilization	+3.60	[+3.46, +3.74]	1	Logs
➖	docker_containers_cpu	% cpu utilization	+3.28	[+0.12, +6.45]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	+1.13	[+0.79, +1.47]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	+0.57	[-2.19, +3.34]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	+0.50	[+0.43, +0.58]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.34	[+0.31, +0.37]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.27	[+0.23, +0.30]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	+0.19	[+0.05, +0.34]	1	Logs
➖	file_tree	memory utilization	+0.16	[+0.12, +0.20]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.04	[-0.11, +0.19]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.01	[-0.61, +0.63]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.00	[-0.67, +0.66]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.07, +0.06]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.01	[-0.04, +0.02]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.05	[-0.64, +0.53]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.08	[-0.65, +0.50]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.09	[-0.15, -0.02]	1	Logs
➖	ddot_metrics	memory utilization	-0.11	[-0.33, +0.11]	1	Logs
➖	ddot_logs	memory utilization	-0.63	[-0.74, -0.52]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	memory_usage	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2025-08-27T23:12:14Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 61eb450

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${+0}$$	$${700.55}$$ < $${704.84}$$	$${-0.04}$$	$${177.16}$$ < $${178.58}$$
✅	agent_deb_amd64_fips	$${+0}$$	$${687.82}$$ < $${703.09}$$	$${+0.01}$$	$${174.08}$$ < $${178.12}$$
✅	agent_heroku_amd64	$${0}$$	$${350.36}$$ < $${355.37}$$	$${-0}$$	$${94.01}$$ < $${95.72}$$
✅	agent_msi	$${0}$$	$${975.62}$$ < $${980.61}$$	$${+0.04}$$	$${150.16}$$ < $${152.67}$$
✅	agent_rpm_amd64	$${+0}$$	$${700.54}$$ < $${704.83}$$	$${-0.01}$$	$${179.18}$$ < $${180.22}$$
✅	agent_rpm_amd64_fips	$${+0}$$	$${687.81}$$ < $${703.08}$$	$${+0.02}$$	$${175.8}$$ < $${179.85}$$
✅	agent_rpm_arm64	$${+0}$$	$${689.55}$$ < $${694.74}$$	$${-0.02}$$	$${161.68}$$ < $${163.96}$$
✅	agent_rpm_arm64_fips	$${+0}$$	$${677.66}$$ < $${693.05}$$	$${+0}$$	$${158.41}$$ < $${163.0}$$
✅	agent_suse_amd64	$${+0}$$	$${700.54}$$ < $${704.83}$$	$${-0.01}$$	$${179.18}$$ < $${180.22}$$
✅	agent_suse_amd64_fips	$${+0}$$	$${687.81}$$ < $${703.08}$$	$${+0.02}$$	$${175.8}$$ < $${179.85}$$
✅	agent_suse_arm64	$${+0}$$	$${689.55}$$ < $${694.74}$$	$${-0.02}$$	$${161.68}$$ < $${163.96}$$
✅	agent_suse_arm64_fips	$${+0}$$	$${677.66}$$ < $${693.05}$$	$${+0}$$	$${158.41}$$ < $${163.0}$$
✅	docker_agent_amd64	$${+0}$$	$${782.96}$$ < $${788.65}$$	$${+0}$$	$${269.92}$$ < $${272.01}$$
✅	docker_agent_arm64	$${+0}$$	$${795.31}$$ < $${802.0}$$	$${-0.01}$$	$${256.7}$$ < $${259.7}$$
✅	docker_agent_jmx_amd64	$${+0}$$	$${973.83}$$ < $${979.84}$$	$${+0}$$	$${338.55}$$ < $${340.95}$$
✅	docker_agent_jmx_arm64	$${+0}$$	$${974.77}$$ < $${981.8}$$	$${+0}$$	$${321.31}$$ < $${324.65}$$
✅	docker_cluster_agent_amd64	$${+0}$$	$${212.65}$$ < $${214.5}$$	$${+0}$$	$${72.21}$$ < $${73.51}$$
✅	docker_cluster_agent_arm64	$${0}$$	$${228.61}$$ < $${230.33}$$	$${+0}$$	$${68.48}$$ < $${69.77}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.07}$$ < $${7.12}$$	$${-0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${-0}$$	$${2.71}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${38.32}$$ < $${39.57}$$	$${-0}$$	$${14.81}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${36.99}$$ < $${38.2}$$	$${-0}$$	$${14.26}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${29.55}$$ < $${31.4}$$	$${+0}$$	$${7.8}$$ < $${8.95}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${28.14}$$ < $${29.97}$$	$${-0}$$	$${6.75}$$ < $${7.89}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${29.55}$$ < $${31.4}$$	$${+0}$$	$${7.81}$$ < $${8.96}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${29.55}$$ < $${31.4}$$	$${+0}$$	$${7.81}$$ < $${8.96}$$
✅	iot_agent_deb_amd64	$${0}$$	$${54.15}$$ < $${54.55}$$	$${+0}$$	$${13.65}$$ < $${14.45}$$
✅	iot_agent_deb_arm64	$${0}$$	$${51.47}$$ < $${51.9}$$	$${+0}$$	$${11.82}$$ < $${12.63}$$
✅	iot_agent_deb_armhf	$${0}$$	$${51.02}$$ < $${51.42}$$	$${-0}$$	$${11.88}$$ < $${12.74}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${54.15}$$ < $${54.55}$$	$${-0}$$	$${13.67}$$ < $${14.47}$$
✅	iot_agent_suse_amd64	$${0}$$	$${54.15}$$ < $${54.55}$$	$${-0}$$	$${13.67}$$ < $${14.47}$$

After #40328, I didn't realize configured spawn strategies were no longer honored by `bazel`. This is because OS-specific strategies are disabled by default, which the present change aims at enabling.

### Motivation After #40328, I didn't realize configured spawn strategies were no longer honored by `bazel`. ### What does this PR do? This is because OS-specific strategies are disabled by default, which the present change aims at enabling.

### What does this PR do? Now `bazelisk` is available on all our CI executors ([macOS](DataDog/ci-platform-machine-images#395) runners, [Linux](DataDog/datadog-agent-buildimages#951) & [Windows](DataDog/datadog-agent-buildimages#953) containers), this change secures an initial part of our `bazel` setup while providing reusable job templates to ease caching in CI. Practically, it adds a handful of jobs focusing on **building `bazel` dependencies** in the corresponding GitLab `deps_build` stage. Overall, it consists in: 1. verifying **`bazelisk` properly bootstraps `bazel` across all platforms**, (primary scope of the PR) 2. extracting initial `bazel:`-prefixed CI job templates and dogfooding them, (i.e. by building deps) 3. binding `bazelisk`/`bazel` caches to GitLab caching capabilities (runner-based as of now): installed binaries, "repository cache", "repo contents cache", and "disk cache" are all saved/restored correctly to/from GitLab while honoring OS/architecture boundaries, 4. marking in-workspace cache in both `.bazelignore` and `.gitignore`, 5. adjusting code/job ownership accordingly. ### Motivation Securing some initial `bazel` configuration in CI : - ensures all platforms are kept in the radar over next iterations, - prevents regressions over next iterations, - establishes foundations for future jobs. ### Possible Drawbacks / Trade-offs - on Windows, compilation errors made be descope dependencies being built to **only `bzip2`**. This will be of course addressed in a subsequent PR, - GitLab caching is still runner-based for the time being, which can be revisited later. (like everything) ### Additional Notes Main addressed challenges: - cache location conflicts[^1]: externalized "repo contents cache" through `tools/bazel*` wrappers: - bazelbuild/bazel#26384 - bazelbuild/bazel#26522 - bazelbuild/bazel#26773 - bazelbuild/bazel#26802 - macOS runners: - `bzip2` dependency: fetch from a reachable source: - [x] #40219 - Windows: - `bazel` spawn strategy: fallback to a permissive strategy since `sandboxed` is unsupported - [x] #40328 - `tools/bazel` wrapper: fallback to batch (`tools/bazel.bat`), since `bash` is discouraged by `bazel` in this case and `tools/bazel.ps1` poses detection problems, - long paths were supported in containers but not on runners: - [x] DataDog/ci-platform-machine-images#429 - recursive symlinks: use `robocopy` instead of `copy`/`move`/`xcopy`. [^1]: > ERROR: The repo contents cache [/path/to/datadog-agent/.cache/repo_contents] is inside the workspace [/path/to/datadog-agent]. This can cause spurious failures. Disable the repo contents cache with `--repo_contents_cache=`, or specify `--repo_contents_cache=<path outside the workspace>`.

rdesgroppes requested a review from a team as a code owner August 27, 2025 22:10

rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation ask-review Ask required teams to review this PR labels Aug 27, 2025

github-actions bot added the short review PR is simple enough to be reviewed quickly label Aug 27, 2025

rdesgroppes changed the title ~~Use available bazel spawn strategy on Windows~~ [ABLD-132] Use available bazel spawn strategy on Windows Aug 28, 2025

rdesgroppes changed the title ~~[ABLD-132] Use available bazel spawn strategy on Windows~~ [ABLD-135] Use available bazel spawn strategy on Windows Aug 28, 2025

alopezz approved these changes Aug 28, 2025

View reviewed changes

rdesgroppes merged commit e2ae047 into main Aug 28, 2025
271 checks passed

rdesgroppes deleted the regis.desgroppes/use-available-bazel-strategy-on-windows branch August 28, 2025 08:42

github-actions bot added this to the 7.71.0 milestone Aug 28, 2025

rdesgroppes mentioned this pull request Aug 29, 2025

[ABLD-135] Add initial bazel jobs #40153

Merged

3 tasks

rdesgroppes mentioned this pull request Aug 29, 2025

[ABLD-135] Make bazel honor OS-specific spawn strategies #40407

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ABLD-135] Use available `bazel` spawn strategy on Windows#40328

[ABLD-135] Use available `bazel` spawn strategy on Windows#40328
rdesgroppes merged 1 commit intomainfrom
regis.desgroppes/use-available-bazel-strategy-on-windows

rdesgroppes commented Aug 27, 2025 •

edited

Loading

Uh oh!

cit-pr-commenter bot commented Aug 27, 2025

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

agent-platform-auto-pr bot commented Aug 27, 2025

Info

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

rdesgroppes commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

What does this PR do?

Possible Drawbacks / Trade-offs

Uh oh!

cit-pr-commenter bot commented Aug 27, 2025

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

agent-platform-auto-pr bot commented Aug 27, 2025

Static quality checks

Info

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rdesgroppes commented Aug 27, 2025 •

edited

Loading