Skip to content

[ABLD-135] Make bazel honor OS-specific spawn strategies#40407

Merged
rdesgroppes merged 1 commit intomainfrom
regis.desgroppes/make-bazel-honor-os-specific-strategies
Sep 1, 2025
Merged

[ABLD-135] Make bazel honor OS-specific spawn strategies#40407
rdesgroppes merged 1 commit intomainfrom
regis.desgroppes/make-bazel-honor-os-specific-strategies

Conversation

@rdesgroppes
Copy link
Copy Markdown
Contributor

@rdesgroppes rdesgroppes commented Aug 29, 2025

Motivation

After #40328, I didn't realize configured spawn strategies were no longer honored by bazel.

What does this PR do?

This is because OS-specific strategies are disabled by default, which the present change aims at enabling.

@rdesgroppes
Make bazel honor OS-specific spawn strategies
6498040 
After #40328, I didn't realize configured spawn strategies were no
longer honored by `bazel`. This is because OS-specific strategies are
disabled by default, which the present change aims at enabling.
@rdesgroppes rdesgroppes added the changelog/no-changelog No changelog entry needed label Aug 29, 2025
@rdesgroppes rdesgroppes requested a review from a team as a code owner August 29, 2025 22:57
@rdesgroppes rdesgroppes added qa/no-code-change No code change in Agent code requiring validation ask-review Ask required teams to review this PR labels Aug 29, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Aug 29, 2025
@cit-pr-commenter
Copy link
Copy Markdown

cit-pr-commenter bot commented Aug 29, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 5a244c0d-392a-401c-be0f-687fdb81ae38

Baseline: e70c1be
Comparison: 6498040
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
✅ docker_containers_cpu % cpu utilization -10.17 [-13.18, -7.15] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ otlp_ingest_logs memory utilization +0.82 [+0.67, +0.97] 1 Logs
➖ tcp_syslog_to_blackhole ingress throughput +0.55 [+0.48, +0.62] 1 Logs
➖ quality_gate_idle memory utilization +0.54 [+0.50, +0.58] 1 Logs bounds checks dashboard
➖ docker_containers_memory memory utilization +0.52 [+0.34, +0.70] 1 Logs
➖ uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.14 [+0.10, +0.18] 1 Logs
➖ ddot_metrics memory utilization +0.11 [-0.08, +0.29] 1 Logs
➖ file_to_blackhole_100ms_latency egress throughput +0.05 [-0.57, +0.68] 1 Logs
➖ file_to_blackhole_500ms_latency egress throughput +0.03 [-0.58, +0.64] 1 Logs
➖ file_to_blackhole_1000ms_latency egress throughput +0.02 [-0.59, +0.64] 1 Logs
➖ file_to_blackhole_0ms_latency egress throughput -0.00 [-0.62, +0.62] 1 Logs
➖ uds_dogstatsd_to_api ingress throughput -0.01 [-0.04, +0.02] 1 Logs
➖ tcp_dd_logs_filter_exclude ingress throughput -0.02 [-0.05, +0.02] 1 Logs
➖ quality_gate_idle_all_features memory utilization -0.02 [-0.05, +0.01] 1 Logs bounds checks dashboard
➖ ddot_logs memory utilization -0.17 [-0.28, -0.06] 1 Logs
➖ quality_gate_metrics_logs memory utilization -0.19 [-0.54, +0.15] 1 Logs bounds checks dashboard
➖ file_tree memory utilization -0.21 [-0.26, -0.17] 1 Logs
➖ otlp_ingest_metrics memory utilization -0.65 [-0.83, -0.48] 1 Logs
➖ quality_gate_logs % cpu utilization -1.56 [-4.27, +1.16] 1 Logs bounds checks dashboard
✅ docker_containers_cpu % cpu utilization -10.17 [-13.18, -7.15] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
❌ docker_containers_cpu simple_check_run 6/10
✅ docker_containers_memory memory_usage 10/10
❌ docker_containers_memory simple_check_run 8/10
✅ file_to_blackhole_0ms_latency lost_bytes 10/10
✅ file_to_blackhole_0ms_latency memory_usage 10/10
✅ file_to_blackhole_1000ms_latency memory_usage 10/10
✅ file_to_blackhole_100ms_latency lost_bytes 10/10
✅ file_to_blackhole_100ms_latency memory_usage 10/10
✅ file_to_blackhole_500ms_latency lost_bytes 10/10
✅ file_to_blackhole_500ms_latency memory_usage 10/10
✅ quality_gate_idle intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr bot commented Aug 30, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor a8071b9

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
✅ agent_deb_amd64 $${-4.11}$$ $${701.11}$$ < $${704.84}$$ $${-0.81}$$ $${177.25}$$ < $${178.58}$$
✅ agent_deb_amd64_fips $${-4.12}$$ $${688.38}$$ < $${703.09}$$ $${-0.99}$$ $${174.2}$$ < $${178.12}$$
✅ agent_heroku_amd64 $${-4.11}$$ $${350.8}$$ < $${355.37}$$ $${-0.74}$$ $${94.26}$$ < $${95.72}$$
✅ agent_msi $${-3.72}$$ $${977.31}$$ < $${980.61}$$ $${-1.05}$$ $${150.28}$$ < $${152.67}$$
✅ agent_rpm_amd64 $${-4.11}$$ $${701.1}$$ < $${704.83}$$ $${-0.75}$$ $${179.46}$$ < $${180.22}$$
✅ agent_rpm_amd64_fips $${-4.12}$$ $${688.37}$$ < $${703.08}$$ $${-0.96}$$ $${175.84}$$ < $${179.85}$$
✅ agent_rpm_arm64 $${-4.17}$$ $${690.08}$$ < $${694.74}$$ $${-1.39}$$ $${161.74}$$ < $${163.96}$$
✅ agent_rpm_arm64_fips $${-4.18}$$ $${678.19}$$ < $${693.05}$$ $${-1.15}$$ $${158.47}$$ < $${163.0}$$
✅ agent_suse_amd64 $${-4.11}$$ $${701.1}$$ < $${704.83}$$ $${-0.75}$$ $${179.46}$$ < $${180.22}$$
✅ agent_suse_amd64_fips $${-4.12}$$ $${688.37}$$ < $${703.08}$$ $${-0.96}$$ $${175.84}$$ < $${179.85}$$
✅ agent_suse_arm64 $${-4.17}$$ $${690.08}$$ < $${694.74}$$ $${-1.39}$$ $${161.74}$$ < $${163.96}$$
✅ agent_suse_arm64_fips $${-4.18}$$ $${678.19}$$ < $${693.05}$$ $${-1.15}$$ $${158.47}$$ < $${163.0}$$
✅ docker_agent_amd64 $${-4.11}$$ $${783.52}$$ < $${788.65}$$ $${-1.22}$$ $${270.14}$$ < $${272.01}$$
✅ docker_agent_arm64 $${-4.17}$$ $${795.83}$$ < $${802.0}$$ $${-1.68}$$ $${256.84}$$ < $${259.7}$$
✅ docker_agent_jmx_amd64 $${-4.11}$$ $${974.38}$$ < $${979.84}$$ $${-1.23}$$ $${338.76}$$ < $${340.95}$$
✅ docker_agent_jmx_arm64 $${-4.17}$$ $${975.3}$$ < $${981.8}$$ $${-1.67}$$ $${321.47}$$ < $${324.65}$$
✅ docker_cluster_agent_amd64 $${+0.01}$$ $${212.66}$$ < $${214.5}$$ $${-0}$$ $${72.21}$$ < $${73.51}$$
✅ docker_cluster_agent_arm64 $${-0}$$ $${228.61}$$ < $${230.33}$$ $${+0}$$ $${68.49}$$ < $${69.77}$$
✅ docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${0}$$ $${2.95}$$ < $${3.29}$$
✅ docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.71}$$ < $${3.07}$$
✅ docker_dogstatsd_amd64 $${-0}$$ $${38.32}$$ < $${39.57}$$ $${+0}$$ $${14.81}$$ < $${15.76}$$
✅ docker_dogstatsd_arm64 $${-0}$$ $${36.99}$$ < $${38.2}$$ $${+0}$$ $${14.26}$$ < $${14.83}$$
✅ dogstatsd_deb_amd64 $${-0}$$ $${29.55}$$ < $${31.4}$$ $${+0}$$ $${7.8}$$ < $${8.95}$$
✅ dogstatsd_deb_arm64 $${-0}$$ $${28.14}$$ < $${29.97}$$ $${-0}$$ $${6.75}$$ < $${7.89}$$
✅ dogstatsd_rpm_amd64 $${-0}$$ $${29.55}$$ < $${31.4}$$ $${+0}$$ $${7.81}$$ < $${8.96}$$
✅ dogstatsd_suse_amd64 $${-0}$$ $${29.55}$$ < $${31.4}$$ $${+0}$$ $${7.81}$$ < $${8.96}$$
✅ iot_agent_deb_amd64 $${+0.43}$$ $${54.58}$$ < $${54.97}$$ $${+0.11}$$ $${13.76}$$ < $${14.45}$$
✅ iot_agent_deb_arm64 $${+0.41}$$ $${51.88}$$ < $${51.9}$$ $${+0.08}$$ $${11.9}$$ < $${12.63}$$
✅ iot_agent_deb_armhf $${+0.42}$$ $${51.45}$$ < $${51.84}$$ $${+0.08}$$ $${11.97}$$ < $${12.74}$$
✅ iot_agent_rpm_amd64 $${+0.43}$$ $${54.58}$$ < $${54.97}$$ $${+0.11}$$ $${13.78}$$ < $${14.47}$$
✅ iot_agent_suse_amd64 $${+0.43}$$ $${54.58}$$ < $${54.97}$$ $${+0.11}$$ $${13.78}$$ < $${14.47}$$

@rdesgroppes rdesgroppes merged commit fe156b1 into main Sep 1, 2025
272 checks passed
@rdesgroppes rdesgroppes deleted the regis.desgroppes/make-bazel-honor-os-specific-strategies branch September 1, 2025 09:39
@github-actions github-actions bot added this to the 7.71.0 milestone Sep 1, 2025
@rdesgroppes rdesgroppes changed the title Make bazel honor OS-specific spawn strategies [ABLD-135] Make bazel honor OS-specific spawn strategies Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JSGette JSGette JSGette approved these changes

Assignees

No one assigned

Labels

ask-review Ask required teams to review this PR changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly

Projects

None yet

Milestone

7.71.0

Development

Successfully merging this pull request may close these issues.

2 participants

@rdesgroppes @JSGette