glsl/lightMapping: increase lower bound in computation to restore original light color, fix #299#306
Merged
illwieckz merged 1 commit intoDaemonEngine:masterfrom Apr 8, 2020
Merged
Conversation
Member
|
LGTM |
Member
Author
|
Reminding it was looking like this: Without the line in that glsl file it looks like this (feature being disabled): With the line being edited by increasing the value, it looks like this: So the issue can still be seen in that very rare scenario but that's the cost to keep the feature. (note: don't mind the artifacts on the bottom of the screenshots, they are absolutely unrelated and are not expected to be seen on user's screen, that's somewhat related to a usually disabled, incomplete and not working feature I tried recently.) |
…ginal light color, fix DaemonEngine#299
illwieckz
added a commit
to illwieckz/Daemon
that referenced
this pull request
Apr 16, 2020
…tion, ref DaemonEngine#299, DaemonEngine#306 The feature discussed in DaemonEngine#299 and DaemonEngine#306 to restore original light color to feed the normal-based light computation was only applied on surface using deluxe maps, leading to anomalous dark lighting with maps without deluxemaps, or when deluxe mapping is disabled. It's not related to deluxe maps but to light maps any way
illwieckz
added a commit
to illwieckz/Daemon
that referenced
this pull request
Apr 21, 2020
…tion, ref DaemonEngine#299, DaemonEngine#306 The feature discussed in DaemonEngine#299 and DaemonEngine#306 to restore original light color to feed the normal-based light computation was only applied on surface using deluxe maps, leading to anomalous dark lighting with maps without deluxemaps, or when deluxe mapping is disabled. It's not related to deluxe maps but to light maps any way
illwieckz
added a commit
to illwieckz/Daemon
that referenced
this pull request
Apr 21, 2020
…tion, ref DaemonEngine#299, DaemonEngine#306 The feature discussed in DaemonEngine#299 and DaemonEngine#306 to restore original light color to feed the normal-based light computation was only applied on surface using deluxe maps, leading to anomalous dark lighting with maps without deluxemaps, or when deluxe mapping is disabled. It's not related to deluxe maps but to light maps any way
illwieckz
added a commit
to illwieckz/Daemon
that referenced
this pull request
Apr 21, 2020
…tion, ref DaemonEngine#299, DaemonEngine#306 The feature discussed in DaemonEngine#299 and DaemonEngine#306 to restore original light color to feed the normal-based light computation was only applied on surface using deluxe maps, leading to anomalous dark lighting with maps without deluxemaps, or when deluxe mapping is disabled. It's not related to deluxe maps but to light maps any way
illwieckz
added a commit
to illwieckz/Daemon
that referenced
this pull request
Apr 23, 2020
…grid direction, ref DaemonEngine#299, DaemonEngine#306 The feature discussed in DaemonEngine#299 and DaemonEngine#306 to restore original light color to feed the normal-based light computation was only applied on surface using deluxe maps, leading to anomalous dark lighting with maps without deluxemaps, or when deluxe mapping is disabled. It's not related to deluxe maps but to light maps any way
illwieckz
added a commit
to illwieckz/Daemon
that referenced
this pull request
Apr 23, 2020
…en with lightgrid direction, ref DaemonEngine#299, DaemonEngine#306 The feature discussed in DaemonEngine#299 and DaemonEngine#306 to restore original light color to feed the normal-based light computation was only applied on surface using deluxe maps, leading to anomalous dark lighting with maps without deluxemaps, or when deluxe mapping is disabled. It's not related to deluxe maps but to light maps any way
illwieckz
added a commit
that referenced
this pull request
Apr 23, 2020
…en with lightgrid direction, ref #299, #306 The feature discussed in #299 and #306 to restore original light color to feed the normal-based light computation was only applied on surface using deluxe maps, leading to anomalous dark lighting with maps without deluxemaps, or when deluxe mapping is disabled. It's not related to deluxe maps but to light maps any way
illwieckz
added a commit
that referenced
this pull request
Apr 26, 2020
…en with lightgrid direction, ref #299, #306 The feature discussed in #299 and #306 to restore original light color to feed the normal-based light computation was only applied on surface using deluxe maps, leading to anomalous dark lighting with maps without deluxemaps, or when deluxe mapping is disabled. It's not related to deluxe maps but to light maps any way
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
glsl/lightMapping: increase lower bound in computation to restore original light color, fix #299