-
Notifications
You must be signed in to change notification settings - Fork 70
Closed
Labels
Description
Reported there before: UnvanquishedAssets/map-station15_src.dpkdir#3
I'm now sure it's an engine issue, and I now know the line causing this:
lightColor /= clamp(dot(normalize(var_Normal), lightDir), 0.004, 1.0);There:
Daemon/src/engine/renderer/glsl_source/lightMapping_fp.glsl
Lines 91 to 92 in 42e408a
| // divide by cosine term to restore original light color | |
| lightColor /= clamp(dot(normalize(var_Normal), lightDir), 0.004, 1.0); |
We can find trace of this code in first commit of the repository:
Daemon/main/glsl/lightMapping_fp.glsl
Line 165 in eb73a11
| float NdotLnobump = clamp(dot(normalize(var_Normal.xyz), L), 0.004, 1.0); |
It was removed in 0bb3550 (Add tiled light-index renderer) and re-added in 0949fda (Lightmapping fixes) by @gimhael.
I don't know what this code is for, it looks like there is less issues by not using this code than using it.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Done