Remove Registration of Factory Configuration object even with valid config#1006
Merged
tcormackMW merged 4 commits intodevelopmentfrom Apr 26, 2024
Merged
Remove Registration of Factory Configuration object even with valid config#1006tcormackMW merged 4 commits intodevelopmentfrom
tcormackMW merged 4 commits intodevelopmentfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #1006 +/- ##
===============================================
- Coverage 88.06% 86.33% -1.74%
===============================================
Files 259 136 -123
Lines 13558 7434 -6124
===============================================
- Hits 11940 6418 -5522
+ Misses 1618 1016 -602 |
pelliott-mathworks
approved these changes
Apr 23, 2024
Burgch
approved these changes
Apr 24, 2024
Contributor
Burgch
left a comment
There was a problem hiding this comment.
Looks great, thanks @tcormackMW!
jeffdiclemente
approved these changes
Apr 26, 2024
RobertLauferElektrobit
pushed a commit
to insi-eb/CppMicroServices-cpp14
that referenced
this pull request
Jul 29, 2025
…onfig (CppMicroServices#1006) Signed Off By: tcormack@mathworks.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not allow factory components to be registered. Implemented by always marking Configurations as unsatisfied