701 Remove Registration of Factory Configuration object even with valid config (#1006)#1178
Conversation
…onfig (CppMicroServices#1006) Signed Off By: tcormack@mathworks.com
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## c++14-compliant #1178 +/- ##
===================================================
+ Coverage 86.17% 88.10% +1.92%
===================================================
Files 133 242 +109
Lines 7516 11869 +4353
===================================================
+ Hits 6477 10457 +3980
- Misses 1039 1412 +373
🚀 New features to boost your workflow:
|
| // result in a deactivation and reactivation of the component | ||
| std::shared_ptr<cppmicroservices::service::cm::Configuration> configuration; | ||
| const std::string uniqueProp[3] = { "uniqueProp1", "uniqueProp2", "uniqueProp3" }; | ||
| std::string const uniqueProp[3] = { "uniqueProp1", "uniqueProp2", "uniqueProp3" }; |
There was a problem hiding this comment.
warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays]
^| std::string const uniqueProp[3] = { "uniqueProp1", "uniqueProp2", "uniqueProp3" }; | ||
| cppmicroservices::AnyMap props(cppmicroservices::AnyMap::UNORDERED_MAP_CASEINSENSITIVE_KEYS); | ||
| const std::string instance[3] = { "instance1", "instance2", "instance3" }; | ||
| std::string const instance[3] = { "instance1", "instance2", "instance3" }; |
There was a problem hiding this comment.
warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays]
^| @@ -0,0 +1,27 @@ | |||
| #ifndef _SERVICE_IMPL_HPP_ | |||
| #define _SERVICE_IMPL_HPP_ | |||
There was a problem hiding this comment.
warning: declaration uses identifier 'SERVICE_IMPL_HPP', which is a reserved identifier [bugprone-reserved-identifier]
| #define _SERVICE_IMPL_HPP_ | |
| #define SERVICE_IMPL_HPP_ |
| #ifndef _SERVICE_IMPL_HPP_ | ||
| #define _SERVICE_IMPL_HPP_ | ||
|
|
||
| #include "TestInterfaces/Interfaces.hpp" |
There was a problem hiding this comment.
warning: 'TestInterfaces/Interfaces.hpp' file not found [clang-diagnostic-error]
#include "TestInterfaces/Interfaces.hpp"
^|
|
||
| namespace sample | ||
| { | ||
| class ServiceComponentCA28 : public test::CAInterface |
There was a problem hiding this comment.
warning: class 'ServiceComponentCA28' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
class ServiceComponentCA28 : public test::CAInterface
^| class ServiceComponentCA28 : public test::CAInterface | ||
| { | ||
| public: | ||
| ServiceComponentCA28(std::shared_ptr<cppmicroservices::AnyMap> const& props) : properties(props) {} |
There was a problem hiding this comment.
warning: constructor does not initialize these fields: properties [cppcoreguidelines-pro-type-member-init]
compendium/test_bundles/TestBundleDSCA28/src/ServiceImpl.hpp:22:
- std::shared_ptr<cppmicroservices::AnyMap> properties;
+ std::shared_ptr<cppmicroservices::AnyMap> properties{};3b65270
into
CppMicroServices:c++14-compliant
cherry-pick of commit 18842e9 (PR #1006)
see discussion #701