fix: update typer to >=0.12.5 for PEP 604 union type support#357
Merged
fix: update typer to >=0.12.5 for PEP 604 union type support#357
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
The mix_stderr parameter was removed in modern click/typer. Use result.output instead of result.stdout + result.stderr.
Modern typer handles prompts differently, causing tracking consent prompts to fail in CI. Add autouse fixture to mock the prompt.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #357 +/- ##
==========================================
- Coverage 51.93% 51.33% -0.61%
==========================================
Files 32 32
Lines 3489 3563 +74
==========================================
+ Hits 1812 1829 +17
- Misses 1677 1734 +57
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on the this one: #356
Fixes #355
PR #349 changed
Optional[bool]type hints tobool | Nonesyntax, but typer < 0.12.4 does not support PEP 604 union types, causingRuntimeError: Type not yet supported: bool | None.Changes:
>=0.9to>=0.12.5(adds PEP 604 support via typer#548)is_flagparameter fromtyper.Option()calls (deprecated in typer 0.15.0, never worked properly)