fix: update typer to >=0.12.4 for PEP 604 union type support#356
Closed
christian-byrne wants to merge 1 commit intoComfy-Org:mainfrom
Closed
fix: update typer to >=0.12.4 for PEP 604 union type support#356christian-byrne wants to merge 1 commit intoComfy-Org:mainfrom
christian-byrne wants to merge 1 commit intoComfy-Org:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #356 +/- ##
==========================================
- Coverage 51.93% 51.81% -0.13%
==========================================
Files 32 32
Lines 3489 3563 +74
==========================================
+ Hits 1812 1846 +34
- Misses 1677 1717 +40
🚀 New features to boost your workflow:
|
Contributor
Author
|
The failing CI checks are unrelated to this PR's changes - they are e2e test failures caused by network timeouts downloading PyTorch from These are known flaky tests - the main branch also had the same failures on PR #351 ("Fix ComfyUI repo URLs"). The core unit tests ( Re-running the failed jobs... |
PR Comfy-Org#349 changed type hints from Optional[bool] to bool | None syntax, but typer < 0.12.4 doesn't support PEP 604 union types (X | None). This caused RuntimeError when running comfy CLI with older typer. Changes: - Update typer dependency from >=0.9 to >=0.12.4 - Remove deprecated is_flag parameter from typer.Option() calls (is_flag was deprecated in typer 0.15.0 and never worked properly) Fixes Comfy-Org#355 References: - Typer PEP 604 support: fastapi/typer#548 - is_flag deprecation: fastapi/typer#986 Amp-Thread-ID: https://ampcode.com/threads/T-019bdd23-62ea-732f-9443-5705ebe27a3b Co-authored-by: Amp <amp@ampcode.com>
1ba3f12 to
678235e
Compare
Contributor
|
Closing in the favor of #357 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #355
PR #349 changed
Optional[bool]type hints tobool | Nonesyntax, but typer < 0.12.4 does not support PEP 604 union types, causingRuntimeError: Type not yet supported: bool | None.Changes:
>=0.9to>=0.12.4(adds PEP 604 support via typer#548)is_flagparameter fromtyper.Option()calls (deprecated in typer 0.15.0, never worked properly)Testing:
click<=8.1.8pin is compatible with typer 0.12.4+