Set minimal supported python to version 3.10#349
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #349 +/- ##
==========================================
- Coverage 52.33% 52.23% -0.11%
==========================================
Files 32 32
Lines 3527 3519 -8
==========================================
- Hits 1846 1838 -8
Misses 1681 1681
🚀 New features to boost your workflow:
|
christian-byrne
added a commit
to christian-byrne/comfy-cli
that referenced
this pull request
Jan 20, 2026
PR Comfy-Org#349 changed type hints from Optional[bool] to bool | None syntax, but typer < 0.12.4 doesn't support PEP 604 union types (X | None). This caused RuntimeError when running comfy CLI with older typer. Changes: - Update typer dependency from >=0.9 to >=0.12.4 - Remove deprecated is_flag parameter from typer.Option() calls (is_flag was deprecated in typer 0.15.0 and never worked properly) Fixes Comfy-Org#355 References: - Typer PEP 604 support: fastapi/typer#548 - is_flag deprecation: fastapi/typer#986
christian-byrne
added a commit
to christian-byrne/comfy-cli
that referenced
this pull request
Jan 20, 2026
PR Comfy-Org#349 changed type hints from Optional[bool] to bool | None syntax, but typer < 0.12.4 doesn't support PEP 604 union types (X | None). This caused RuntimeError when running comfy CLI with older typer. Changes: - Update typer dependency from >=0.9 to >=0.12.4 - Remove deprecated is_flag parameter from typer.Option() calls (is_flag was deprecated in typer 0.15.0 and never worked properly) Fixes Comfy-Org#355 References: - Typer PEP 604 support: fastapi/typer#548 - is_flag deprecation: fastapi/typer#986 Amp-Thread-ID: https://ampcode.com/threads/T-019bdd23-62ea-732f-9443-5705ebe27a3b Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.