blackbox: fix potential overlow/memory corruption#486
Merged
chrissie-c merged 1 commit intomainfrom Jun 5, 2023
Merged
Conversation
if the message was too long, then msg_len was added to the buffer size twice, thus causing potential data corruption (seen VERY rarely in the CI test - or, at least, I think it was this). Also fix a double close() spotted by gcc13's -fanalyzer
jfriesse
approved these changes
Jun 1, 2023
Member
jfriesse
left a comment
There was a problem hiding this comment.
ACK. Nice to see gcc analyzer gets better than coverity ;)
Contributor
Author
|
retest this please |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jun 21, 2023
https://build.opensuse.org/request/show/1093859 by user yan_gao + dimstar_suse - Update to version 2.0.7+20230607.06c8641 (v2.0.7): - blackbox: fix potential overlow/memory corruption (gh#ClusterLabs/libqb#486) - tests: allow -j to work (gh#ClusterLabs/libqb#485) - strlcpy: avoid compiler warning from strncpy (gh#ClusterLabs/libqb#473) - timer: Move state check to before time check (gh#ClusterLabs/libqb#479) - ipc: Retry receiving credentials if the the message is short (gh#ClusterLabs/libqb#476, rh#2111711) - lib: Fix some small bugs spotted by newest covscan (gh#ClusterLabs/libqb#471) - doxygen2man: Fix function parameter alignment (gh#ClusterLabs/libqb#468) (forwarded request 1093858 from yan_gao)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if the message was too long, then msg_len was added to the buffer size twice, thus causing potential data corruption (seen VERY rarely in the CI test - or, at least, I think it was this).
Also fix a double close() spotted by gcc13's -fanalyzer