Skip to content

tests: allow -j to work#485

Merged
fabbione merged 1 commit intomainfrom
fix-minus-j
May 26, 2023
Merged

tests: allow -j to work#485
fabbione merged 1 commit intomainfrom
fix-minus-j

Conversation

@chrissie-c
Copy link
Copy Markdown
Contributor

This makes the IPC tests all run as one serial test. Having start, test, end as separate tests was a daft idea anyway.

It would be helpful to run ipc.test and ipc_sock.test in parallel (especially as they are the most time-consuming), but that's another project for now.

@chrissie-c
Copy link
Copy Markdown
Contributor Author

retest this please

3 similar comments
@chrissie-c
Copy link
Copy Markdown
Contributor Author

retest this please

@fabbione
Copy link
Copy Markdown
Member

retest this please

@fabbione
Copy link
Copy Markdown
Member

retest this please

@fabbione
Copy link
Copy Markdown
Member

retest this please

build: fix several issues with building tests

- MAINTAINERCLEANFILES should not rely on conditionals
  that could or could not clean files.

- EXTRA_DIST should not rely on conditonals that could
  or could not add files to the final tarball.
  sources should always ship.

- CLEANFILES should not rely on conditionals as
  ./configure can be done in between builds leaving
  stray files around.

- (cosmetic) move distclean-local: target with clean-local.

- drop old ipc_sock.test, start.test and resources.test
  shell files.

- fix make distcheck -j:
  - stop shipping or not shipping libstat_wrapper.so.
    libtool will only generate the .so when installing
    a shared library (--enable-install-tests).
  - make libstat_wrapper a module in a similar fashion
    of _failure_injection.
  - build ipc_sock.test in a similar fashion as ipc.test
    and link as module _libstat_wrapper.la.
    this solves multiple issues of having the binary
    in the final test builddir, no need to detect if
    libstat_wrapper.so is installed or not and workaround
    libtool different linking methods for inst vs noinst
    libraries.

- fix ipc.test linking with GLIB that should not be
  dependent on HAVE_FAILURE_INJECTION.

Run tests in parallel with dependancies
Make sure the two IPC tests use different socket names
Shortedn some names so they fit with the new ipc-names
remove ipc-test-name-sock
Fix resources.test now that ipc_sock is being run properly

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
Signed-off-by: Christine Caulfield <ccaulfie@redhat.com>
@fabbione fabbione merged commit a3aedbc into main May 26, 2023
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jun 21, 2023
https://build.opensuse.org/request/show/1093859
by user yan_gao + dimstar_suse
- Update to version 2.0.7+20230607.06c8641 (v2.0.7):
- blackbox: fix potential overlow/memory corruption (gh#ClusterLabs/libqb#486)
- tests: allow -j to work (gh#ClusterLabs/libqb#485)
- strlcpy: avoid compiler warning from strncpy (gh#ClusterLabs/libqb#473)
- timer: Move state check to before time check (gh#ClusterLabs/libqb#479)
- ipc: Retry receiving credentials if the the message is short (gh#ClusterLabs/libqb#476, rh#2111711)
- lib: Fix some small bugs spotted by newest covscan (gh#ClusterLabs/libqb#471)
- doxygen2man: Fix function parameter alignment (gh#ClusterLabs/libqb#468) (forwarded request 1093858 from yan_gao)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants