Skip to content

Add a magnificent test for backups#93659

Merged
tavplubix merged 6 commits intomasterfrom
test-for-backups
Jan 28, 2026
Merged

Add a magnificent test for backups#93659
tavplubix merged 6 commits intomasterfrom
test-for-backups

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented Jan 8, 2026 •
edited
Loading

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Backups could crash the server if you do many concurrent backups clashing over the same files.

See https://s3.amazonaws.com/clickhouse-test-reports/PRs/93577/c2e469a9dd997bf762ce856a63aac4b700ad2d5f//buzzhouse_amd_msan/fatal.log

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jan 8, 2026 •
edited
Loading

Workflow [PR], commit [799f6f7]

Summary: ❌

job_name test_name status info comment
Stateless tests (arm_asan, targeted) error
Integration tests (amd_asan, targeted) error

@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Jan 8, 2026
@alexey-milovidov alexey-milovidov mentioned this pull request Jan 8, 2026
Merged
1 task
@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Jan 8, 2026

Added commits from #93709.
At least, the fast test passed.

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Jan 9, 2026

But the problem still shows up.

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Jan 12, 2026

Now, integration tests showed something.

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Jan 13, 2026

By the way, it also happens on master often: https://s3.amazonaws.com/clickhouse-test-reports/json.html?REF=master&sha=bc3e79d54e60a6c9cd76ad89a969c9214b3bc44c&name_0=MasterCI&name_1=Integration%20tests%20%28amd_tsan%2C%204%2F6%29&name_1=Integration%20tests%20%28amd_tsan%2C%204%2F6%29

tavplubix
tavplubix reviewed Jan 22, 2026
View reviewed changes
tests/queries/0_stateless/03784_bad_base_backup.sh Outdated
Comment on lines +29 to +31
CREATE DATABASE d1 ENGINE = Replicated('/clickhouse/databases/d1', '{shard}', '{replica}');
CREATE DATABASE d2 ENGINE = Replicated('/clickhouse/databases/d2', 's0', 'd0');

Copy link
Copy Markdown
Member

@tavplubix tavplubix Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This collides with another test:

ClickHouse/tests/queries/0_stateless/03791_backup_engine_with_one_arg_must_not_crash.sql

Line 2 in 710687d

CREATE DATABASE d1 ENGINE = Backup(-5036955478727481395::Int64); -- { serverError NUMBER_OF_ARGUMENTS_DOESNT_MATCH }

https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=93659&sha=5c60569252fe9949a700341ced4323538ca7aa85&name_0=PR

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Jan 23, 2026

#94959

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Jan 23, 2026

@tavplubix, a few conflicts in private.

@tavplubix tavplubix added this pull request to the merge queue Jan 28, 2026
Merged via the queue into master with commit 2d68623 Jan 28, 2026
129 of 132 checks passed
@tavplubix tavplubix deleted the test-for-backups branch January 28, 2026 18:17
This was referenced Jan 28, 2026
Closed
Merged
Merged
Merged
Merged
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Jan 28, 2026
@robot-clickhouse-ci-2
Merge pull request #95463 from ClickHouse/cherrypick/26.1/93659
09d496c 
Cherry pick #93659 to 26.1: Add a magnificent test for backups
robot-clickhouse added a commit that referenced this pull request Jan 28, 2026
@robot-clickhouse
Backport #93659 to 26.1: Add a magnificent test for backups
1d92f7a
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Jan 28, 2026
Merged
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 28, 2026
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jan 28, 2026
clickhouse-gh bot added a commit that referenced this pull request Jan 28, 2026
@clickhouse-gh
Merge pull request #95464 from ClickHouse/backport/26.1/93659
e8db5e1 
Backport #93659 to 26.1: Add a magnificent test for backups
robot-ch-test-poll3 added a commit that referenced this pull request Jan 29, 2026
@robot-ch-test-poll3
Merge pull request #95459 from ClickHouse/cherrypick/25.8/93659
0c4b9bf 
Cherry pick #93659 to 25.8: Add a magnificent test for backups
robot-clickhouse added a commit that referenced this pull request Jan 29, 2026
@robot-clickhouse
Backport #93659 to 25.8: Add a magnificent test for backups
7366f3a
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Jan 29, 2026
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Jan 29, 2026
@robot-ch-test-poll3
Merge pull request #95460 from ClickHouse/cherrypick/25.10/93659
c98457a 
Cherry pick #93659 to 25.10: Add a magnificent test for backups
robot-clickhouse added a commit that referenced this pull request Jan 29, 2026
@robot-clickhouse
Backport #93659 to 25.10: Add a magnificent test for backups
7ebf952
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Jan 29, 2026
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Jan 29, 2026
@robot-ch-test-poll3
Merge pull request #95461 from ClickHouse/cherrypick/25.11/93659
154baa2 
Cherry pick #93659 to 25.11: Add a magnificent test for backups
robot-clickhouse added a commit that referenced this pull request Jan 29, 2026
@robot-clickhouse
Backport #93659 to 25.11: Add a magnificent test for backups
c42bf53
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Jan 29, 2026
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Jan 29, 2026
@robot-ch-test-poll3
Merge pull request #95462 from ClickHouse/cherrypick/25.12/93659
aeaec25 
Cherry pick #93659 to 25.12: Add a magnificent test for backups
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Jan 29, 2026
Merged
robot-clickhouse added a commit that referenced this pull request Jan 29, 2026
@robot-clickhouse
Backport #93659 to 25.12: Add a magnificent test for backups
dac6a13
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jan 29, 2026
clickhouse-gh bot added a commit that referenced this pull request Jan 29, 2026
@clickhouse-gh
Merge pull request #95529 from ClickHouse/backport/25.11/93659
0be43b1 
Backport #93659 to 25.11: Add a magnificent test for backups
clickhouse-gh bot added a commit that referenced this pull request Jan 29, 2026
@clickhouse-gh
Merge pull request #95527 from ClickHouse/backport/25.8/93659
df11cc6 
Backport #93659 to 25.8: Add a magnificent test for backups
tavplubix added a commit that referenced this pull request Jan 30, 2026
@tavplubix
Merge pull request #95528 from ClickHouse/backport/25.10/93659
d05e7d8 
Backport #93659 to 25.10: Add a magnificent test for backups
tavplubix added a commit that referenced this pull request Jan 30, 2026
@tavplubix
Merge pull request #95530 from ClickHouse/backport/25.12/93659
9f53db8 
Backport #93659 to 25.12: Add a magnificent test for backups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tavplubix tavplubix tavplubix left review comments

Assignees

@tavplubix tavplubix

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexey-milovidov @tavplubix @robot-ch-test-poll1 @robot-ch-test-poll4 @robot-clickhouse-ci-2