fix data race in DatabaseReplicated#93709
Merged
alexey-milovidov merged 1 commit intomasterfrom Jan 11, 2026
Merged
Conversation
Contributor
|
Workflow [PR], commit [e79ad81] Summary: ❌
|
CheSema
commented
Jan 8, 2026
| createDatabaseNodesInZooKeeper(current_zookeeper); | ||
| } | ||
|
|
||
| replica_path = fs::path(zookeeper_path) / "replicas" / getFullReplicaName(); |
Member
Author
There was a problem hiding this comment.
The race was here: replica_path is being changed when it already could be read in many others paces.
The fix is simple: this field is just a constant.
Member
tuanpach
approved these changes
Jan 9, 2026
Member
|
Let's backport this PR to older versions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92315
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes