Skip to content

Fix logical error caused by type mismatch in equals function#90557

Merged
nihalzp merged 7 commits intoClickHouse:masterfrom
nihalzp:fix-tuple-assume-not-null
Nov 21, 2025
Merged

Fix logical error caused by type mismatch in equals function#90557
nihalzp merged 7 commits intoClickHouse:masterfrom
nihalzp:fix-tuple-assume-not-null

Conversation

@nihalzp
Copy link
Copy Markdown
Member

@nihalzp nihalzp commented Nov 21, 2025 •
edited by clickhouse-gh bot
Loading

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix logical error caused by a rare case in equals function. Closes #88142.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Details

This query has logical error in master:

SELECT 1 WHERE (assumeNotNull(materialize(NULL)), 1) = (1, 1);

Additionally, #71756 and #86980 are resolved in master, most likely fixed by #89850. Tests have been added for them in this PR as well.

Closes #71756
Closes #86980

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Nov 21, 2025 •
edited
Loading

Workflow [PR], commit [529e163]

Summary: ❌

job_name test_name status info comment
Build (amd_compat) failure
Cmake configuration failure cidb
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: FAIL cidb
BuzzHouse (amd_tsan) failure
Logical error: 'false && "WriteBuffer is neither finalized nor canceled in destructor."'. FAIL cidb
BuzzHouse (amd_ubsan) failure
/home/ubuntu/actions-runner/_work/ClickHouse/ClickHouse/src/IO/VarInt.h:32:5: runtime error: store to null pointer of type 'char' FAIL cidb

@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Nov 21, 2025
@nihalzp nihalzp added v25.10-must-backport v25.11-must-backport and removed pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Nov 21, 2025
@Avogar Avogar self-assigned this Nov 21, 2025
@nihalzp
Copy link
Copy Markdown
Member Author

nihalzp commented Nov 21, 2025

Build (amd_compat)

@nihalzp nihalzp added this pull request to the merge queue Nov 21, 2025
Merged via the queue into ClickHouse:master with commit 1fe7b9e Nov 21, 2025
127 of 132 checks passed
@nihalzp nihalzp deleted the fix-tuple-assume-not-null branch November 21, 2025 15:33
@nihalzp nihalzp restored the fix-tuple-assume-not-null branch November 21, 2025 15:40
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 21, 2025
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Nov 21, 2025
This was referenced Nov 21, 2025
Merged
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Nov 21, 2025
@robot-ch-test-poll2
Merge pull request #90600 from ClickHouse/cherrypick/25.11/90557
dd1ef72 
Cherry pick #90557 to 25.11: Fix logical error caused by type mismatch in `equals` function
robot-clickhouse added a commit that referenced this pull request Nov 21, 2025
@robot-clickhouse
Backport #90557 to 25.11: Fix logical error caused by type mismatch i…
92a5e5d 
…n `equals` function
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Nov 21, 2025
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Nov 21, 2025
@robot-ch-test-poll2
Merge pull request #90598 from ClickHouse/cherrypick/25.10/90557
4dc678c 
Cherry pick #90557 to 25.10: Fix logical error caused by type mismatch in `equals` function
robot-clickhouse added a commit that referenced this pull request Nov 21, 2025
@robot-clickhouse
Backport #90557 to 25.10: Fix logical error caused by type mismatch i…
e34e572 
…n `equals` function
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Nov 21, 2025
Merged
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 21, 2025
clickhouse-gh bot added a commit that referenced this pull request Nov 21, 2025
@clickhouse-gh
Merge pull request #90616 from ClickHouse/backport/25.10/90557
3437963 
Backport #90557 to 25.10: Fix logical error caused by type mismatch in `equals` function
clickhouse-gh bot added a commit that referenced this pull request Nov 22, 2025
@clickhouse-gh
Merge pull request #90601 from ClickHouse/backport/25.11/90557
344926c 
Backport #90557 to 25.11: Fix logical error caused by type mismatch in `equals` function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Avogar Avogar Avogar approved these changes

Assignees

@Avogar Avogar

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-critical-bugfix pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo v25.10-must-backport v25.11-must-backport

Projects

None yet

Milestone

No milestone

4 participants

@nihalzp @Avogar @robot-ch-test-poll3 @robot-clickhouse-ci-1