Skip to content

Fix colorSRGBToOKLCH/colorOKLCHToSRGB for mix of const and non-const args#83906

Merged
azat merged 2 commits intoClickHouse:masterfrom
azat:sRGB-OkLCH-fixes
Jul 18, 2025
Merged

Fix colorSRGBToOKLCH/colorOKLCHToSRGB for mix of const and non-const args#83906
azat merged 2 commits intoClickHouse:masterfrom
azat:sRGB-OkLCH-fixes

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jul 17, 2025 •
edited
Loading

Note for reviewer - the first patch is cleanup, the last is the fix

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix colorSRGBToOKLCH/colorOKLCHToSRGB for mix of const and non-const args

CI: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=83828&sha=4135e8d6906675587e90eca9ea91cd2b2493be27&name_0=PR&name_1=AST%20fuzzer%20%28amd_debug%29
Fixes: #83679

azat added 2 commits July 17, 2025 14:25
@azat
Add separate namespace for ColorConversion
806c577
@azat
Fix colorSRGBToOKLCH/colorOKLCHToSRGB for mix of const and non-const …
bec9411 
…args

It is suboptimal, but I don't think it worth to add specific
implementations for const arguments for this functions
@azat azat requested a review from rschu1ze July 17, 2025 12:27
@azat azat mentioned this pull request Jul 17, 2025
Merged
1 task
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 17, 2025

Workflow [PR], commit [bec9411]

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jul 17, 2025
@azat azat mentioned this pull request Jul 17, 2025
Merged
@rschu1ze rschu1ze self-assigned this Jul 17, 2025
@azat
Copy link
Copy Markdown
Member Author

azat commented Jul 18, 2025

AST fuzzer (amd_tsan) — Logical error: 'Arguments of 'plus' have incorrect data types: 'x' of type 'Date

Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, 1/2) — Failed: 0, Passed: 3897, Skipped: 215
Stateless tests (amd_binary) — Failed: 1, Passed: 8233, Skipped: 11

@azat azat added this pull request to the merge queue Jul 18, 2025
Merged via the queue into ClickHouse:master with commit d028d72 Jul 18, 2025
115 of 125 checks passed
@azat azat deleted the sRGB-OkLCH-fixes branch July 18, 2025 08:59
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 18, 2025
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Jul 18, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Jul 18, 2025
Merged
robot-ch-test-poll1 added a commit that referenced this pull request Jul 18, 2025
@robot-ch-test-poll1
Merge pull request #83965 from ClickHouse/cherrypick/25.7/83906
905acbc 
Cherry pick #83906 to 25.7: Fix colorSRGBToOKLCH/colorOKLCHToSRGB for mix of const and non-const args
robot-clickhouse added a commit that referenced this pull request Jul 18, 2025
@robot-clickhouse
Backport #83906 to 25.7: Fix colorSRGBToOKLCH/colorOKLCHToSRGB for mi…
ad58a21 
…x of const and non-const args
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Jul 18, 2025
Merged
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 18, 2025
clickhouse-gh bot added a commit that referenced this pull request Jul 18, 2025
@clickhouse-gh
Merge pull request #83966 from ClickHouse/backport/25.7/83906
bc65a63 
Backport #83906 to 25.7: Fix colorSRGBToOKLCH/colorOKLCHToSRGB for mix of const and non-const args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschu1ze rschu1ze rschu1ze approved these changes

Assignees

@rschu1ze rschu1ze

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@azat @rschu1ze @robot-ch-test-poll @robot-ch-test-poll1 @robot-clickhouse-ci-2