Adding function to convert from sRGB to OkLCH and back #83679
Merged
rschu1ze merged 17 commits intoClickHouse:masterfrom Jul 16, 2025
Merged
Adding function to convert from sRGB to OkLCH and back #83679rschu1ze merged 17 commits intoClickHouse:masterfrom
rschu1ze merged 17 commits intoClickHouse:masterfrom
Conversation
|
|
Contributor
alexey-milovidov
approved these changes
Jul 13, 2025
Member
alexey-milovidov
left a comment
There was a problem hiding this comment.
This looks really great!
Interesting if we have to round results in the test reference (e.g., to three digits after decimal point), as there could be slight differences between aarch64 and x86_64.
rschu1ze
reviewed
Jul 14, 2025
rschu1ze
reviewed
Jul 14, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…nts in the code and documentration, slightly changed test for sRGB To OKLCH function
rschu1ze
approved these changes
Jul 14, 2025
Merged
via the queue into
ClickHouse:master
with commit Jul 16, 2025
c633f75
322 of 385 checks passed
azat
reviewed
Jul 17, 2025
This was referenced Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #80054
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Added SQL functions
colorSRGBToOkLCHandcolorOkLCHToSRGBfor converting colours between the sRGB and OkLCH colour spaces.Documentation entry for user-facing changes