Move object storage configuration to separate class#83599
Merged
Conversation
Contributor
kssenii
approved these changes
Jul 11, 2025
| DeltaLakeMetadataDeltaKernel( | ||
| ObjectStoragePtr object_storage_, | ||
| ConfigurationObserverPtr configuration_); | ||
| StorageObjectStorageConfigurationObserverPtr configuration_); |
Member
There was a problem hiding this comment.
May be raname Observer -> Weak as it is shorter and also consistent with DB::Context, where we have ContextPtr and ContextWeakPtr?
Member
Author
|
I've made tests rerun and the only failure I have now is performance tests related to sumMap. There is no code touched in this PR which is anyhow related to sumMap. |
Member
Author
|
I've discussed with an expert, |
Member
Author
|
This PR potentially is very conflicting, so I'll merge it. |
Member
Author
baibaichen
pushed a commit
to Kyligence/gluten
that referenced
this pull request
Jul 17, 2025
baibaichen
pushed a commit
to Kyligence/gluten
that referenced
this pull request
Jul 18, 2025
baibaichen
pushed a commit
to Kyligence/gluten
that referenced
this pull request
Jul 18, 2025
baibaichen
pushed a commit
to Kyligence/gluten
that referenced
this pull request
Jul 20, 2025
baibaichen
pushed a commit
to apache/gluten
that referenced
this pull request
Jul 20, 2025
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20250720) * Fix gtest due to ClickHouse/ClickHouse#83599 * fxi build due to ClickHouse/ClickHouse#83631 * Fix Build due to ClickHouse/ClickHouse#83294 * Fix Build due to ClickHouse/ClickHouse#82881 --------- Co-authored-by: kyligence-git <gluten@kyligence.io> Co-authored-by: Chang chen <chenchang@apache.com>
baibaichen
pushed a commit
to Kyligence/gluten
that referenced
this pull request
Jul 29, 2025
baibaichen
pushed a commit
to Kyligence/gluten
that referenced
this pull request
Jul 29, 2025
baibaichen
pushed a commit
to apache/gluten
that referenced
this pull request
Jul 29, 2025
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20250729) * Fix build due to ClickHouse/ClickHouse#76802 * Fix build due to ClickHouse/ClickHouse#81837 * Fix build due to ClickHouse/ClickHouse#84011 * Fix gtest due to ClickHouse/ClickHouse#83599 --------- Co-authored-by: kyligence-git <gluten@kyligence.io> Co-authored-by: Chang chen <chenchang@apache.com>
zvonand
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Sep 3, 2025
…n_to_separate_class Move object storage configuration to separate class
Closed
13 tasks
zvonand
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Sep 8, 2025
…n_to_separate_class Move object storage configuration to separate class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
This class is quite complex and deserves to be in a separate file.
Documentation entry for user-facing changes