Replace curl http client with poco http client for azure#83294
Merged
Replace curl http client with poco http client for azure#83294
Conversation
Contributor
alesapin
commented
Jul 4, 2025
| EXTERN_TYPES[ErrorCodes]=int | ||
| EXTERN_TYPES[ProfileEvents]=Event | ||
| EXTERN_TYPES[CurrentMetrics]=Metric | ||
| EXTERN_TYPES[LatencyBuckets]=LatencyEvent |
Member
Author
There was a problem hiding this comment.
I have no idea how style check worked before for IO/S3/PocoHTTPClient.h
alesapin
commented
Jul 4, 2025
| M(AzurePutRequestThrottlerSleepMicroseconds, "Total time a query was sleeping to conform Azure PUT request throttling.", ValueType::Microseconds) \ | ||
| M(DiskAzurePutRequestThrottlerCount, "Number of Azure disk PUT requests passed through throttler.", ValueType::Number) \ | ||
| M(DiskAzurePutRequestThrottlerSleepMicroseconds, "Total time a query was sleeping to conform Azure disk PUT request throttling.", ValueType::Microseconds) \ | ||
| M(RemoteReadThrottlerBytes, "Bytes passed through 'max_remote_read_network_bandwidth_for_server'/'max_remote_read_network_bandwidth' throttler.", ValueType::Bytes) \ |
alesapin
commented
Jul 4, 2025
| extern const Event S3FirstByteReadAttempt1Microseconds; | ||
| extern const Event S3FirstByteReadAttempt2Microseconds; | ||
| extern const Event S3FirstByteReadAttemptNMicroseconds; | ||
| extern const LatencyEvent S3FirstByteReadAttempt1Microseconds; |
Member
Author
There was a problem hiding this comment.
I had to do this renaming, otherwise style check is confused.
CheSema
approved these changes
Jul 17, 2025
Member
Author
|
Tests are green, I just resolved conflicts. |
Member
Author
|
All failed checks are actually green. |
baibaichen
pushed a commit
to Kyligence/gluten
that referenced
this pull request
Jul 18, 2025
baibaichen
pushed a commit
to Kyligence/gluten
that referenced
this pull request
Jul 20, 2025
baibaichen
pushed a commit
to apache/gluten
that referenced
this pull request
Jul 20, 2025
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20250720) * Fix gtest due to ClickHouse/ClickHouse#83599 * fxi build due to ClickHouse/ClickHouse#83631 * Fix Build due to ClickHouse/ClickHouse#83294 * Fix Build due to ClickHouse/ClickHouse#82881 --------- Co-authored-by: kyligence-git <gluten@kyligence.io> Co-authored-by: Chang chen <chenchang@apache.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Replace curl http client with poco http client for azure blob storage. Introduced multiple settings for this clients which mirror settings from S3. Introduced aggressive connect timeouts for both Azure and S3. Improved introspection into Azure profile events and metrics. New client is enabled by default, provide much better latencies for cold queries on top of Azure Blob Storage. Old
Curlclient can be returned back by settingazure_sdk_use_native_client=false.Documentation entry for user-facing changes