Skip to content

Remove allocation from the signal handler#76446

Merged
nikitamikhaylov merged 1 commit intomasterfrom
remove_allocation_from_signal_handler
Feb 19, 2025
Merged

Remove allocation from the signal handler#76446
nikitamikhaylov merged 1 commit intomasterfrom
remove_allocation_from_signal_handler

Conversation

@nickitat
Copy link
Copy Markdown
Member

@nickitat nickitat commented Feb 19, 2025 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Closes: #76444

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Removed allocation from the signal handler.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Feb 19, 2025

Workflow [PR], commit [1e8eed1]

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Feb 19, 2025
@nickitat nickitat added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Feb 19, 2025
@nikitamikhaylov nikitamikhaylov self-assigned this Feb 19, 2025
@nickitat
Copy link
Copy Markdown
Member Author

nickitat commented Feb 19, 2025 •
edited
Loading

Nikita suggests #76191 as the likely reason why we didn't catch it long time ago

@nickitat nickitat mentioned this pull request Feb 19, 2025
Merged
@nikitamikhaylov nikitamikhaylov added this pull request to the merge queue Feb 19, 2025
Merged via the queue into master with commit d3264f0 Feb 19, 2025
121 of 126 checks passed
@nikitamikhaylov nikitamikhaylov deleted the remove_allocation_from_signal_handler branch February 19, 2025 21:46
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 19, 2025
This was referenced Feb 19, 2025
Closed
Closed
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Feb 19, 2025
@robot-ch-test-poll3
Merge pull request #76479 from ClickHouse/cherrypick/24.11/76446
43393c1 
Cherry pick #76446 to 24.11: Remove allocation from the signal handler
robot-clickhouse added a commit that referenced this pull request Feb 19, 2025
@robot-clickhouse
Backport #76446 to 24.11: Remove allocation from the signal handler
7dca9f2
This was referenced Feb 19, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Feb 19, 2025
@robot-ch-test-poll3
Merge pull request #76481 from ClickHouse/cherrypick/24.12/76446
ba4cd31 
Cherry pick #76446 to 24.12: Remove allocation from the signal handler
robot-clickhouse added a commit that referenced this pull request Feb 19, 2025
@robot-clickhouse
Backport #76446 to 24.12: Remove allocation from the signal handler
86d0f52
This was referenced Feb 19, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Feb 19, 2025
@robot-ch-test-poll3
Merge pull request #76483 from ClickHouse/cherrypick/25.1/76446
1fcaea5 
Cherry pick #76446 to 25.1: Remove allocation from the signal handler
robot-clickhouse added a commit that referenced this pull request Feb 19, 2025
@robot-clickhouse
Backport #76446 to 25.1: Remove allocation from the signal handler
120a6c9
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Feb 19, 2025
Merged
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Feb 19, 2025
robot-ch-test-poll1 added a commit that referenced this pull request Feb 20, 2025
@robot-ch-test-poll1
Merge pull request #76482 from ClickHouse/backport/24.12/76446
3459342 
Backport #76446 to 24.12: Remove allocation from the signal handler
nickitat added a commit that referenced this pull request Feb 20, 2025
@nickitat
Merge pull request #76484 from ClickHouse/backport/25.1/76446
307fa85 
Backport #76446 to 25.1: Remove allocation from the signal handler
nickitat added a commit that referenced this pull request Feb 20, 2025
@nickitat
Merge pull request #76480 from ClickHouse/backport/24.11/76446
1c83351 
Backport #76446 to 24.11: Remove allocation from the signal handler
@yakov-olkhovskiy
Copy link
Copy Markdown
Member

yakov-olkhovskiy commented Feb 20, 2025

It doesn't fix all of the issue - another failure is caught here:
https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=76363&sha=13bdda96a3451743d9f2fb5e6ba93b314b4376cb&name_0=PR&name_1=Integration+tests+%28tsan%2C+6%2F6%29&name_2=test_storage_s3_queue%2Ftest.py%3A%3Atest_upgrade_3
Exception::getThreadFramePointers() returns copy of the vector - which calls operator new()
I'll create an issue and a PR with fix ASAP

@yakov-olkhovskiy yakov-olkhovskiy mentioned this pull request Feb 20, 2025
Closed
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created-cloud deprecated label, NOOP label Feb 20, 2025
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikitamikhaylov nikitamikhaylov nikitamikhaylov approved these changes

Assignees

@nikitamikhaylov nikitamikhaylov

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ThreadSanitizer: signal-unsafe call inside of a signal handler

6 participants

@nickitat @yakov-olkhovskiy @nikitamikhaylov @robot-clickhouse @robot-ch-test-poll2 @robot-ch-test-poll4