Fix: jobs stack trace object is not initialized properly#76191
Merged
yakov-olkhovskiy merged 3 commits intomasterfrom Feb 18, 2025
Merged
Fix: jobs stack trace object is not initialized properly#76191yakov-olkhovskiy merged 3 commits intomasterfrom
yakov-olkhovskiy merged 3 commits intomasterfrom
Conversation
Contributor
Member
|
Can we add a test? |
antonio2368
approved these changes
Feb 17, 2025
antonio2368
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed issue of stack traces from parent threads of a job (
enable_job_stack_tracesetting) are not printed out.Fixed issue
enable_job_stack_tracesetting is not properly propagated to the threads resulting stack trace content not always respects this setting.First issue was introduced by #67173.
The problem is that static thread_local members are lazy initialized, so
ThreadFramePointersis never constructed because it's never accessed. Solved by introducing initializer function which should be called at least ones at the start of a thread.