Skip to content

Fix renames of columns missing in part#76346

Merged
CurtizJ merged 2 commits intoClickHouse:masterfrom
CurtizJ:fix-concurrent-renames
Apr 27, 2025
Merged

Fix renames of columns missing in part#76346
CurtizJ merged 2 commits intoClickHouse:masterfrom
CurtizJ:fix-concurrent-renames

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented Feb 18, 2025 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed rare crashes while reading from MergeTree table after multiple asynchronous (with alter_sync = 0) RENAME COLUMN and ADD COLUMN queries.

Addition to #75693.
Fixes #75969.
Fixes #76006.
Fixes #77600.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Feb 18, 2025 •
edited
Loading

Workflow [PR], commit [c5c6e61]

CurtizJ
CurtizJ commented Feb 18, 2025
View reviewed changes
src/Storages/MergeTree/MergeTreeReaderCompact.cpp
}

column_positions[pos] = data_part_info_for_read->getColumnPosition(column_for_offsets->column.name);
serializations_of_full_columns[column.getNameInStorage()] = column_for_offsets->serialization;
Copy link
Copy Markdown
Member Author

@CurtizJ CurtizJ Feb 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a fix for query SELECT n.b.size0 FROM t_missed_subcolumns ORDER BY id;

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 18, 2025
@nikitamikhaylov nikitamikhaylov self-assigned this Feb 18, 2025
@nikitamikhaylov
Copy link
Copy Markdown
Member

nikitamikhaylov commented Feb 24, 2025

@CurtizJ Test failures seem related.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Apr 1, 2025

Dear @nikitamikhaylov, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself.

@azat azat self-assigned this Apr 20, 2025
azat
azat reviewed Apr 20, 2025
View reviewed changes
@azat azat mentioned this pull request Apr 20, 2025
Merged
@azat azat mentioned this pull request Apr 22, 2025
Merged
@azat
Copy link
Copy Markdown
Member

azat commented Apr 25, 2025

One more case (likely) - https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=79575&sha=23d16cead0485fcdf33c19b234e6d6e6d7235c1b&name_0=PR&name_1=Stateless%20tests%20%28debug%2C%20distributed%20plan%2C%20s3%20storage%29

@azat azat mentioned this pull request Apr 26, 2025
Merged
@CurtizJ CurtizJ enabled auto-merge April 26, 2025 21:45
@CurtizJ CurtizJ added this pull request to the merge queue Apr 27, 2025
Merged via the queue into ClickHouse:master with commit 2bf1a49 Apr 27, 2025
115 of 122 checks passed
@CurtizJ CurtizJ deleted the fix-concurrent-renames branch April 27, 2025 01:46
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 27, 2025
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Apr 27, 2025
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Apr 27, 2025
@robot-ch-test-poll2
Merge pull request #79639 from ClickHouse/cherrypick/25.2/76346
62ef77c 
Cherry pick #76346 to 25.2: Fix renames of columns missing in part
robot-clickhouse added a commit that referenced this pull request Apr 27, 2025
@robot-clickhouse
Backport #76346 to 25.2: Fix renames of columns missing in part
4d98a3f
This was referenced Apr 27, 2025
Closed
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Apr 27, 2025
@robot-ch-test-poll2
Merge pull request #79641 from ClickHouse/cherrypick/25.3/76346
a3fd532 
Cherry pick #76346 to 25.3: Fix renames of columns missing in part
robot-clickhouse added a commit that referenced this pull request Apr 27, 2025
@robot-clickhouse
Backport #76346 to 25.3: Fix renames of columns missing in part
75bc1c8
This was referenced Apr 27, 2025
Closed
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Apr 27, 2025
@robot-ch-test-poll2
Merge pull request #79643 from ClickHouse/cherrypick/25.4/76346
92fa1aa 
Cherry pick #76346 to 25.4: Fix renames of columns missing in part
robot-clickhouse added a commit that referenced this pull request Apr 27, 2025
@robot-clickhouse
Backport #76346 to 25.4: Fix renames of columns missing in part
7ddbe77
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Apr 27, 2025
Closed
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created-cloud deprecated label, NOOP label Apr 27, 2025
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Apr 27, 2025
@CurtizJ CurtizJ added pr-bugfix Pull request with bugfix, not backported by default and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels May 19, 2025
@azat
Copy link
Copy Markdown
Member

azat commented May 25, 2025

@CurtizJ can you please take a look at pending backports?

@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azat azat azat approved these changes

Assignees

@azat azat

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

7 participants

@CurtizJ @nikitamikhaylov @azat @Algunenano @robot-clickhouse @robot-ch-test-poll3 @robot-clickhouse-ci-1